Re: Sashiko reviews for pahole: missing custom_remotes

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Mon, Jun 22, 2026 at 05:16:46PM -0300, Arnaldo Carvalho de Melo wrote:
> On Mon, Jun 22, 2026 at 12:18:10PM -0700, Roman Gushchin wrote:
> > Sashiko is not really officially supporting a non-kernel code yet. It might work occasionally,
> > but I can’t guarantee anything and results might be pathetic.
 
> I'm using it locally with great results, using:
 
> acme@number:~/git/sashiko$ cat Settings.toml | grep -B1 -A3 'dwarves\|pahole'
> [mailing_lists]
> track = ["linux-kernel", "dwarves"]
 
> [nntp]
> server = "nntp.lore.kernel.org"
> --
> [[git.custom_remotes]]
> name = "pahole"
> url = "git://git.kernel.org/pub/scm/devel/pahole/pahole.git"
> check_all_branches = false
> only_branches = ["next", "master"]
 
> acme@number:~/git/sashiko$
 
> Submitting series to sashiko with:
 
> $ sashiko-cli submit FIRST_SHA^..LAST_SHA --repo /home/acme/git/pahole
 
> With great results, for instance:

> > We might explore adding support for more project going forward, but we’re not there yet.
 
> Your call, but just as a data point, its being useful for me for pahole
> development and I bet other pahole developers would like having it
> enabled, since it seems to be useful with the current sashiko codebase.

This series:

https://lore.kernel.org/all/20260622202441.14799-1-acme@kernel.org/

For instance, has several bugs addressed from review comments by
Sashiko, that is credited:

commit bf5e28c65bc52e61361a676acc9d2913b6d9e065
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date:   Fri Jun 19 11:34:02 2026 -0300

    tests: Guard cleanup() against empty outdir to prevent rm /*

    If make_tmpdir() fails, outdir is empty.  The cleanup() function
    executes rm ${outdir}/* which expands to rm /* when outdir is unset or
    empty — potentially deleting the entire root filesystem.

    Add a guard to check that outdir is non-empty and points to an existing
    directory before attempting removal.

    Fixes: 52dbfb0b39595ed8 ("pahole: Refactor selftests")
    Reported-by: Sashiko:gemini-3-1-pro-preview # Running on a local machine
    Assisted-by: Claude:claude-opus-4-6
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
   
Cheers,

- Arnald