From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17FF31C5F13 for ; Mon, 22 Jun 2026 23:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782171034; cv=none; b=FPlSE2b3uqLkQ0Y8m0QAwKPDVNRV9J6x/1Muo+ZgTheKPf+mjnxyFwnl3RPEyb93MKBfr8IW0K5uaAZeAXXLa4C0oJHXTHNwtbQW2HdyfUNLhlvnSYtLwgNBWSoCjUo+39vC3KX9Kft5PK34CFMzandzwmxdai8F5E5Rau/e6FA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782171034; c=relaxed/simple; bh=Id55ZmT3Ny8JY/8w5j8U96LeMpdqCvG/wazyNv7Ousw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VMqKdhQ5wQeY1rrfngQ7304iNkoBSRRabjwEA8xpJP4sDFWdWKyq/iMa0E9PQb4LeP3cgPsNDxmQgravavAADrvj8eHuT780eudpi07KsnY8BGgdwqecEp73P134W6b3Vk3uaveI11oAhqBoxDeaFgbh8dHfW/q0AziMt5BJlh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aokcpAE8; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aokcpAE8" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2c6b7bd4e8dso18505ad.0 for ; Mon, 22 Jun 2026 16:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782171032; x=1782775832; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BLj+HmvLjzLOHpEqRh1wn6kUXzQVKOV8V8gw6F5PDGc=; b=aokcpAE87Kn98/h0fB6RLRD3O63kEetrYazOFTvvD0XH83iAbWWOOC++WSuZrqMsmy gEoqb9UUWTbYCj8VIKbAvXPXx+eLfGt8aNL7M1gsK5y0b7/AD+Zp0VXI+Gw1F9B9M6yh W05Szs1qM2CZiiAOzSK7uwHlRtWbyDjysnlZ5U96g5CiCxIWiEQVQzjA7LkJsUZHYJcY h7KJx+OBzhMlb2ixzkRDlv1mX6DrCxxW6Lr9MoMIQkz0jUgMmo2b2ySNmjV4KKPEPdS7 HrXAmdeGaRlNMGcxS7FVV3HwqQleMXBVJxltidWM264I3DwlWXoR/PD3InZKhVFvM3YL jMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782171032; x=1782775832; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BLj+HmvLjzLOHpEqRh1wn6kUXzQVKOV8V8gw6F5PDGc=; b=IoVEgDj2InoHumK/5CA+EOm3YzGkOlUKhjy+rzw7pyL/6xpg2FGlJEvI+AhYzRnyZ1 S/6QIVDx0+x0tlrghKcDjdIKWvKqxYFF6/erfIAHVWrxRIQZ+0Zbeh71qbLATaT4lwwB 8hNmyN8Hoq9ifPOLVIZphcZNyitLJoNLOBsIfBcnG+JXAen40bB4K1rqJqgJlk7gsNuR Ry5w/X9MtCZUR3QHJ86w2grLjq7WnrOUSFxBhYPggHlRCTGazVEmWLeGECjveAwYi09Q gPEUvV91VMtDLA/eHhn73wvEAouMu5f10yPIXFjG09SjU2BPMZv+ss9uLKpxMOQuNbv/ g5PQ== X-Forwarded-Encrypted: i=1; AHgh+Ro8BcP+zBcG0/rCctldRjCTZ2cU2aEdVLiYW5dCoMy4yMcJ9BFWIqNtoKze57w58JbakyT7DUwP26S6jAM=@vger.kernel.org X-Gm-Message-State: AOJu0YzHxzCC4UJb2KlwXOzu3xJAlJ/9FcOiGcj+PNbOi96AIffeUC3k MC07oyEyyszvvdQjwsqCexsaPrQkrXlYv7fXa5ZZYN0v6DqyGJ1zfi2Bm/RmMYz64w== X-Gm-Gg: AfdE7cmlVf2aNT0iDj44wf8msHoASt+fZHSryqU7KSDalsKfFG8DD7P6WOeM6l1tB4t 2L6hFJDAwm3WwFGpKMGEe0CoPwlGxwRihqIYi/Ekv8BCHMHJ9ZRp/PznPSc/ARfCeGl+BqZgBb+ OjZy6mH/CpEZFYl9khQg+KHfBvw+VI8NGJrkF6KEXN39au/iIlNw9m2GqUfH5QMSzP7vQ4q+R+b k/4ZtQCPui8vuhjUhh1a5OcyWY9p8Vi3PkziWEZszEutStWbJ3PkRflHnNtcvPajI41agn/MQnR qE+2hrKuyJDQsi1uFAPGF9vCCuw+KoGtt5XKFH6HMQGPf9K3OjIUhSP+ie9+ySnkN9fYLtZW6RS dzFlSFrAgVxONJ6jmX8OdZhVRxF3MB/q6Zye65BQhI6YWzVIcPUw7gW46UyubW2qeqo9wa33HF6 LXvaf+iybqAOrpFJDR1oakTOw2ZdaizJwCn+sTiZg0hHFhvNu1BmgcY4qy9szMhxHSzXMe4zMOR fWXUZ2V X-Received: by 2002:a17:902:ec88:b0:2c1:ee6e:4e4e with SMTP id d9443c01a7336-2c7c713f231mr649335ad.31.1782171030705; Mon, 22 Jun 2026 16:30:30 -0700 (PDT) Received: from google.com (25.75.145.34.bc.googleusercontent.com. [34.145.75.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d1aa087e9sm2638998a91.2.2026.06.22.16.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2026 16:30:30 -0700 (PDT) Date: Mon, 22 Jun 2026 23:30:26 +0000 From: Samiullah Khawaja To: Baolu Lu Cc: David Woodhouse , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Pranjal Shrivastava , Vipin Sharma Subject: Re: [PATCH v3 10/18] iommu/vt-d: Restore IOMMU state and reclaimed domain ids Message-ID: References: <20260614233728.2212104-1-skhawaja@google.com> <20260614233728.2212104-11-skhawaja@google.com> <23d4a3b9-41ac-4e05-ada6-01b6ae5e9f04@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <23d4a3b9-41ac-4e05-ada6-01b6ae5e9f04@linux.intel.com> On Mon, Jun 22, 2026 at 01:14:48PM +0800, Baolu Lu wrote: >On 6/15/26 07:37, Samiullah Khawaja wrote: >>During boot fetch the preserved state of IOMMU unit and if found then >>restore the state. >> >>- Reuse the root_table that was preserved in the previous kernel. >>- Reclaim the domain ids of the preserved domains for each preserved >> devices so these are not acquired by another domain. >> >>Signed-off-by: Samiullah Khawaja >>--- >> drivers/iommu/intel/iommu.c | 87 +++++++++++++++++++++++--------- >> drivers/iommu/intel/iommu.h | 7 +++ >> drivers/iommu/intel/liveupdate.c | 60 ++++++++++++++++++++++ >> 3 files changed, 130 insertions(+), 24 deletions(-) >> >>diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c >>index 26258861e3bf..cd40e274482b 100644 >>--- a/drivers/iommu/intel/iommu.c >>+++ b/drivers/iommu/intel/iommu.c >>@@ -990,15 +990,16 @@ static void disable_dmar_iommu(struct intel_iommu *iommu) >> iommu_disable_translation(iommu); >> } >>-static void free_dmar_iommu(struct intel_iommu *iommu) >>+static void free_dmar_iommu(struct intel_iommu *iommu, struct iommu_hw_ser *iommu_ser) >> { >> if (iommu->copied_tables) { >> bitmap_free(iommu->copied_tables); >> iommu->copied_tables = NULL; >> } >>- /* free context mapping */ >>- free_context_table(iommu); >>+ /* free context mapping if there is no serialized state. */ >>+ if (!iommu_ser) >>+ free_context_table(iommu); >> if (ecap_prs(iommu->ecap)) >> intel_iommu_finish_prq(iommu); > >disable_dmar_iommu() and free_dmar_iommu() are always paired in the >code. How about merging them into a single helper that is aware of iommu >preservation? Something like the following? > >static void release_dmar_iommu(struct intel_iommu *iommu) >{ > struct iommu_hw_ser *iommu_ser = > iommu_get_preserved_data(iommu->reg_phys, >IOMMU_INTEL); > > /* > * All iommu domains must have been detached from the devices, > * hence there should be no domain IDs in use. > */ > if (WARN_ON(!ida_is_empty(&iommu->domain_ida))) > return; > > if ((iommu->gcmd & DMA_GCMD_TE) && !iommu_ser) > iommu_disable_translation(iommu); > > if (iommu->copied_tables) { > bitmap_free(iommu->copied_tables); > iommu->copied_tables = NULL; > } > > /* free context mapping if there is no serialized state. */ > if (!iommu_ser) > free_context_table(iommu); > > if (ecap_prs(iommu->ecap)) > intel_iommu_finish_prq(iommu); >} This looks great. I will update this in v4. > >Thanks, >baolu > Thanks, Sami