From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FA2D396B73 for ; Tue, 23 Jun 2026 07:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782199102; cv=none; b=MKJn9oa80xZK+eiGNZ/hoGv3A2GFEZxe3mQcvaN95TIK9Xt5Gx1vUP4j+BACgsQmwUB/b4ujYAb1Rju1ITqD1/8qO75TXIFz5uoP5ZpcubFAE2oXSvZiOYBzvRIfEpKmJxqCMTLxyqoxgfKcxUcWyfoQjeCTfqKLGr7vkr2cGtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782199102; c=relaxed/simple; bh=hqE78zs9IRTrD6cZJabx1OyLprOkgznQThC+LS3PnLI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Vchy3KLXsQR5ORhl9VnlhmaI85ykHD4azEYraRb8VeDaRtDDOTUQewEW4CaMy4tGlMn1q7lQgipClVgch/Fn8VNbZCUOu1c/YWWcPEvfMoaBSK58PmnrG8MIOiDy+xwi4NoTwGCZUkNoW+9tfJPv+SulhiUmnkq4qCOrMhQVcLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BVWarD2g; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BVWarD2g" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-49244130073so21971895e9.1 for ; Tue, 23 Jun 2026 00:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782199100; x=1782803900; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=P9/fLZkP9Srk0NC3L4Jzfv0T43DYYXN2q8SSyx7gNW8=; b=BVWarD2gNpLdNafau+piN4PPYu3W8jsU8rpzyy1+rNJCy7fq0xNFGFnfc+rViG6Pt4 Coom7vfbfZYC393HzOQlh5Hjrl2wrnNLHxh7GGT3Dwv800TutONiIyxLZPQehUcahVvO zb2VneM0OO65j+CnfWRh9vgpw7CNZRyZrDZFsKo4HRmkOUxQKkZ/F+MGoVd4sO6GvYdq r+m4bNzAtR7nJtHE7y7AFCA4EwMgvgUkXFGhd/3IGc41OUUYTgnJWIpzs4sDXsjqQ6fJ BE3GEW6oBY9AlmYkPvKrsfLF3etNxyLTC2SegxJhttXT9VKC3fAmq/sJp74vNWoelKLl KXAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782199100; x=1782803900; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P9/fLZkP9Srk0NC3L4Jzfv0T43DYYXN2q8SSyx7gNW8=; b=mu+cGlJVfQbPJSMFcrUdQHWoNObWmQ33tOWlQfME4C++9y+syXdcHz/tiPXrdHmsmW qcFzlKxzwFON2y8UHOu8OE8E6xh0jmr/sdkdADicclAYEb8PYEsH/y1UyHOFLoHMk/0M JWzyQOffkiggzOcbERic4HuksYxJNUA80Vdjan/52xBMYoWMX+mza8/2joZDJ5Hsm0LT 0b5Mtac9rn4lFs/F+GcE+tzyxEt5PlC50O3eXaMKcRIyviURWjoQz0yxjZ4vEvxU9dGU 3Ckg23Ipg0DuGzAFGpRlqnR4++1Nc4SfFhIDitfNWJ3gF3w1LHTnboeBUTQbKVaHIOpb 3keA== X-Forwarded-Encrypted: i=1; AFNElJ9/khOBH2iieVJHG0wxFxy2d3cHBSsUSUOsMCNgpBSrz8N0eXS/S5/lCTOdO1njZN0zJF690dy5wbJaB8I=@vger.kernel.org X-Gm-Message-State: AOJu0YzPSuQA/E6DYINPkwFVc/u/I2Rmnb9kUnVIkJZgOXPiNY0GMBfs MZWicWrFu8KC+2DsNc8xc9qd5oLFZ6a/0lJY3VGqnbzQ8mvHq4DDFK3bV6OLxuabTLbA2foHdh2 Rk0OraxIBd/sDcGDaRg== X-Received: from wmbjr26.prod.google.com ([2002:a05:600c:561a:b0:490:af44:67a5]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1f85:b0:490:44eb:c1d9 with SMTP id 5b1f17b1804b1-4925b380308mr19335035e9.28.1782199096405; Tue, 23 Jun 2026 00:18:16 -0700 (PDT) Date: Tue, 23 Jun 2026 07:18:14 +0000 In-Reply-To: <20260619220141.3193697-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260619220141.3193697-1-tristmd@gmail.com> Message-ID: Subject: Re: [PATCH] binder: free fd fixups on superseded transaction teardown From: Alice Ryhl To: Tristan Madani Cc: Greg Kroah-Hartman , Carlos Llamas , Todd Kjos , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Li Li , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tristan Madani Content-Type: text/plain; charset="utf-8" On Fri, Jun 19, 2026 at 10:01:41PM +0000, Tristan Madani wrote: > From: Tristan Madani > > When a TF_UPDATE_TXN oneway transaction supersedes an outdated pending > transaction, the outdated transaction is freed with kfree() but its > fd_fixups list is not cleaned up first. Each binder_txn_fd_fixup on > the list holds a reference to a struct file (from fget in the sender > path) that is never released. > > All other transaction teardown paths (binder_free_transaction and the > error paths in binder_transaction) correctly call > binder_free_txn_fixups() before freeing. Apply the same cleanup to > the t_outdated teardown path. > > Fixes: 9864bb480133 ("Binder: add TF_UPDATE_TXN to replace outdated txn") > Cc: stable@vger.kernel.org > Signed-off-by: Tristan Madani Seems reasonable to me. Reviewed-by: Alice Ryhl