From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5D02DECDF for ; Tue, 23 Jun 2026 09:00:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205215; cv=none; b=ZBQr3r29WNvmo+vPIhFaDALQXcugCStoQAn+623lC6izPUIk7yfpfTixRiH9FpBvQtahiYxxYf8W3mJO1GLuiK/dUt9zP7rfzQ7E3kB6R6cH7TEqaN2GsUPBZ6zHFrfI3moQpH0krRqq8Hr+P6Yzl9K3sdzYDyY+yh148JIHra4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782205215; c=relaxed/simple; bh=IA6DnmpsemgYjF0EMK73a8x7Pqm7RpM398h0o+omG6E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ssKI6Sw/TnfrLUMkR9ncmStpG48Y1c7t48B/5gOMyLOwyC2i+6kuLJxr+1rkC12/a0ssjRV0iqD4HFf7IyBc0/eD29SeGiBrYm/QiQRofR+Wc9zQVNOBvdJhAaBCe8DWTigm3Tc7ivGenFwDO5vwbnwfiJ0GPjpvivo4gGV0Hq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=clNX9Jl/; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="clNX9Jl/" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-697cd867710so1899942a12.1 for ; Tue, 23 Jun 2026 02:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782205212; x=1782810012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MOQX8xqxBJPocdJUjjpZRh5SF3BDRR1529+3bYBkUq8=; b=clNX9Jl/7edWdg1qtePXMn/dURulBac6xWFzAr+HPzrPbi+ByOXlFanMAh0tescMqO KIf8wHhshngxmICAcf23coG7nb8AGWfmWQMpK/3fICC3czqz3Qh2/0sPQifbCxoCZeGm LVVrpKP6r25FxPa6TiLEWWgo6nYasLxTNqoorI9iziC6wf95PZ4jNVo347/ge+B3ntwP LOYq8NCL6m16pA+qHEll6tbOea6j5QikhbdR69GRS//UwdS/yMiVoTntQwcafuvly9mO nCACKHi50xl4h5qoDRI2fsaruqRKQSrquu80TxMCnw9ijO5HZdYmxqHU+cDV/xgceQIj O9KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782205212; x=1782810012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MOQX8xqxBJPocdJUjjpZRh5SF3BDRR1529+3bYBkUq8=; b=cDJqgEZEec+MmGh8hp+L6wUash1IxBVNUlGIMUeTZmS1r/8bDR3+f73URpf5XWuZjW T9kf0S924xYhjHujBcv/bUGUaTRRdkrE26lARsfEVI/x4N5Q+WXyv0hWsq9lvHzpJs2U dNHaOT4XEtoxeGa3rrbTPDvZBUcsSPiVi6VK9ga3dFap3/tTtzJK5ToEijxqWTWABWQz MXxxKwEtIGduhypnfctx3DcdQhqNGmOOwlaSwtO/IrEtiMwdXtQgu6js+hbq3fYYi3rV BxZp/y17mEzRYbFKSHkSLUjmUr7cCQbVJ9LfkXV5vGAAMFH5Rf4woTXTznT86GBDKVIb 0Klg== X-Forwarded-Encrypted: i=1; AFNElJ8rI+jJdlOuIWJM9WbN468DEODDhZmbP+rzXkg3em9unu2Pp7HcAxVk1hmdqGyMeqUoM/q4lfX9j8Pf+m4=@vger.kernel.org X-Gm-Message-State: AOJu0YxkvbDcJSlb5ow8dJUEyokTTS3t4yiwF1tHMvE9Id/gmnHjPNUU LuYDV2weW6ZirRcZdUCIvN9fXIitUgBWEoxEJ9DBrNMHItEEasVTTXge X-Gm-Gg: AfdE7ckpya0mw1Q//xS5lQjIRs387kb+5VGJa6rAkNrsJfRfhSwJWA+Mw4THJ8018SI xsvRTycY7SHYpYG3RkUW5KmJvS6YsnHr772EfmW71jJVRAne7Y85sOLHFpud6LfPgeZfkFl7AAy 59yxryPguB+b4VABB7+O6ah1WvtuSsVQriPm8kHZZx7MC3w3zvtpNvkDwSUTKBef9ybE4W2b1dR 0iR5u6/nIa2uQ9xqJg2EUh1tFWDPsw69jq6a5KTJ8W2agta+cAO3Q3jTTTCLYLHrlNPb20bVVq/ P8D6a4pP13XdwRWmVfzIhf1HZO6oANC0YRRYB2tpqMezwcKftlyQUBvCLWLIETcQ8n7hZeaMSva pYSLPKxHZDGj8Vugjobn+qpDcUIVwwI1MCI/7BBAbZRvuWSuTbXl0fbxcQThT2XN6l25o+KW0Mw 6gsMLAf38yft6UUiA0mMU= X-Received: by 2002:a17:907:3e21:b0:c0e:b685:66d with SMTP id a640c23a62f3a-c0eb6850993mr413768866b.41.1782205211794; Tue, 23 Jun 2026 02:00:11 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c60aca46csm480036766b.36.2026.06.23.02.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 02:00:10 -0700 (PDT) Date: Tue, 23 Jun 2026 12:00:07 +0300 From: Dan Carpenter To: Aditya Chari Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove unused function declarations Message-ID: References: <20260622052543.61590-1-adi25charis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260622052543.61590-1-adi25charis@gmail.com> On Mon, Jun 22, 2026 at 10:55:43AM +0530, Aditya Chari wrote: > rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() > are declared in rtl8192c_recv.h but have no implementation and no > caller anywhere in the kernel tree. They are leftover from when this > driver was derived from Realtek's shared vendor codebase covering > multiple chip families. > > Verified via grep across the full tree that neither symbol is > referenced outside this declaration, and confirmed via a full build > of the module before and after removal that no warnings or errors > are introduced. > > This addresses the "find and remove any code for other chips that is > left over" item in the driver's TODO file. > > Signed-off-by: Aditya Chari > --- You're working against an old tree. Work against linux-next or devel-next. regards, dan carpenter