Re: [PATCH v4 1/4] Input: snvs_pwrkey - make use of dev_err_probe()

[Joy Zou <joy.zou@oss.nxp.com>]

On Thu, Jun 18, 2026 at 07:38:00AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> 
> Pre-existing issues:
> - [Medium] Memory leak of struct wake_irq on device unbind
> --
> 
This is a pre-existing issue that won't be fixed in this patchset.
Will address it in a separate fix.
BR
Joy Zou
> commit 469e290fcf154d6638767e1e60cb2427638bea98
> Author: Joy Zou <joy.zou@nxp.com>
> 
> Input: snvs_pwrkey - make use of dev_err_probe()
> 
> This commit updates the probe function of the snvs_pwrkey driver to
> use dev_err_probe() for error handling. This simplifies the code and
> improves logging for deferred probes.
> 
> > diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
> > index 954055aaf6e29..8cc6863d26ed8 100644
> > --- a/drivers/input/keyboard/snvs_pwrkey.c
> > +++ b/drivers/input/keyboard/snvs_pwrkey.c
> [ ... ]
> > @@ -209,16 +201,12 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
> >  	error = devm_request_irq(&pdev->dev, pdata->irq,
> >  			       imx_snvs_pwrkey_interrupt,
> >  			       0, pdev->name, pdev);
> > -	if (error) {
> > -		dev_err(&pdev->dev, "interrupt not available.\n");
> > -		return error;
> > -	}
> > +	if (error)
> > +		return dev_err_probe(&pdev->dev, error, "interrupt not available.\n");
> >  
> >  	error = input_register_device(input);
> > -	if (error < 0) {
> > -		dev_err(&pdev->dev, "failed to register input device\n");
> > -		return error;
> > -	}
> > +	if (error < 0)
> > +		return dev_err_probe(&pdev->dev, error, "failed to register input device\n");
> >  
> >  	device_init_wakeup(&pdev->dev, pdata->wakeup);
> >  	error = dev_pm_set_wake_irq(&pdev->dev, pdata->irq);
> 
> [Severity: Medium]
> This is a pre-existing issue, but does this dev_pm_set_wake_irq() allocation
> leak when the driver is unbound?
> 
> Because this driver relies entirely on devres for resource management and
> does not implement a .remove callback, there is no explicit call to
> dev_pm_clear_wake_irq() upon driver unbind.
> 
> The device core does not automatically free dev->power.wakeirq during
> device_pm_remove(), so this allocated wake_irq structure appears to leak
> every time the driver is unbound.
> 
> Could this be fixed by switching to the managed variant,
> devm_pm_set_wake_irq()?
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260618-b4-pwrkey-v4-0-4bfda105bdf3@oss.nxp.com?part=1