From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6AF73264CB for ; Tue, 23 Jun 2026 14:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782226078; cv=none; b=MalJOq6rMvkfaGkA2egrW1qYM2CIpaL6wTCoExn1plB1WfUzNlBmWqEfQpDgTSvoRBaiqT8FAPWVQg0TR9USxGkblr2HcJx+Yri5RIKW+NRpmtmU2dgYSfCWJilh1rBsSMapZ2zONAXIE/wFaigGFmwnN9eWTzLQuFEDlbx2Kdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782226078; c=relaxed/simple; bh=Dmg3h98CAd9mVBXdZvZ5kudQrJRTkhJjHX3en7MIrJ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NrU8Z9DqZEzRrGNPhM2BcE1y3i8FE7+bPlEeFjr0pNW2tTkxa2xLzFd7sixBA6PqI+XMTEeEQkdXGdC1qJoG0p+F0yLzy6CdQOMLbSdt0z+jRNr8QX0My2E11dWUoZPIt+Qx/IOlPP7Cbc8RbYJqCzHhcxm1GYHLHqe7Nrc3xks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=JEDuPXdY; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="JEDuPXdY" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-46019b190b6so4419582f8f.3 for ; Tue, 23 Jun 2026 07:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782226075; x=1782830875; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OgKkR9PE3+f2BLL6PMOel5+o22PqOxxmTVpoZ1H8gek=; b=JEDuPXdYqX9vARtU0gSqub6/va9MOX9wcKkHC1jBfbnZ90pnVuQlSzShImi5YVb8Kq 6zNdy0jWJnREIjazoDbYCx/560vAuLAUT8Jj5j6BZwgYBkgAcIids3iXdyKXFZC2z4Qj Eav1QYTLAJk28bWO+uS1+kG+Xb/qNlVykAlclJx2OGOVYNMnW80fpveYpljf0/6WWj50 Cun6zj7tbGrilj4Esl3YwU/AgJwIP+aUbLY0VjiyOuOOpNByjvee7LJdMg3s8p+9cMOa IIZ+Ra2N7jGOlqTSJoF171SrNiHQHOolyzCnvQ+OrsBfDp7ddKNmmkMkHsxPoP8X2srv YsXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782226075; x=1782830875; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OgKkR9PE3+f2BLL6PMOel5+o22PqOxxmTVpoZ1H8gek=; b=VOaSzqMNwQGvK1R2GF0hyapg7/Ya7L8Y38lSi45f4jotKFs3e3PZrSLLNZCfbjNdxR EmCqtBvJnk/WumOX2mE+jqIktqFpyMxvWQ4zfUS+VQ2916FXYB1+kG34PUyI9r/8pQg7 2c/CV0wuPyrV7g68MX86qEr9Fg3IfT3g4DATkyWpKJawRLxGRqiFHKTwgFyLe9sUHH1b J58Ss75GxCDdi8wgW3lNYDuKE8H2B51FiMwRJ1RfAsMmsjIEtHF4KuUYG9JlufW3L2g8 WUqJ8hYQL3wxjatFDxW4Q94vBO0BpA9QGVPznAqg402fOnYIm9WYJukyw7HA56goOopB Zi9Q== X-Forwarded-Encrypted: i=1; AHgh+RroZRHz3byk2svhw08vAnIoZYDSpbVeK3gGqRMtTSWGYmFEPKginvs/YQ/SL8k152f5vV2IdsXlxGQPbWc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxiz4rzJb4IKUMjIQpU9edb83NlJff/JTkBWQrpBvL7jEEVkA1U IIMQ8hGYvfq0kA7EkViMFnXya5Nci2eWNeJ8gh08mwz65g/k4aT08Poay3RKMwtapCA= X-Gm-Gg: AfdE7clgVxVQq5y7XE7heA4zM4I+Pqr+zKNesP3hPAbdsmqqfDgDxFWUhW9gZWd8pCW fz2ZYQSlkYeEL7bkThJV7/0+oWUsZh7xxvPWTQKch+oa8Dp/Y8K2h7RlAtt2nTDnP8rHvl+dgK8 8r0Q9fqpR+q2gbf4uwxtknCH1H1GiBPnLaCbC4Gdyv7sBSV6f1kdIk9pcGvYkiF8CkhCNA1/98l SzgJX3YO/PRjgplVfQOuH8lqg6GtPsb3Egt7xAxL4mhkGRvMaHQGVUp6v+u/WSmv0M4xK3IvU2a si43bwxxFwn+FnwwnULuF6UDgE1q4GnHWQ/WXagNHRv6Y/GCgwQq8Nhxsr7jXkqgb4LwGFsG5ve CcTZrxXarIf4DLrQUr490V8/qIrDjO4eA/mJYXtEQp4MDVuaSlBn0qV5lPtKBdbuwcT5EOvFuD2 OVoFAY+c0RYWkqJQ1IrATyqo+AhunFgHB2xoTe3/ksb9GIUIZixVJWC6ub+DjYqmowsa6QdqFRl Tk= X-Received: by 2002:a05:6000:41ea:b0:43f:e934:50ac with SMTP id ffacd0b85a97d-46adb0b6259mr5708011f8f.7.1782226075087; Tue, 23 Jun 2026 07:47:55 -0700 (PDT) Received: from localhost (p200300f65f47db0493d7da2f3a2c0dc4.dip0.t-ipconnect.de. [2003:f6:5f47:db04:93d7:da2f:3a2c:dc4]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-466643f56aasm35516862f8f.6.2026.06.23.07.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 07:47:54 -0700 (PDT) Date: Tue, 23 Jun 2026 16:47:53 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Linus Torvalds Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Rob Herring , Saravana Kannan , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , Andi Shyti , Mark Brown Subject: Re: [PATCH] mod_devicetable.h: Split into per subsystem headers Message-ID: References: <20260622210733.1743063-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="abza5teqeooywdyh" Content-Disposition: inline In-Reply-To: --abza5teqeooywdyh Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] mod_devicetable.h: Split into per subsystem headers MIME-Version: 1.0 Hello Linus, On Mon, Jun 22, 2026 at 03:06:43PM -0700, Linus Torvalds wrote: > On Mon, 22 Jun 2026 at 14:07, Uwe Kleine-K=F6nig (The Capable Hub) > wrote: > > > > Maybe it's sensible to adapt the top-5 or so > > headers from the above list in the same go, as these will trigger quite > > some recompilation again!? >=20 > Oh, and on this side - I really think the "convert drivers / headers" > should be driven by some automated script. >=20 > Literally something that does the equivalent of >=20 > for i in include/linux/mod_device_id/*.h > do >=20 > # The new include line > line=3D$(echo $i | sed 's:include/\(.*\)$:#include <\1>:') >=20 > # get the struct name with grep/sed/whatever > struct_name=3D$(grep 'struct.*device_id.*{' $i | ...) >=20 > # find any users of it, insert new include > git grep -l "struct $struct_name" -- '*.c' | > xargs sed -i "/mod_devicetable.h/a $line" >=20 > done >=20 > and after that has script (and by "that script" I don't mean the > above, but some fixed and fleshed-out version that does something > similar) has added all the new includes after the existing > "mod_devicetable.h" include, a final script just removes the > mod_devicetable.h include lines entirely. I think it's ok to not include if is included. With that my current expectation is that there isn't much to do apart from identifying the files that rely on to pull in mod_devicetable.h providing ${something}_device_id. I wrote a script---I don't feel that old, so I picked Python :-)---that knows about these correlations and currently I have ~700 files left to check. So in the end I expect a handful of driver patches plus switching the the most important (or maybe all) s from to . I guess that is ok then, too? > That obviously implies that you should also do that "struct > cpu_feature" thing. My plan for that is to keep it in for now and then sort it out once linux/mod_devicetable.h has less impact on the whole tree. Best regards Uwe --abza5teqeooywdyh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmo6nJcACgkQj4D7WH0S /k7RYAf+LVRmVyg7afesVAyaWFCa8KdtIoS3IbrmbZjncl2NoQnzef/eMxen1JT6 T1YXClOHZH+wsXZjBvl6omEK9P2Dbwpam0+SWKzmGSH4aRBsljdnxpEBUcS9Q513 Iq6KxfiUP78Qotng/ZEffHRwML1/7kRkx430Cz3CW8XEa7Glvt6kDf8yEiOCdp3d qXSWLS/RDwcoN56qnLoXwIRNSZCY4hOcOLEUeQFbPoQldHTwzkBSgRadLx/nYGVv evbTyuLHXWrRXk+VX/dkZRIvWl3BufbkPHT7xYq4Ontt3VrnZnZwY2oyAhnnM34k 66/QxrkWBwO5Q7BSNrmppeLIiCt6Ig== =E8T6 -----END PGP SIGNATURE----- --abza5teqeooywdyh--