From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F1AF309EE2 for ; Tue, 23 Jun 2026 15:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782230306; cv=none; b=W9DBRMpBmKT1M3wRW/KBXT/smxPyT1ZM4yT1x88BgU3QplaJZTzlK0bG8yomLrQn/UgN58EjjtxfFe5yqbp0DaxNVZww6nwifBdLxO375NvtOPaJXFj4YumyvaCeTAA1ao4IPe8KAvLISnlJNXxeYfNrYLtd4EPKxXTb6xXgT9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782230306; c=relaxed/simple; bh=lt2zRXppnP/Q2hDcj7CLIt+PUwEh6Nzw2NOZYpFtCfM=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rHVai5EYyhhzihPg6DD+KQ1sJs/I63v75Vu28n/0xfqgasvcQWR3fTJmS1VkA6QpWWMbslzQx2oWZ3myIOHD2YlWawI6s7b1Msy+897688Ncr7kFsPmNZ8ojuI8i62eteaMt8oUTmuWbnzMstVuyCGzguO4Ehys44oSc0QM0ZoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Y4YggOMc; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Y4YggOMc" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-490ace40f4bso429325e9.3 for ; Tue, 23 Jun 2026 08:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782230304; x=1782835104; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=y86zbTGyWN+Yikjd9nlpvSjcfa1nNAH9BJsthd/rI0Y=; b=Y4YggOMcXhSHcUCD3v70RWusmspNyegU6puaMNpPQZ8g+AFdBNwxA/deW9ZR1X6Rmv S9pZ1Aj2XLEmlf51+EgdW9UJnBSbQq830xDXWLI3NRKodF3bdOFJU4FEkGoPksH15KwA 4GbZAtyE3G3FFDZ1I2PrnAu1K5neOihl8TnPLgyHgt/gwfDqqrr+ecoO7pXJL+dN6zCi EuGiW3MbD1yVq/tId7wL9L3SZccY8qxlEAJWzhxk5aOaMZ8B3jI2d0M0zNpYtfiaXbPP 7SlreFycxR44NgU3EyIzXD4dlzh7T0Yg1375Dychy9vw2rAoewMGvMzoHOpml/6rh/fk Sa8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782230304; x=1782835104; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y86zbTGyWN+Yikjd9nlpvSjcfa1nNAH9BJsthd/rI0Y=; b=LJS7SWj5MAgSmDS/BXNwQ0I2U+U6kyLOqmyjLfX3fv4rEFCGVWuNTxe5QAF5gUeXKF W8DE+tRydPLwewdXhQvdVeIyatozy7Gv2lRHfvUcHpsJrC/3ldFQweq/BZ3r1VKiwYFS S5CdE0qMGscoT4qKWp66zUtVqeVCOZz1IbJpigBjcvmG6j37Q+rIn0RVlbqxtBkHe4g/ 6XOl3W2srN8by2Fzbe42f+O10H6VNc7romAc+z2TkIUzRQSGfJywAJ+Ypuc9bOMV3sz6 uodezM21sagst55ycCdanmEX/qaNrkcvdqEjlaw3+nIk8rylF8+0CwIVaFcZmUPlxhwk xTEg== X-Forwarded-Encrypted: i=1; AFNElJ963UKybJZCIBUugPWKUbHHLcqTXu+1ypJBuQ/MjUd9JfmEIAvJY5hrbC1fEEPIRMMDLn4qBUsKKgFnv8c=@vger.kernel.org X-Gm-Message-State: AOJu0YydweruRKF5CrHwkUB4EMWc7oacd68yQ6nZxqhkanZ2a/Tw901U Ndl/IVWlVIBpLlVgCLE9BGRKrbQtXRJiGpBVd2XaYcBfkKtKhEkw6fOiOniGb1tRkj65jBY/07b zEYTTklk= X-Gm-Gg: AfdE7cmdfZI/hGSoJSS9ODWwvKkOZYQgTkJDRXTjyGStqZcT8/RxMk0m7Qs4FW6VMyB FxdsEht3VZo2Zotl0nJ02gKpFBbDl1UCON0zZh3J9r6RsYehzZNNy5G5WozDclmiEy//dbQRPAk EtQJKa2Qe9sgr2HHsCeW7vrVcgdS3oeJTgsbLCWSSUKmKeCH84jRRPmHJ50aw3OskWP2CK9K1Pk ue2Dxk2zNxLL91hWhxiGuvpjYIj4Ttqnu88WDXyLADsvdxwLPtGb3sHq6Udm+4610h4AqQOJUUC y45h3Hkeb4zCouQ8Vne2yupd7zcqgy8G2bpZdG8XQrlYNO5assGm0YtK2fyfGSdNbOohclIrBH/ rxC10H99PZ5HsesnhBEIG6weTwSJxGVHK/o38jE/5qsUybkCd6OzeL7sPOd5KMGo5je31Mlzjmp VtabhWOpJJag== X-Received: by 2002:a05:600c:8b37:b0:48a:906b:14ca with SMTP id 5b1f17b1804b1-4925b3b21d4mr49471845e9.20.1782230303856; Tue, 23 Jun 2026 08:58:23 -0700 (PDT) Received: from localhost ([195.94.150.2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49245a69f81sm367472255e9.1.2026.06.23.08.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 08:58:23 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 23 Jun 2026 18:01:47 +0200 To: Pengpeng Hou Cc: Andrea della Porta , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: rp1: clear chained IRQ handlers on teardown Message-ID: References: <20260616151028.69890-1-pengpeng@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260616151028.69890-1-pengpeng@iscas.ac.cn> Hi, On 23:10 Tue 16 Jun , Pengpeng Hou wrote: > rp1_probe() installs a chained handler for each parent MSI-X vector and > stores the rp1 device pointer as handler data. rp1_unregister_interrupts() > then disposes the child IRQ mappings, removes the IRQ domain, and frees > the PCI IRQ vectors without first removing those chained handlers. > > If a teardown path runs after the handlers have been installed, a later > parent IRQ can still call rp1_chained_handle_irq() with stale handler > data and a removed IRQ domain. Clear the chained handlers before > disposing mappings and freeing the vectors. > > Signed-off-by: Pengpeng Hou > --- > drivers/misc/rp1/rp1_pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/misc/rp1/rp1_pci.c b/drivers/misc/rp1/rp1_pci.c > index 81685e3f3296..a1f20d88be5d 100644 > --- a/drivers/misc/rp1/rp1_pci.c > +++ b/drivers/misc/rp1/rp1_pci.c > @@ -166,6 +166,9 @@ static void rp1_unregister_interrupts(struct pci_dev *pdev) > struct rp1_dev *rp1 = pci_get_drvdata(pdev); > int irq, i; > > + for (i = 0; i < RP1_INT_END; i++) > + irq_set_chained_handler_and_data(pci_irq_vector(pdev, i), NULL, NULL); > + > if (rp1->domain) { > for (i = 0; i < RP1_INT_END; i++) { > irq = irq_find_mapping(rp1->domain, i); > -- > 2.43.0 > Reviewed-by: Andrea della Porta