From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ian Rogers <irogers@google.com>,
James Clark <james.clark@linaro.org>,
Jiri Olsa <jolsa@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/1] perf bench bpf: Add missing .gitignore file
Date: Tue, 23 Jun 2026 17:27:38 -0700 [thread overview]
Message-ID: <ajskevFfXGkVt-si@google.com> (raw)
In-Reply-To: <ajsfSkRm0T7J2eF3@x1>
On Tue, Jun 23, 2026 at 09:05:30PM -0300, Arnaldo Carvalho de Melo wrote:
> Hi Linus,
>
> I'll have this in the next pull req if you prefer not to merge
> now,
>
> - Arnaldo
>
> ---
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> In 713eeb2279402758 ("perf build: Move BPF skeleton generation out of
> Makefile.perf") the bpf_skel used with 'perf bench uprobe' was moved
> from tools/perf/util/bpf_skel/ to tools/perf/bench/bpf_skel.
>
> Copy tools/perf/util/bpf_skel/.gitignore to that new directory so that
> files generated during build get ignored by git.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: James Clark <james.clark@linaro.org>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Fixes: 713eeb2279402758 ("perf build: Move BPF skeleton generation out of Makefile.perf")
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/bench/bpf_skel/.gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 tools/perf/bench/bpf_skel/.gitignore
>
> diff --git a/tools/perf/bench/bpf_skel/.gitignore b/tools/perf/bench/bpf_skel/.gitignore
> new file mode 100644
> index 0000000000000000..cd01455e1b53c3d9
> --- /dev/null
> +++ b/tools/perf/bench/bpf_skel/.gitignore
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +.tmp
> +*.skel.h
> +vmlinux.h
I think it's enough to add '*.skel.h' only as other files are still
under util/bpf_skel. But having others would not be harmful.
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
next prev parent reply other threads:[~2026-06-24 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 0:05 [PATCH 1/1] perf bench bpf: Add missing .gitignore file Arnaldo Carvalho de Melo
2026-06-24 0:27 ` Namhyung Kim [this message]
2026-06-24 0:32 ` Arnaldo Carvalho de Melo
2026-06-24 0:42 ` Linus Torvalds
2026-06-24 0:50 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajskevFfXGkVt-si@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.