From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andrei Kuchynski <akuchynski@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
Jameson Thies <jthies@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] usb: typec: Add helper to check cable altmode support
Date: Wed, 24 Jun 2026 13:57:56 +0300 [thread overview]
Message-ID: <aju4NGd84VRyvQer@kuha> (raw)
In-Reply-To: <CAMMMRMcAkhbyJ0F+a_C6QSmG5AxB3UpDPZt70sXoit8iQW3XOQ@mail.gmail.com>
On Tue, Jun 23, 2026 at 05:34:16PM +0200, Andrei Kuchynski wrote:
> if you are not against it
>
> On Tue, Jun 23, 2026 at 10:30 AM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > One day and I'm completely confused again :). I opened the code for
> > myself (not compiled) to get the idea again. Please consider that, or
> > something like it - the important part for me is the enum. The enum
> > does not cost that many lines, but it does make the idea more clear,
> > at least for me.
> >
>
> Thank you for such a detailed look.
> The code not only compiles, but it actually works as expected)
>
> > case IDH_PTYPE_PCABLE:
> > if (speed == CABLE_USB2_ONLY)
> > return CABLE_NOT_SUPPORTED;
> > break;
>
> With one change: `return CABLE_SUPPORTED;` instead of `break` here.
>
> So, the enum and the wrapper are in V3.
> If you don't mind, I'll add you to the "Co-Developers" list.
Okay, though I'm not sure that's necessary.
thanks,
--
heikki
next prev parent reply other threads:[~2026-06-24 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 9:39 [PATCH v2 0/3] Restrict alternate modes based on cable capabilities Andrei Kuchynski
2026-06-22 9:39 ` [PATCH v2 1/3] usb: typec: Add helper to check cable altmode support Andrei Kuchynski
2026-06-22 10:18 ` Heikki Krogerus
2026-06-22 12:03 ` Andrei Kuchynski
2026-06-23 8:30 ` Heikki Krogerus
2026-06-23 15:34 ` Andrei Kuchynski
2026-06-24 10:57 ` Heikki Krogerus [this message]
2026-06-22 9:39 ` [PATCH v2 2/3] usb: typec: thunderbolt: Check " Andrei Kuchynski
2026-06-22 9:39 ` [PATCH v2 3/3] usb: typec: displayport: " Andrei Kuchynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aju4NGd84VRyvQer@kuha \
--to=heikki.krogerus@linux.intel.com \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.