All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Linisha <linisha232@gmail.com>
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org,
	peter.maydell@linaro.org, pbonzini@redhat.com, mjt@tls.msk.ru,
	philmd@mailo.com
Subject: Re: [PATCH] docs/system: clarify pflash0 and pflash1 are virt-only options
Date: Wed, 24 Jun 2026 08:15:21 +0100	[thread overview]
Message-ID: <ajuD4L_ZDEg8TI2R@redhat.com> (raw)
In-Reply-To: <20260623205839.1294-1-linisha232@gmail.com>

On Wed, Jun 24, 2026 at 02:28:39AM +0530, Linisha wrote:
> The pflash0 and pflash1 machine options shown in the Aarch64 virt example are only available for virt machine types on Arm, RISC-V, and LoongArch architectures. Add a note to clarify this for users who may try these options on x86 machines and be confused when they are not available.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3254
> Signed-off-by: Linisha <linisha232@gmail.com>
> ---
>  docs/system/introduction.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/docs/system/introduction.rst b/docs/system/introduction.rst
> index bec7291e47..0c400aefb6 100644
> --- a/docs/system/introduction.rst
> +++ b/docs/system/introduction.rst
> @@ -158,6 +158,12 @@ virtualisation so we can use KVM inside the emulated guest. As the
>  ``virt`` machine comes with some built in pflash devices we give them
>  names so we can override the defaults later.
>  
> +.. note::
> +   The ``pflash0`` and ``pflash1`` machine options are specific to the
> +   ``virt`` machine type on Arm, RISC-V, and LoongArch architectures.
> +   They are not available on x86 machines, which use ``-bios`` or
> +   ``-pflash`` for firmware instead.

No this is wrong.

The pflash0 and pflash1 properties apply to x86 pc & q35 machines too.

-pflash is a legacy syntax which remaps to pflash0 and pflash1 internally,
but also applies to other machines which don't use the new pflash0/pflash1
properties.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  reply	other threads:[~2026-06-24  7:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 20:58 [PATCH] docs/system: clarify pflash0 and pflash1 are virt-only options Linisha
2026-06-24  7:15 ` Daniel P. Berrangé [this message]
2026-06-24  8:47   ` Peter Maydell
2026-06-24  9:21     ` linisha
2026-06-24 10:28     ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajuD4L_ZDEg8TI2R@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=linisha232@gmail.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@mailo.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.