From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585DB2D5412 for ; Wed, 24 Jun 2026 09:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782292989; cv=none; b=U+TUa6YEtXntZw5v3HQGWWH0cL2L2yg9Kyb9L1q6V52TSoP/i60S9+jn5KBa2kV0vFJdva7YKLfC4hTdRYpWtsG74+NkV8Vb6vbjc+R/EH498aw6aqnuieCmUej/AuUH9c6YrVftfpmCyvvo7GpS+3K6YKQ2H8NHzwiPz0xGtCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782292989; c=relaxed/simple; bh=ER0Ha8/W/1ogI3UhR2iFbBaUkIegTlSxqgNA1aKKQ+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fnl5MZFQo/lNOpjOxwTlIzjc9Plbx0S6wYq8HgKAj4gGRzy4gVr4O4K3zQVScjqQlw9RfOvIwntqHxuJrLiufmG7gVOe480u9h/Qvyc8RlidGBE36zESTzC5PzP+aLYvgX2aIQCpdY5YaMugOJNYlq8YDX/mhIUqYvkMvFmzPXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XVtWEvxQ; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XVtWEvxQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782292986; x=1813828986; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ER0Ha8/W/1ogI3UhR2iFbBaUkIegTlSxqgNA1aKKQ+Q=; b=XVtWEvxQIhFeSv7pjYFWwkB6OMDfK18TROn9pKzHsJaf+MW1U3YSI7x5 xHJ6nhR0NsJiDCy0BZNVlD+nuTLtivWp4gjE0mm/b13TJigafujliuMyi z883c6Q2btEF/lJrRC7Hw/EDfFPqZ2IT5nUDegUEn+lsvEDvfR3D7sSLg rHVMrMgKryVbpWmljwqmGXjSGrINqliZVnXMZ6WZS6z7ZuS/8n03fnc4m cMT3+a9iOwwImibNeg981XD9C/79wLWZ0QgFBXcZasFNmzOdPfUFRl9nB k61ZAdno6yh4FvtBxASPwINEhxnaf6IzwWbS5jk41xND7Uj4raYVzJ4My g==; X-CSE-ConnectionGUID: 9co++ocnRzKjhZpU4tms7g== X-CSE-MsgGUID: SeChqugIRUee+7KvnTf7ow== X-IronPort-AV: E=McAfee;i="6800,10657,11826"; a="100473634" X-IronPort-AV: E=Sophos;i="6.24,222,1774335600"; d="scan'208";a="100473634" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2026 02:23:05 -0700 X-CSE-ConnectionGUID: BxUn7xoeRPSQeDtkX+eq4g== X-CSE-MsgGUID: TayrNkd3RB6Ru63uwUvdAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,222,1774335600"; d="scan'208";a="254762946" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa005.jf.intel.com with ESMTP; 24 Jun 2026 02:23:03 -0700 Received: by black.igk.intel.com (Postfix, from userid 1008) id E525295; Wed, 24 Jun 2026 11:23:01 +0200 (CEST) Date: Wed, 24 Jun 2026 12:23:00 +0300 From: Heikki Krogerus To: Raag Jadav Cc: Rodrigo Vivi , Matthew Brost , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , "Michael J . Ruhl" , Andy Shevchenko , Mika Westerberg , Riana Tauro , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] drm/xe/i2c: Handler for SMBus Alerts Message-ID: References: <20260622114759.3464047-1-heikki.krogerus@linux.intel.com> <20260622114759.3464047-2-heikki.krogerus@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 23, 2026 at 04:34:06PM +0200, Raag Jadav wrote: > On Mon, Jun 22, 2026 at 01:47:58PM +0200, Heikki Krogerus wrote: > > Some devices that are attached to the I2C controller use the > > SMBus Alert signal for example to inform the host about > > thermal events, so registering the default SMBus Alert > > device device for them. The alert device makes sure that > > Nit: Duplicate 'device' ;) > > > the alert is processed and passed to the correct I2C client > > driver. > > ... > > > @@ -182,7 +183,10 @@ void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl) > > return; > > > > /* Forward interrupt to I2C adapter */ > > - generic_handle_irq_safe(xe->i2c->adapter_irq); > > + if (xe->i2c->smbus_alert) > > + xe_i2c_handle_smbus_alert(xe->i2c); > > + else > > + generic_handle_irq_safe(xe->i2c->adapter_irq); > > This looks like the else case will never hit since no other platform > supports irq. Is it on the cards at some point or can we make it obsolete? I'm not sure yet. Right now it looks like there could be need for it later, but I'm just not sure. Let's keep it for now. thanks, -- heikki