From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Raag Jadav" <raag.jadav@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Michael J . Ruhl" <michael.j.ruhl@intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Riana Tauro" <riana.tauro@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/xe/mcu_i2c: Take over control of the controller enabling
Date: Wed, 24 Jun 2026 12:27:10 +0300 [thread overview]
Message-ID: <ajui7vNvhzJSNu9C@kuha> (raw)
In-Reply-To: <ajrL_5cPDIlXcfXP@ashevche-desk.local>
On Tue, Jun 23, 2026 at 09:10:07PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 23, 2026 at 04:58:39PM +0200, Raag Jadav wrote:
> > On Tue, Jun 23, 2026 at 01:56:53PM +0300, Andy Shevchenko wrote:
> > > On Mon, Jun 22, 2026 at 01:47:59PM +0200, Heikki Krogerus wrote:
>
> ...
>
> > > > +#define IC_CON 0x00
> > > > +#define IC_TAR 0x04
> > > > +#define IC_SAR 0x08
> > > > +#define IC_ENABLE 0x6c
> > > > +#define IC_ENABLE_STATUS 0x9c
> > >
> > > Heh, I would like to have a shared header with the registers, but dunno
> > > if the prons will weight out the cons.
> >
> > Perhaps something like i2c-algo-pca.h?
>
> It's different. It's more device specific header and it doesn't look like
> a platform data. For SPI PXA2xx we have them in pxa2xx_ssp.h. And we have
> some device specific i2c headers, seems like the pattern is
> *_i2c.h, exempli gratia, designware_i2c.h.
Okay, I'll add a patch the series where I'll move the register
definitions to include/linux/designware_i2c.h
Cheers,
--
heikki
next prev parent reply other threads:[~2026-06-24 9:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 11:47 [PATCH v1 0/2] drm/xe/i2c: alerts and controller enabling modifications Heikki Krogerus
2026-06-22 11:47 ` [PATCH v1 1/2] drm/xe/i2c: Handler for SMBus Alerts Heikki Krogerus
2026-06-22 12:04 ` sashiko-bot
2026-06-23 10:54 ` Andy Shevchenko
2026-06-23 11:44 ` Heikki Krogerus
2026-06-23 14:34 ` Raag Jadav
2026-06-24 9:23 ` Heikki Krogerus
2026-06-22 11:47 ` [PATCH v1 2/2] drm/xe/mcu_i2c: Take over control of the controller enabling Heikki Krogerus
2026-06-22 12:04 ` sashiko-bot
2026-06-23 10:56 ` Andy Shevchenko
2026-06-23 14:58 ` Raag Jadav
2026-06-23 18:10 ` Andy Shevchenko
2026-06-24 9:27 ` Heikki Krogerus [this message]
2026-06-23 14:39 ` Raag Jadav
2026-06-24 10:13 ` Heikki Krogerus
2026-06-24 11:14 ` Raag Jadav
2026-06-24 11:28 ` Heikki Krogerus
2026-06-22 16:34 ` ✗ CI.checkpatch: warning for drm/xe/i2c: alerts and controller enabling modifications Patchwork
2026-06-22 16:35 ` ✓ CI.KUnit: success " Patchwork
2026-06-22 17:36 ` ✓ Xe.CI.BAT: " Patchwork
2026-06-22 20:38 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-06-23 10:15 ` [PATCH v1 0/2] " Heikki Krogerus
2026-06-23 14:40 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajui7vNvhzJSNu9C@kuha \
--to=heikki.krogerus@linux.intel.com \
--cc=airlied@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=michael.j.ruhl@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.