From: Dan Carpenter <error27@gmail.com>
To: Aditya Tipre <tipreaditya@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove else after return in enqueue_reorder_recvframe
Date: Thu, 9 Jul 2026 14:22:09 +0300 [thread overview]
Message-ID: <ak-EYb0-7UlD2Twc@stanley.mountain> (raw)
In-Reply-To: <20260709040419.216324-1-tipreaditya@gmail.com>
On Thu, Jul 09, 2026 at 12:03:48AM -0400, Aditya Tipre wrote:
> The duplicate-frame path returns immediately, so the following else is
> unnecessary.
What? Also no. It's necessary. Checkpatch is just a simple perl script.
Use this as an opportunity to learn to be critical of your tools. ;)
regards,
dan carpenter
prev parent reply other threads:[~2026-07-09 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 4:03 [PATCH] staging: rtl8723bs: remove else after return in enqueue_reorder_recvframe Aditya Tipre
2026-07-09 11:22 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak-EYb0-7UlD2Twc@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tipreaditya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.