Re: [PATCH v7 1/1] drm/xe/xe_ras: Add RAS GPU health indicator

[Raag Jadav <raag.jadav@intel.com>]

On Wed, Jul 08, 2026 at 11:42:23AM +0530, Soham Purkait wrote:
> Add a sysfs interface that reports the current GPU health state and
> lets admin users and management tools update it but is readable by all
> users. Requests are routed through the sysctrl mailbox. The interface
> is present only on platforms that support the GPU health indicator.
> 
> The interface is a single read/write file at the device level:
> 
>   $ cat /sys/.../device/gpu_health
>   ok
> 
>   $ echo critical > /sys/.../device/gpu_health
> 
>   $ cat /sys/.../device/gpu_health
>   critical

...

> index 000000000000..9612b97b0f88
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-driver-intel-xe-ras
> @@ -0,0 +1,30 @@
> +What:		/sys/bus/pci/drivers/xe/.../gpu_health
> +Date:		April 2026
> +KernelVersion:	7.2

Unless there's time travel involved here that I'm not familiar with, we
should consider using correct[1] date and version.

[1] https://jnikula.github.io/linux-kernel-tea-leaves/

...

> +/**
> + * DOC: GPU Health Indicator
> + *
> + * On Intel Xe platforms that support the GPU health indicator interface,
> + * the driver exposes a sysfs attribute at the device level as:
> + *
> + *	``/sys/bus/pci/drivers/xe/<BDF>/gpu_health``

The attribute is already under device <BFD>, so I'm really unsure of "gpu"
is needed here. IMO it can simply be 'health' but I'll leave it to you all.

> + * Reading the attribute returns a single line containing the current GPU
> + * health state. Writing one of the valid values updates the same. Reads
> + * are available to all users; writes are restricted to administrative
> + * users only (attribute permissions ``0644``).

Why is it readable for all users? Is there such a requirement?

Raag