From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Lee Jones <lee@kernel.org>,
James Ogletree <jogletre@opensource.cirrus.com>,
Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
Support Opensource <support.opensource@diasemi.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Tony Lindgren <tony@atomide.com>,
mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 20/23] mfd: Unify style of i2c_device_id arrays
Date: Wed, 8 Jul 2026 13:15:32 +0100 [thread overview]
Message-ID: <ak4/ZDSvc4bz/Lg9@opensource.cirrus.com> (raw)
In-Reply-To: <9c8fe48a1f971d75191c636f2b6d3ef1c68a26e2.1783507945.git.u.kleine-koenig@baylibre.com>
On Wed, Jul 08, 2026 at 01:15:27PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Most of these arrays already mostly match the most used and
> generally recommended coding style. That is:
>
> - no comma after the list terminator;
> - a comma after an initializer if (and only if) the closing } is not
> directly following;
> - no explicit zeros in the list terminator;
> - a space after an opening { and before a closing }, a single space in
> the list terminator;
>
> Adapt the few offenders accordingly and also use tabs for indention for
> two drivers.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> drivers/mfd/cs40l50-i2c.c | 2 +-
> drivers/mfd/wm8400-core.c | 4 ++--
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2026-07-08 12:15 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 11:15 [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 01/23] mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locally Uwe Kleine-König (The Capable Hub)
2026-07-10 10:20 ` Stanimir Varbanov
2026-07-08 11:15 ` [PATCH v2 02/23] mfd: bcm2835-pm: Drop unused header Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 03/23] mfd: kempld: Simplify device abstraction Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 04/23] mfd: lp87565: Explicitly set driver data for the generic dt compatible Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 05/23] mfd: mt6360: Drop irrelevant __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 06/23] mfd: rt4831: " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 07/23] mfd: loongson-se: Drop unused assignment of acpi_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 08/23] mfd: Drop unused assignment of i2c_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 09/23] mfd: Drop unused assignment of platform_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 10/23] mfd: Drop unused assignment of spi_device_id " Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 11/23] mfd: Use named initializers for acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:07 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 12/23] mfd: intel-m10-bmc-pmci: Use named initializers for dfl_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 11:24 ` sashiko-bot
2026-07-08 12:12 ` Charles Keepax
2026-07-08 12:55 ` André Draszik
2026-07-08 11:15 ` [PATCH v2 14/23] mfd: twl6030: Use named initializers for of_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 15/23] mfd: Use PCI_DEVICE* macros to initialize pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 16/23] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-09 19:35 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 17/23] mfd: Use named initializers for arrays of spi_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:14 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 18/23] mfd: Unify style of acpi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:20 ` Andy Shevchenko
2026-07-08 12:14 ` Charles Keepax
2026-07-08 11:15 ` [PATCH v2 19/23] mfd: Unify style of dmi_system_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 20/23] mfd: Unify style of i2c_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:15 ` Charles Keepax [this message]
2026-07-08 11:15 ` [PATCH v2 21/23] mfd: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` Uwe Kleine-König (The Capable Hub)
2026-07-08 11:32 ` sashiko-bot
2026-07-08 11:32 ` sashiko-bot
2026-07-08 12:18 ` Charles Keepax
2026-07-08 12:18 ` Charles Keepax
2026-07-08 12:58 ` André Draszik
2026-07-08 12:58 ` André Draszik
2026-07-10 19:36 ` Linus Walleij
2026-07-10 19:36 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 22/23] mfd: Unify style of pci_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 23/23] mfd: Unify style of spi_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:19 ` Charles Keepax
2026-07-08 11:34 ` [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Andy Shevchenko
2026-07-08 11:34 ` Andy Shevchenko
2026-07-09 16:08 ` Uwe Kleine-König (The Capable Hub)
2026-07-09 16:08 ` Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak4/ZDSvc4bz/Lg9@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=ben.bright@cirrus.com \
--cc=cw00.choi@samsung.com \
--cc=fred.treven@cirrus.com \
--cc=jogletre@opensource.cirrus.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=patches@opensource.cirrus.com \
--cc=rogerq@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.