From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Cc: qemu-devel@nongnu.org, mark.cave-ayland@ilande.co.uk,
richard.henderson@linaro.org,
"Alex Bennée" <alex.bennee@linaro.org>,
mjt@tls.msk.ru
Subject: Re: [PATCH 1/4] tests/lcitool/refresh: use raw string literal for trailers
Date: Wed, 8 Jul 2026 09:13:14 +0100 [thread overview]
Message-ID: <ak4Gmp15YT0x4lSZ@redhat.com> (raw)
In-Reply-To: <20260707214655.1138626-2-pierrick.bouvier@oss.qualcomm.com>
On Tue, Jul 07, 2026 at 02:46:52PM -0700, Pierrick Bouvier wrote:
> Using a list of string is not convenient, as users need to escape it
> manually and handle end of lines. By using a raw string literal,
> what you see is what you get.
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
> ---
> tests/lcitool/refresh | 209 +++++++++++++++++++++---------------------
> 1 file changed, 105 insertions(+), 104 deletions(-)
Does what it says on the tin so....
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
...but given the size of the trailer we have inline, I wonder if we
would be better off just having that trailer in a plain text file
alongside the refresh script, such that 'refresh' just auto-appends
any <foo>.trailer file contents to any docker file it emits called
"<foo>".
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-07-08 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 21:46 [PATCH 0/4] tests/docker/dockerfiles: add missing apt update Pierrick Bouvier
2026-07-07 21:46 ` [PATCH 1/4] tests/lcitool/refresh: use raw string literal for trailers Pierrick Bouvier
2026-07-08 8:13 ` Daniel P. Berrangé [this message]
2026-07-08 15:56 ` Pierrick Bouvier
2026-07-07 21:46 ` [PATCH 2/4] tests/docker/dockerfiles/ubuntu2404.docker: add missing apt update Pierrick Bouvier
2026-07-08 8:19 ` Daniel P. Berrangé
2026-07-08 9:27 ` Michael Tokarev
2026-07-08 14:28 ` Philippe Mathieu-Daudé
2026-07-08 14:54 ` Michael Tokarev
2026-07-08 16:11 ` Pierrick Bouvier
2026-07-08 16:14 ` Pierrick Bouvier
2026-07-08 16:38 ` Pierrick Bouvier
2026-07-08 20:46 ` Philippe Mathieu-Daudé
2026-07-07 21:46 ` [PATCH 3/4] tests/docker/dockerfiles/debian.docker: " Pierrick Bouvier
2026-07-08 8:25 ` Daniel P. Berrangé
2026-07-07 21:46 ` [PATCH 4/4] tests/docker/dockerfiles/debian-all-test-cross.docker: " Pierrick Bouvier
2026-07-08 8:50 ` Daniel P. Berrangé
2026-07-10 5:13 ` [PATCH 0/4] tests/docker/dockerfiles: " Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak4Gmp15YT0x4lSZ@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mjt@tls.msk.ru \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.