From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAF73C44501 for ; Wed, 8 Jul 2026 08:25:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1whNbC-00057Q-IB; Wed, 08 Jul 2026 04:25:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1whNbA-000574-Pm for qemu-devel@nongnu.org; Wed, 08 Jul 2026 04:25:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1whNb8-0006CY-PZ for qemu-devel@nongnu.org; Wed, 08 Jul 2026 04:25:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783499136; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jx7usGiqP3ES6Rm8p4Eyrp5tkOeI+mwzssFKFY86LYw=; b=J+bpHfPia8thJ5G7hwzHimOGnpbue0qAQFvFG+bidjdTrs3629ImjXYp0BaRRfPfSHVA4Z 36BqzV/gf9Q55vybn7IdGMKvfMIxH+k17frhORQyyLGVC9sXcRjWF8ZVKVwDQddFOSB7kr vHWDm6HIP9r/iSekP8PudBfz+U22Bek= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-G94qwGu6M0uX3923wwuTvw-1; Wed, 08 Jul 2026 04:25:25 -0400 X-MC-Unique: G94qwGu6M0uX3923wwuTvw-1 X-Mimecast-MFC-AGG-ID: G94qwGu6M0uX3923wwuTvw_1783499114 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 64AF818002C1; Wed, 8 Jul 2026 08:25:14 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.28]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED79C1956056; Wed, 8 Jul 2026 08:25:11 +0000 (UTC) Date: Wed, 8 Jul 2026 09:25:08 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, mark.cave-ayland@ilande.co.uk, richard.henderson@linaro.org, Alex =?utf-8?Q?Benn=C3=A9e?= , mjt@tls.msk.ru Subject: Re: [PATCH 3/4] tests/docker/dockerfiles/debian.docker: add missing apt update Message-ID: References: <20260707214655.1138626-1-pierrick.bouvier@oss.qualcomm.com> <20260707214655.1138626-4-pierrick.bouvier@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260707214655.1138626-4-pierrick.bouvier@oss.qualcomm.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jul 07, 2026 at 02:46:54PM -0700, Pierrick Bouvier wrote: > RUN statements should always use apt update && apt install together: > https://docs.docker.com/build/building/best-practices/#apt-get > > Signed-off-by: Pierrick Bouvier > --- > tests/docker/dockerfiles/debian.docker | 3 ++- > tests/lcitool/refresh | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|