All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Carlos Grillet <carlos@carlosgrillet.me>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Phil Sutter <phil@nwl.cc>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 0/4] netfilter: replace u_int*_t with kernel int types (batch 3)
Date: Wed, 8 Jul 2026 16:56:31 +0200	[thread overview]
Message-ID: <ak5lH1UnFth6oreP@strlen.de> (raw)
In-Reply-To: <20260707195111.34899-1-carlos@carlosgrillet.me>

Carlos Grillet <carlos@carlosgrillet.me> wrote:
> This patch series replaces POSIX u_int8_t/u_int16_t/u_int32_t with the
> preferred kernel types u8/u16/u32 across several netfilter files and
> updates the corresponding header definition.
> 
> This continues the work started in:
> https://lore.kernel.org/all/20260616182948.96865-1-carlos@carlosgrillet.me
> 
> No functional changes.
> 
> Carlos Grillet (4):
>   netfilter: ip_vs_core: replace u_int32_t with u32

This one is fine, its the only occurence.

>   netfilter: nf_conntrack_sip: replace u_int16_t with u16

No need to send a v2, I "fixed" this locally, but this
could have been
'netfilter: nf_conntrack: replace u_int16_t with u16'

 nf_conntrack_core.c    |    4 ++--
 nf_conntrack_irc.c     |    4 ++--
 nf_conntrack_netlink.c |    6 +++---
 nf_conntrack_pptp.c    |    8 ++++----
 nf_conntrack_sip.c     |    2 +-
 5 files changed, 12 insertions(+), 12 deletions(-)

>   netfilter: nf_nat_amanda: replace u_int16_t with u16
>   netfilter: nfnetlink_osf: replace u_int8_t with u8

I'm not applying these two.  Please find a way to make
larger logical changesets.

These one-lines are just extra churn.
E.g. make one patch for nf_nat.

Or address all of u8/18/u32 in same change.

      parent reply	other threads:[~2026-07-08 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 19:51 [PATCH nf-next 0/4] netfilter: replace u_int*_t with kernel int types (batch 3) Carlos Grillet
2026-07-07 19:51 ` [PATCH nf-next 1/4] netfilter: ip_vs_core: replace u_int32_t with u32 Carlos Grillet
2026-07-07 19:51 ` [PATCH nf-next 2/4] netfilter: nf_conntrack_sip: replace u_int16_t with u16 Carlos Grillet
2026-07-07 19:51 ` [PATCH nf-next 3/4] netfilter: nf_nat_amanda: " Carlos Grillet
2026-07-07 19:51 ` [PATCH nf-next 4/4] netfilter: nfnetlink_osf: replace u_int8_t with u8 Carlos Grillet
2026-07-08 14:56 ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ak5lH1UnFth6oreP@strlen.de \
    --to=fw@strlen.de \
    --cc=carlos@carlosgrillet.me \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.