From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C37CC43458 for ; Wed, 8 Jul 2026 15:09:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1whTtZ-0002Q1-MT; Wed, 08 Jul 2026 11:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1whTtX-0002Ml-PL for qemu-devel@nongnu.org; Wed, 08 Jul 2026 11:09:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1whTtV-0004fo-9a for qemu-devel@nongnu.org; Wed, 08 Jul 2026 11:09:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783523340; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=90eErB3YsYYPPI2uFajiveRQNuiwyUTM0X3Ml1l4pkc=; b=HFLNiuGOWgy3PcJ6sCu7/0bkJlbcTiXkTuN6lix6e1uECX2VxycXzIlhfHoBtijsPVjhvP r96PxivOjZVNt8tP6Xj4d/Zd1s7avEGrT69pjCiDf0S/w7kDv63a/cW2Bb+9yo3i2gckpK znqg9Zud7DXYajOdQTIlKCyTMincJKo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-CKWD-KMNMwe-jZ9Qf7wNtQ-1; Wed, 08 Jul 2026 11:08:58 -0400 X-MC-Unique: CKWD-KMNMwe-jZ9Qf7wNtQ-1 X-Mimecast-MFC-AGG-ID: CKWD-KMNMwe-jZ9Qf7wNtQ_1783523337 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 74BD21956069 for ; Wed, 8 Jul 2026 15:08:57 +0000 (UTC) Received: from redhat.com (unknown [10.44.49.28]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0D9CF1800370; Wed, 8 Jul 2026 15:08:55 +0000 (UTC) Date: Wed, 8 Jul 2026 16:08:52 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, pbonzini@redhat.com Subject: Re: [PATCH] qom: Fix device-list-properties & friends to show legacy-FOO props Message-ID: References: <20260708140948.2622814-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260708140948.2622814-1-armbru@redhat.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Jul 08, 2026 at 04:09:48PM +0200, Markus Armbruster wrote: > qmp_device_list_properties() skips properties whose name starts with > "legacy-". This is a flawed test for "is a legacy property". > > The test is flawed because non-legacy properties can and do start with > "legacy-". Back when it was added, no such properties existed. Right > now, three such properties do: property "legacy-cmb" of device "nvme", > and properties "legacy-cache" and "legacy-multi-node" of devices > "x86_64-cpu", "i386-cpu", and its children. > > This affects QMP command "device-list-properties", HMP command > "device_add T,help", and command line option "-device T,help". > > Legacy properties are gone since commit a61383f7ab (qdev: Legacy > properties are now unused internally, drop, 2025-10-22). This makes > the fix easy: delete the code that skips them. > > Reproducer: -device nvme,help doesn't show legacy-cmb before the > patch, and does after. > > Fixes: f4eb32b590 (qmp: show QOM properties in device-list-properties, 2014-05-20) > Signed-off-by: Markus Armbruster > --- > qom/qom-qmp-cmds.c | 7 ------- > 1 file changed, 7 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|