Re: [PATCH v4 2/3] iommu/arm-smmu-v3: Detect Tegra264 erratum

[Nicolin Chen <nicolinc@nvidia.com>]

On Tue, Jun 09, 2026 at 07:32:03AM +0000, Ashish Mhetre wrote:
> @@ -5303,8 +5305,11 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev,
>  	if (of_dma_is_coherent(dev->of_node))
>  		smmu->features |= ARM_SMMU_FEAT_COHERENCY;
>  
> -	if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu"))
> +	if (of_device_is_compatible(dev->of_node, "nvidia,tegra264-smmu")) {
>  		tegra_cmdqv_dt_probe(dev->of_node, smmu);
> +		smmu->options |= ARM_SMMU_OPT_REPEAT_TLBI_CFGI;
> +		static_branch_enable(&arm_smmu_erratum_repeat_tlbi_cfgi_key);
> +	}

This would be nicer to be the last part of the series. Since we
need a respin, I would change the order a bit:

patch-1 factor a helper for force_sync
patch-2 define a static key and its WAR functions
patch-3 detect per compatible string and set the key

Nicolin