From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 893C7273D9F; Sat, 27 Jun 2026 21:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782596748; cv=none; b=MCmDYAJLbh30UUvPFVFIY02DblfmG1hlw3G9DYrBDPJa+hTG+Q202RFuD8CeWGLr5zYiuPFQEAWaY+8KvLgXXsCKxrlFjdql2RJKXuUVNY78TYk8sfYm7IA0uUkiT6Jmer/ozZXJ3GxZl81PON+5VHwHsD/vvYr019i07j/nJVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782596748; c=relaxed/simple; bh=oCfQpjZ269Bt9n6+wLPESthTEOvQtXcyGv20NZ2euOY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mYxkX14HIDRFVTohroY/2+yuWm7tdk/8B1ihlzHwtBQ39+aw3rUK4pAOdsTOtRjX4PlgQOCmEf9M+tDACncAS4ARKAy+O8WUeAiruNTa8gJDCVXMQGpLXttg/HbafKD2pJFRoWe0ZP4ym3fYljo8whplo9Rpgjyt/sSMDnyLFbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TWJCahDr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TWJCahDr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A85D81F000E9; Sat, 27 Jun 2026 21:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782596747; bh=hbIDoQbCyu+48Gjf06/wa5e+SiS3vEWCbdZXylWTfw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TWJCahDrcCyZy6Ld4YajnQr3ObTtrwXv54paCbdwkHGVoiL986RIWLDH3z5A2gHA/ hw22lHVKi9Rm9qVdXq+5M+PnAUifHeIAulwJoFYi3ccYKngRY4O3kEUs0UOiOrLFgw 3oROqrZoW5tCqxyVDYSk8mTkuQRWaHhyb0MUl8vhswZCL5Ls4TObx9KMCM85+7aDzJ PWCt9DWc59aswLUNEbb8McPmIAcaJzrl1ASwByufNk+t78YaGF9Ye6/HSAhsLqtAzq hYlM76Bey3YSGFAaNjftYugXBDGQ3XvHnt1ACu+feeKxeaqQlv3pZN5kbMgH0ya5lG 8FK8PrhKO302g== Date: Sat, 27 Jun 2026 14:45:45 -0700 From: Drew Fustini To: yunhui cui Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [External] [PATCH v2 4/8] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20260624-dfustini-atl-sc-cbqri-dt-v2-0-2f8049fd902b@kernel.org> <20260624-dfustini-atl-sc-cbqri-dt-v2-4-2f8049fd902b@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jun 27, 2026 at 05:19:44PM +0800, yunhui cui wrote: > Hi Drew, > > On Thu, Jun 25, 2026 at 9:41 AM Drew Fustini wrote: > > > > Add support for the RISC-V CBQRI capacity controller. A platform driver > > passes a cbqri_controller_info descriptor together with the cache level > > to riscv_cbqri_register_cc_dt(), which probes the controller and adds it > > to the controller list. > > > > Assisted-by: Claude:claude-opus-4-7 > > Co-developed-by: Adrien Ricciardi > > Signed-off-by: Adrien Ricciardi > > Signed-off-by: Drew Fustini > > --- > > MAINTAINERS | 3 + > > drivers/resctrl/Kconfig | 13 + > > drivers/resctrl/Makefile | 3 + > > drivers/resctrl/cbqri_devices.c | 520 +++++++++++++++++++++++++++++++++++++++ > > drivers/resctrl/cbqri_internal.h | 107 ++++++++ > > include/linux/riscv_cbqri.h | 47 ++++ > > 6 files changed, 693 insertions(+) [..] > > +int cbqri_apply_cache_config(struct cbqri_controller *ctrl, u32 closid, > > + const struct cbqri_cc_config *cfg) > > +{ [..] > > + > > + /* Set capacity block mask (cc_block_mask) */ > > + cbqri_set_cbm(ctrl, cfg->cbm); > > + > > + /* Capacity config limit operation for the AT half implied by cfg->at */ > > + err = cbqri_cc_alloc_op(ctrl, CBQRI_CC_ALLOC_CTL_OP_CONFIG_LIMIT, > > + closid, cfg->at); > > + if (err < 0) > > + goto out; > > When CUNITS=1, CONFIG_LIMIT also consumes cc_cunits. If resctrl does not > expose unit limits, the driver should still write cc_cunits=0 before > CONFIG_LIMIT to avoid a hidden stale/implementation-defined unit limit. > > Should we handle cc_cunits here? That is a good that cc_units should be handled even though we can't yet expose it to resctrl. I will change the code to set cc_cunits to 0 before a config limit operation on controllers that support capacity units, so a stale unit limit does not constrain block-mask allocation. Thanks, Drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D341C43458 for ; Sat, 27 Jun 2026 21:46:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sJRM8hKf9CGk2/eyHrxgs6i5BWfpW0CTc1oaDo9IjFI=; b=NDwh2nsbiESNOh XMxo99/Xb4+11mOrwdPOS+20J0bdIh8LFaocJyJG6I0bi4sGn3259k1UUbRYjYLYBKTj2MNZfT4GY uBPq9P8v9NXViVYiKOGQvc/Uy+GVsxGHeR9iDvKAN3Qy9kb4DDuOImn2uIk0bsW6YlWvySgpEOH5q J29b6JeLM4TTNCHb4JO8SgTtpkfL8Ix9pqKkUSZAgk6g+MMmO9ffbyzAIM/kTGmmmi7gEhr/4JyCz 1csqRX4a7p+8q1HTTzqQSQe4rSVe7t3p8WTg3x6lcXiAVekyqDDug1UobxFJgPA3SdKZqKuPS38SE ZmBoUuRZVk1cnYNkBydg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wdaqV-0000000CmJp-0aNX; Sat, 27 Jun 2026 21:45:51 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wdaqS-0000000CmJd-1mlm for linux-riscv@lists.infradead.org; Sat, 27 Jun 2026 21:45:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5BDF441E52; Sat, 27 Jun 2026 21:45:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A85D81F000E9; Sat, 27 Jun 2026 21:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782596747; bh=hbIDoQbCyu+48Gjf06/wa5e+SiS3vEWCbdZXylWTfw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TWJCahDrcCyZy6Ld4YajnQr3ObTtrwXv54paCbdwkHGVoiL986RIWLDH3z5A2gHA/ hw22lHVKi9Rm9qVdXq+5M+PnAUifHeIAulwJoFYi3ccYKngRY4O3kEUs0UOiOrLFgw 3oROqrZoW5tCqxyVDYSk8mTkuQRWaHhyb0MUl8vhswZCL5Ls4TObx9KMCM85+7aDzJ PWCt9DWc59aswLUNEbb8McPmIAcaJzrl1ASwByufNk+t78YaGF9Ye6/HSAhsLqtAzq hYlM76Bey3YSGFAaNjftYugXBDGQ3XvHnt1ACu+feeKxeaqQlv3pZN5kbMgH0ya5lG 8FK8PrhKO302g== Date: Sat, 27 Jun 2026 14:45:45 -0700 From: Drew Fustini To: yunhui cui Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [External] [PATCH v2 4/8] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20260624-dfustini-atl-sc-cbqri-dt-v2-0-2f8049fd902b@kernel.org> <20260624-dfustini-atl-sc-cbqri-dt-v2-4-2f8049fd902b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdW4gMjcsIDIwMjYgYXQgMDU6MTk6NDRQTSArMDgwMCwgeXVuaHVpIGN1aSB3cm90 ZToKPiBIaSBEcmV3LAo+IAo+IE9uIFRodSwgSnVuIDI1LCAyMDI2IGF0IDk6NDHigK9BTSBEcmV3 IEZ1c3RpbmkgPGZ1c3RpbmlAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gQWRkIHN1cHBvcnQg Zm9yIHRoZSBSSVNDLVYgQ0JRUkkgY2FwYWNpdHkgY29udHJvbGxlci4gQSBwbGF0Zm9ybSBkcml2 ZXIKPiA+IHBhc3NlcyBhIGNicXJpX2NvbnRyb2xsZXJfaW5mbyBkZXNjcmlwdG9yIHRvZ2V0aGVy IHdpdGggdGhlIGNhY2hlIGxldmVsCj4gPiB0byByaXNjdl9jYnFyaV9yZWdpc3Rlcl9jY19kdCgp LCB3aGljaCBwcm9iZXMgdGhlIGNvbnRyb2xsZXIgYW5kIGFkZHMgaXQKPiA+IHRvIHRoZSBjb250 cm9sbGVyIGxpc3QuCj4gPgo+ID4gQXNzaXN0ZWQtYnk6IENsYXVkZTpjbGF1ZGUtb3B1cy00LTcK PiA+IENvLWRldmVsb3BlZC1ieTogQWRyaWVuIFJpY2NpYXJkaSA8YXJpY2NpYXJkaUBiYXlsaWJy ZS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBZHJpZW4gUmljY2lhcmRpIDxhcmljY2lhcmRpQGJh eWxpYnJlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERyZXcgRnVzdGluaSA8ZnVzdGluaUBrZXJu ZWwub3JnPgo+ID4gLS0tCj4gPiAgTUFJTlRBSU5FUlMgICAgICAgICAgICAgICAgICAgICAgfCAg IDMgKwo+ID4gIGRyaXZlcnMvcmVzY3RybC9LY29uZmlnICAgICAgICAgIHwgIDEzICsKPiA+ICBk cml2ZXJzL3Jlc2N0cmwvTWFrZWZpbGUgICAgICAgICB8ICAgMyArCj4gPiAgZHJpdmVycy9yZXNj dHJsL2NicXJpX2RldmljZXMuYyAgfCA1MjAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gPiAgZHJpdmVycy9yZXNjdHJsL2NicXJpX2ludGVybmFsLmggfCAxMDcgKysr KysrKysKPiA+ICBpbmNsdWRlL2xpbnV4L3Jpc2N2X2NicXJpLmggICAgICB8ICA0NyArKysrCj4g PiAgNiBmaWxlcyBjaGFuZ2VkLCA2OTMgaW5zZXJ0aW9ucygrKQpbLi5dCj4gPiAraW50IGNicXJp X2FwcGx5X2NhY2hlX2NvbmZpZyhzdHJ1Y3QgY2JxcmlfY29udHJvbGxlciAqY3RybCwgdTMyIGNs b3NpZCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGNicXJp X2NjX2NvbmZpZyAqY2ZnKQo+ID4gK3sKWy4uXQo+ID4gKwo+ID4gKyAgICAgICAvKiBTZXQgY2Fw YWNpdHkgYmxvY2sgbWFzayAoY2NfYmxvY2tfbWFzaykgKi8KPiA+ICsgICAgICAgY2Jxcmlfc2V0 X2NibShjdHJsLCBjZmctPmNibSk7Cj4gPiArCj4gPiArICAgICAgIC8qIENhcGFjaXR5IGNvbmZp ZyBsaW1pdCBvcGVyYXRpb24gZm9yIHRoZSBBVCBoYWxmIGltcGxpZWQgYnkgY2ZnLT5hdCAqLwo+ ID4gKyAgICAgICBlcnIgPSBjYnFyaV9jY19hbGxvY19vcChjdHJsLCBDQlFSSV9DQ19BTExPQ19D VExfT1BfQ09ORklHX0xJTUlULAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj bG9zaWQsIGNmZy0+YXQpOwo+ID4gKyAgICAgICBpZiAoZXJyIDwgMCkKPiA+ICsgICAgICAgICAg ICAgICBnb3RvIG91dDsKPiAKPiBXaGVuIENVTklUUz0xLCBDT05GSUdfTElNSVQgYWxzbyBjb25z dW1lcyBjY19jdW5pdHMuIElmIHJlc2N0cmwgZG9lcyBub3QKPiBleHBvc2UgdW5pdCBsaW1pdHMs IHRoZSBkcml2ZXIgc2hvdWxkIHN0aWxsIHdyaXRlIGNjX2N1bml0cz0wIGJlZm9yZQo+IENPTkZJ R19MSU1JVCB0byBhdm9pZCBhIGhpZGRlbiBzdGFsZS9pbXBsZW1lbnRhdGlvbi1kZWZpbmVkIHVu aXQgbGltaXQuCj4gCj4gU2hvdWxkIHdlIGhhbmRsZSBjY19jdW5pdHMgaGVyZT8KClRoYXQgaXMg YSBnb29kIHRoYXQgY2NfdW5pdHMgc2hvdWxkIGJlIGhhbmRsZWQgZXZlbiB0aG91Z2ggd2UgY2Fu J3QgeWV0CmV4cG9zZSBpdCB0byByZXNjdHJsLiBJIHdpbGwgY2hhbmdlIHRoZSBjb2RlIHRvIHNl dCBjY19jdW5pdHMgdG8gMApiZWZvcmUgYSBjb25maWcgbGltaXQgb3BlcmF0aW9uIG9uIGNvbnRy b2xsZXJzIHRoYXQgc3VwcG9ydCBjYXBhY2l0eQp1bml0cywgc28gYSBzdGFsZSB1bml0IGxpbWl0 IGRvZXMgbm90IGNvbnN0cmFpbiBibG9jay1tYXNrIGFsbG9jYXRpb24uCgpUaGFua3MsCkRyZXcK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJp c2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK