From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662311D5ADE; Sat, 27 Jun 2026 22:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782598207; cv=none; b=d6u7xfK598nHgtl8M0mSBZGM/LxwiZBLUaIv6+cIxtR9mc4ZG3N6YYjjMvKYqUeGuT8ggPLtLzIp72FdhfXTLg0BBGSOOpWd+nLtontzo/2Wj1hAde0ZmktbPOY8hSkbt8WndJjkyvuoLcxusgFZwcjopjPsAZVSYOD/wmMajNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782598207; c=relaxed/simple; bh=d9G+ljKEjOva0maSSJ1JxkRDkBP2lZWCTnWq49qSDUY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hM+tHbctEhiwyMfkcrMuXm5tKe5ANPrqGcDW+SE8L/Vn0GHwjA5sSkVpS3XlWmeSa2+uU+jPD77nMNY1ZlwZx/zFQ+ef4honbRtPXbw3gDNVARbBMZS3G7Zo8Em6WkkzESX0p6KhFEJIqIom6RjRUd3HjUdt3LYzxkD5LsncrbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KwNrxQgJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KwNrxQgJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93C491F000E9; Sat, 27 Jun 2026 22:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782598206; bh=hXk/3wj9lPuJCQvYpjGC/6+kjVjcs5SuF2pwhCfblgk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KwNrxQgJVN8O/LbbNanheVHNF4seUkCijI6JBEHt+/pVyaoyi8GHna1M8j9Q8rFwy vjYXsheeYMBZZBM4h46nutz/29QBslwVDHlDG8v14K9zWPf8u3Q0TsPvzEpqNPULIy Ka+qEUM7TFWkIGMxpp+GaHihtgYKrWsLDXEZx7dizRfq9smMXkoYJR6bCLe6nSuNeo +kUpVcIbVWV/WYRzdY/1rCdNllhLfi+cVc+AVILwSEZ7UXYXPTaq9jk7fhok7zkKiY 12B+J7VadfIPGgB4GEVSueOD6eHRiMYmLCCaiWUf6BRtOeLtSgLeXhN11rAr22sK93 rFkVT4B/TcJCg== Date: Sat, 27 Jun 2026 15:10:04 -0700 From: Drew Fustini To: yunhui cui Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [External] [PATCH v2 4/8] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20260624-dfustini-atl-sc-cbqri-dt-v2-0-2f8049fd902b@kernel.org> <20260624-dfustini-atl-sc-cbqri-dt-v2-4-2f8049fd902b@kernel.org> Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jun 27, 2026 at 05:31:03PM +0800, yunhui cui wrote: > Hi Drew, > > On Thu, Jun 25, 2026 at 9:41 AM Drew Fustini wrote: > > > > Add support for the RISC-V CBQRI capacity controller. A platform driver > > passes a cbqri_controller_info descriptor together with the cache level > > to riscv_cbqri_register_cc_dt(), which probes the controller and adds it > > to the controller list. > > > > Assisted-by: Claude:claude-opus-4-7 > > Co-developed-by: Adrien Ricciardi > > Signed-off-by: Adrien Ricciardi > > Signed-off-by: Drew Fustini [..] > > diff --git a/drivers/resctrl/cbqri_devices.c b/drivers/resctrl/cbqri_devices.c > > new file mode 100644 > > index 0000000000000000000000000000000000000000..8ad9df404f65d5d82722cf8b78f02936c489ca6d > > --- /dev/null > > +++ b/drivers/resctrl/cbqri_devices.c [..] > > + > > +/* Set capacity block mask (cc_block_mask) */ > > +static void cbqri_set_cbm(struct cbqri_controller *ctrl, u64 cbm) > > +{ > > + iowrite64(cbm, ctrl->base + CBQRI_CC_BLOCK_MASK_OFF); > > The CBQRI spec allows naturally aligned 4-byte accesses and only guarantees > atomicity for 4-byte accesses; 8-byte atomicity is unspecified. > > Would 32-bit split accesses be preferable here instead of relying on > ioread64/iowrite64? This may also make the driver less dependent on native > 64-bit MMIO support. I suppose there could be systems that are RV64 but do 4-byte access for the CBQRI registers. You are right the spec only guarantees atomicity for naturally aligned 4-byte accesses and leaves 8-byte atomicity unspecified. I will switch the controller register accesses to 32-bit reads and writes. The driver rejects ncblks > 32, so cc_block_mask only uses its low 32 bits. For cc_alloc_ctl, the writable fields all sit in the low word while the status and busy bits are read-only in the high word. A read can reconstruct the value from two 32-bit reads and a write only needs the low word. Thanks, Drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A520EC43458 for ; Sat, 27 Jun 2026 22:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UTHP4LHAQTXo6b8EO8Yk9h2Yrtv2TB1+kOn3iMrEsXo=; b=cK4Le7AwoRRyOv wZKs6BamJQ2cqJY2L4AFHuUk7+gxnEAYwXutjjaI4FbXdm8QBxzE0LfMg0CB5NUKmV/9eQDfLOLQD pTWRo+eeq8DJqPNTLREG2cA562ZC1slbjaqEiq2cI8DnQ8CntdFu049Mb9UPVP6kdpOv63YOYOhIy hChVtP5paWqvpKzr89S3w0lmNtJH78dztf6YwfuvWqGLl4Ag3whHmcQDGjakON5GHD0/nlBDNIwOJ CTKkyA6VG90R8o4F1K7lvPTgSrMnCyI/jWGi6j9wr1EeZZaG9tF+Ne85jgaitYtfnk5IaTnyxnt8r PR0C/xlcUhsRORGy1GkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wdbE2-0000000CmyT-0FVi; Sat, 27 Jun 2026 22:10:10 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wdbE0-0000000CmyN-2Gyu for linux-riscv@lists.infradead.org; Sat, 27 Jun 2026 22:10:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 30DC743F4D; Sat, 27 Jun 2026 22:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93C491F000E9; Sat, 27 Jun 2026 22:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782598206; bh=hXk/3wj9lPuJCQvYpjGC/6+kjVjcs5SuF2pwhCfblgk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KwNrxQgJVN8O/LbbNanheVHNF4seUkCijI6JBEHt+/pVyaoyi8GHna1M8j9Q8rFwy vjYXsheeYMBZZBM4h46nutz/29QBslwVDHlDG8v14K9zWPf8u3Q0TsPvzEpqNPULIy Ka+qEUM7TFWkIGMxpp+GaHihtgYKrWsLDXEZx7dizRfq9smMXkoYJR6bCLe6nSuNeo +kUpVcIbVWV/WYRzdY/1rCdNllhLfi+cVc+AVILwSEZ7UXYXPTaq9jk7fhok7zkKiY 12B+J7VadfIPGgB4GEVSueOD6eHRiMYmLCCaiWUf6BRtOeLtSgLeXhN11rAr22sK93 rFkVT4B/TcJCg== Date: Sat, 27 Jun 2026 15:10:04 -0700 From: Drew Fustini To: yunhui cui Cc: Adrien Ricciardi , Alexandre Ghiti , Atish Kumar Patra , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [External] [PATCH v2 4/8] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20260624-dfustini-atl-sc-cbqri-dt-v2-0-2f8049fd902b@kernel.org> <20260624-dfustini-atl-sc-cbqri-dt-v2-4-2f8049fd902b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdW4gMjcsIDIwMjYgYXQgMDU6MzE6MDNQTSArMDgwMCwgeXVuaHVpIGN1aSB3cm90 ZToKPiBIaSBEcmV3LAo+IAo+IE9uIFRodSwgSnVuIDI1LCAyMDI2IGF0IDk6NDHigK9BTSBEcmV3 IEZ1c3RpbmkgPGZ1c3RpbmlAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gQWRkIHN1cHBvcnQg Zm9yIHRoZSBSSVNDLVYgQ0JRUkkgY2FwYWNpdHkgY29udHJvbGxlci4gQSBwbGF0Zm9ybSBkcml2 ZXIKPiA+IHBhc3NlcyBhIGNicXJpX2NvbnRyb2xsZXJfaW5mbyBkZXNjcmlwdG9yIHRvZ2V0aGVy IHdpdGggdGhlIGNhY2hlIGxldmVsCj4gPiB0byByaXNjdl9jYnFyaV9yZWdpc3Rlcl9jY19kdCgp LCB3aGljaCBwcm9iZXMgdGhlIGNvbnRyb2xsZXIgYW5kIGFkZHMgaXQKPiA+IHRvIHRoZSBjb250 cm9sbGVyIGxpc3QuCj4gPgo+ID4gQXNzaXN0ZWQtYnk6IENsYXVkZTpjbGF1ZGUtb3B1cy00LTcK PiA+IENvLWRldmVsb3BlZC1ieTogQWRyaWVuIFJpY2NpYXJkaSA8YXJpY2NpYXJkaUBiYXlsaWJy ZS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBZHJpZW4gUmljY2lhcmRpIDxhcmljY2lhcmRpQGJh eWxpYnJlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERyZXcgRnVzdGluaSA8ZnVzdGluaUBrZXJu ZWwub3JnPgpbLi5dCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9yZXNjdHJsL2NicXJpX2Rldmlj ZXMuYyBiL2RyaXZlcnMvcmVzY3RybC9jYnFyaV9kZXZpY2VzLmMKPiA+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li44YWQ5ZGY0MDRmNjVkNWQ4MjcyMmNmOGI3OGYwMjkzNmM0ODljYTZkCj4gPiAtLS0gL2Rldi9u dWxsCj4gPiArKysgYi9kcml2ZXJzL3Jlc2N0cmwvY2JxcmlfZGV2aWNlcy5jClsuLl0KPiA+ICsK PiA+ICsvKiBTZXQgY2FwYWNpdHkgYmxvY2sgbWFzayAoY2NfYmxvY2tfbWFzaykgKi8KPiA+ICtz dGF0aWMgdm9pZCBjYnFyaV9zZXRfY2JtKHN0cnVjdCBjYnFyaV9jb250cm9sbGVyICpjdHJsLCB1 NjQgY2JtKQo+ID4gK3sKPiA+ICsgICAgICAgaW93cml0ZTY0KGNibSwgY3RybC0+YmFzZSArIENC UVJJX0NDX0JMT0NLX01BU0tfT0ZGKTsKPiAKPiBUaGUgQ0JRUkkgc3BlYyBhbGxvd3MgbmF0dXJh bGx5IGFsaWduZWQgNC1ieXRlIGFjY2Vzc2VzIGFuZCBvbmx5IGd1YXJhbnRlZXMKPiBhdG9taWNp dHkgZm9yIDQtYnl0ZSBhY2Nlc3NlczsgOC1ieXRlIGF0b21pY2l0eSBpcyB1bnNwZWNpZmllZC4K PiAKPiBXb3VsZCAzMi1iaXQgc3BsaXQgYWNjZXNzZXMgYmUgcHJlZmVyYWJsZSBoZXJlIGluc3Rl YWQgb2YgcmVseWluZyBvbgo+IGlvcmVhZDY0L2lvd3JpdGU2ND8gVGhpcyBtYXkgYWxzbyBtYWtl IHRoZSBkcml2ZXIgbGVzcyBkZXBlbmRlbnQgb24gbmF0aXZlCj4gNjQtYml0IE1NSU8gc3VwcG9y dC4KCkkgc3VwcG9zZSB0aGVyZSBjb3VsZCBiZSBzeXN0ZW1zIHRoYXQgYXJlIFJWNjQgYnV0IGRv IDQtYnl0ZSBhY2Nlc3MgZm9yCnRoZSBDQlFSSSByZWdpc3RlcnMuIFlvdSBhcmUgcmlnaHQgdGhl IHNwZWMgb25seSBndWFyYW50ZWVzIGF0b21pY2l0eQpmb3IgbmF0dXJhbGx5IGFsaWduZWQgNC1i eXRlIGFjY2Vzc2VzIGFuZCBsZWF2ZXMgOC1ieXRlIGF0b21pY2l0eQp1bnNwZWNpZmllZC4KCkkg d2lsbCBzd2l0Y2ggdGhlIGNvbnRyb2xsZXIgcmVnaXN0ZXIgYWNjZXNzZXMgdG8gMzItYml0IHJl YWRzIGFuZAp3cml0ZXMuIFRoZSBkcml2ZXIgcmVqZWN0cyBuY2Jsa3MgPiAzMiwgc28gY2NfYmxv Y2tfbWFzayBvbmx5IHVzZXMgaXRzCmxvdyAzMiBiaXRzLiBGb3IgY2NfYWxsb2NfY3RsLCB0aGUg d3JpdGFibGUgZmllbGRzIGFsbCBzaXQgaW4gdGhlIGxvdwp3b3JkIHdoaWxlIHRoZSBzdGF0dXMg YW5kIGJ1c3kgYml0cyBhcmUgcmVhZC1vbmx5IGluIHRoZSBoaWdoIHdvcmQuIEEKcmVhZCBjYW4g cmVjb25zdHJ1Y3QgdGhlIHZhbHVlIGZyb20gdHdvIDMyLWJpdCByZWFkcyBhbmQgYSB3cml0ZSBv bmx5Cm5lZWRzIHRoZSBsb3cgd29yZC4gCgpUaGFua3MsCkRyZXcKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAps aW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK