Re: [PATCH 2/3] arm64: dts: qcom: glymur: Add Asus Zenbook A14 (UX3407NA)

[Bjorn Andersson <andersson@kernel.org>]

On Tue, Jun 23, 2026 at 09:06:51AM +0200, Konrad Dybcio wrote:
> On 6/23/26 3:31 AM, Bjorn Andersson wrote:
> > From: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> > 
> > UX3407NA is a variant of the Asus Zenbook A14 built on the Qualcomm
> > Glymur platform. It comes with an 18-core X2 Elite SoC, 32GB DDR, and
> > the other typical Glymur platform capabilities.
> > 
> > The Asus Zenbook uses &pcie3b for NVMe storage, the screen is WUXGA
> > OLED, it has two USB Type-C ports, one USB Type-A, and one HDMI port.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> > ---
> 
> [...]
> 
> > +/ {
> > +	compatible = "asus,zenbook-a14-ux3407na", "qcom,glymur";
> > +	model = "ASUS Zenbook A14 (UX3407NA)";
> 
> unusual order!
> 

While I don't see this case documented in dts-coding-style.rst, this
order seems better...

[..]
> > +&tlmm {
> > +	gpio-reserved-ranges = <4 4>, /* EC Secure */
> > +			       <10 2>, /* OOB UART */
> > +			       <44 4>, /* TPM */
> > +			       <90 2>; /* TPM */
> 
> Is there no EC reset pin? I wouldn't want others to have to open up
> a laptop after trying to find out what it does..
> 

These are the ones needed to allow the thing to boot, I don't know what
the EC reset pin does, but I guess we can add some more for convenience.

[..]
> > +&uart21 {
> > +	status = "disabled";
> 
> hm?
> 

The debug-uart is left enabled in glymur.dtsi. Perhaps we should change
that instead?

Regards,
Bjorn

> Konrad