From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D1CA3D6673 for ; Mon, 29 Jun 2026 07:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782717907; cv=none; b=oTs5OcsRLLxdsXJCWHwqdu7yQYTb5f0ftfC84dnBG5ZIqdhVpx8C/U+bQvxRaaxKuf4ONjiCpHr/2YDXskIGJUheV4GN0jDJ+MbcRi9I0nwZ86h/sCmFxEjYDS02lTvio9ePKx1IHVFTa2baPGFQ2jzLa+WOL5ngm5kKtNp0EXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782717907; c=relaxed/simple; bh=n+7c8QnQ8pPwghaAGQ5hjT3Ypry9KEiXXo6pN4533q4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nz9+0cMWmyzNIEv9FrLxtOx7z0iIRRnSnI06jNsLaF7ZbQNnTZ/6ykIEwnXZ9+JPqVWAjXe8P/QIRf/pl5OOi4/wk1WbsX21O0TtOpttwV8CYkUEXG9wlGDYQhqNtspv37ylR2gMf2HqOEAk4qf8k6YcwzfnXNdY4o2lAgzqN+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E3wdfxc3; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E3wdfxc3" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4939a809b24so13684865e9.1 for ; Mon, 29 Jun 2026 00:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782717903; x=1783322703; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eLDWMh4ifhAAqWhEnL83ySDPMpXcU8bUP9rQJHl3ghI=; b=E3wdfxc3jhL6Pip2oGnPG3bLVJX3u2oTZaAtcf6c7LkL6nR7ZEyUpLq49pOSmAtBJ0 b8RHf8F2Uohl5LnOO0XgcBDmeesyFlYrNO13JACyEvs1+CxUSEzUT7HFJe5ZmDl6NbkH xVy2a13oUsCzUn9BUSZIZgi7mhT+t4JkGZz6F5s/hU0NWwjnfEcY1xAxIJITxjkVZBGS 8wck/CVHd9ADEXpvNVifrbcssKmJT7fmC0+cdXFtF1y+4hAZ7dRBumLXFvA5MlAfNHBl wkA/KQumI+f3qM36YsjOHIMCH6EwJuLGB4kk57eTSnHYFnRg5SIXQHYzbeQpegpgPaUG ukNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782717903; x=1783322703; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLDWMh4ifhAAqWhEnL83ySDPMpXcU8bUP9rQJHl3ghI=; b=fewgDZFxd0jXyUtyhKUInFrobCTaiBfoAMnBbkQMRswiYcZWUTCBKGrme4mz3Vav9H DQZbeXEoQIvqCz0r3Njz6yga85xq4Ge4Cj/2qyXS7Wd7ZSYOUsJvAHOx9vSQNV9NSSrL CClB9ER8eQwXXZvJI4eyv0MlD/cDMLoMCCA5rpg8XDV17RcORiL9jK5fS/kET8ZN0I5Y p5SmK0Ajl/bozeBLO3woK5MvTMDj6FwRi1lkW0UY/TaL4NPudjs204iDCbedkDUTPUWj JROOv3ZaKn6SiHzYKNg5SuxczAOjpP+9vjIVzxEMCmsn2VkBcH5XWM/miWdHuBbZFJQ4 nSMA== X-Forwarded-Encrypted: i=1; AFNElJ+DMgH/iUnOx2fp3i8iR5Km+K6SI1G6Zl611vV1em0ueiAfENLi0y+dWbEA17PUXoJI+58+0Pq7ooqwSx8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3wTN3hiQyxuu3/VA8coW7nZhZY7xKlIc+/lusrujJQQdivPOG mvUA2KS24LLo/3RU/RrNOORRBlO6z3DVlzk5aHukQQJ7aVWKSrniNt85ntWXirzZ X-Gm-Gg: AfdE7clOv1ZR59jMLqIYHFCCaTcF5PVn/0iZYRib1kNet4h0zuhHdZp0tuar70z2rR9 6+R0HYBQ9vo/M/+UmCrgyCexrcWhh2cR2S+LJfeIZRaoDvd09NTtOVdg4qxnNz467ZOWcS1q0Qa TR1K9+2eIK99c7zktvDYHv0dpys+KC6Eoc52fjJQsIvI6PnEvA8EmSlRwncF6WIhVG/wW7M+8I7 QoDb/ap61zMzThIL6aASH0T8kwpK8fj+9+IFj2hnjxD+QmN8Xh/JndvzWjBOkTEd4EV9OJ0Rhdj 7/6yCNbOzeQNrQPvPJsn+vdu6jPDAIV5VZhMWRA4o2RoogNknJL8LPmwAg7arvQSh9IIDk62u+b od7DPkePMyGhE9SI5l2xvZRWKOPgrXR5q1jvuL5ShAcDCuja1dlXuTmb03qzSGuksiUwno9yo7V OnGN9EcTwe/Q== X-Received: by 2002:a05:600c:8109:b0:490:bad9:de43 with SMTP id 5b1f17b1804b1-492667ca5fbmr236735665e9.0.1782717902646; Mon, 29 Jun 2026 00:25:02 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:9cf4:43df:e612:817b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926c285fc1sm198695665e9.1.2026.06.29.00.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 00:25:01 -0700 (PDT) Date: Mon, 29 Jun 2026 10:24:57 +0300 From: Dan Carpenter To: Prashant Rahul Cc: Greg Kroah-Hartman , Shuah Khan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] staging: octeon: Improve initialization error handling Message-ID: References: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260628-staging-driver-octeon-panic-v1-0-fe8c34989254@gmail.com> On Sun, Jun 28, 2026 at 12:31:23PM +0530, Prashant Rahul wrote: > Hi all, > > The TX and RX initialization paths currently call panic() on some > initialization failures. Instead, these failures should be reported back > to the probe function so that it can unwind any resources acquired during > initialization and fail gracefully. > > This series replaces those panic() calls with proper error logging, propagates > the errors to the probe function, and adds the necessary cleanup to avoid > leaving the driver in a partially initialized state. > > This is my first time working with drivers, so please let me know if I > have made any mistakes. > > Thank you! :3 > > Signed-off-by: Prashant Rahul > --- You need to say when you haven't tested your code. You need to say when you're using AI to write patches. There is a format for it. Documentation/process/coding-assistants.rst regards, dan carpenter