From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F83B3F8252 for ; Mon, 29 Jun 2026 08:55:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782723330; cv=none; b=TUTJ47Mx3S/fwdU724G0aYtrzb2pWEsRXCi19gw8Cb6yMpaWYbYKtloEBoGuG/nc/I20Jdl+fio3IPGM7/VJWCf+y/eNSCt8/BcUKFWdn2AK3RSaY1yxEyvE0ABfI4K0wHdlCzLnd4gPPjbaY44WiJgdVoArJxrtnBdpPN8cP0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782723330; c=relaxed/simple; bh=/ifxBsG/leb631xMulkx/J8+Hl2OxHrpm4ozKGpTTUU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yj/0VqAtNhyIdgVQapJLrcyzycpl5fUeTGzhW3ZpieXNC60k/u/i8R4vIZtoINZphLWb8/Nxp+xgPezVRgc6IUUiR49Sr5BT3NmpoMC8BSyLNg4fLn/YjJIopa5lWUIInDScKNjfQlanCJJt7DO0vp6fz9cNwyfgfYxfMqy34o8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=I5gz1ZBN; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="I5gz1ZBN" Date: Mon, 29 Jun 2026 10:55:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782723327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aNlz5QdGAFmc11ruQQGGkQJUKoaOG3OO0MGF9N+JsKw=; b=I5gz1ZBNJTJDPbA0LILsq4JdoFro2CSV0OcQA3abjOfbd3xX1x7/dbM14Tz38NGhKUQ3mo V0QL5uqA1M6SfEfdrfCDVgL5me1v34TknxXX4x+PE1rFqW5z130CQ4yopo5jIGMN0Hzorx IcESxQJAJdKWLZpsHyO3ywooo9Rkt8I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Geert Uytterhoeven Cc: Daniel Palmer , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] m68k: amiga: Mark amiga_reset() as __noreturn Message-ID: References: <20260626145731.64010-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Mon, Jun 29, 2026 at 09:25:48AM +0200, Geert Uytterhoeven wrote: > Hi Thorsten, > > Thanks for your patch! > > On Fri, 26 Jun 2026 at 16:58, Thorsten Blum wrote: > > [PATCH v2] m68k: amiga: Mark amiga_reset() as __noreturn > > This is not what this patch does, as amiga_reset() is already marked > __noreturn. I assumed __noreturn on the second prototype would be ignored, but it is in fact additive. > > Mark both the forward declaration and the function definition as > > __noreturn, and remove the redundant redeclaration. > > Why both? No other static function (except for xen_pv_play_dead) > is tagged __noreturn in both the forward declaration and the > implementation. Can I blame the heat wave? I'll send a v3 later. Thanks, Thorsten