From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77F341C3BFC for ; Mon, 29 Jun 2026 13:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740199; cv=none; b=g9v+WJxhkmQEYMN4RgntfxWA1FZ3as+JkX6slaHdjvH47nFOkjC2StAurbAjUxMQZO22yM+CDWsP9krBpJoxuXU6TzMA/yrUAfpWtTdXjoUK9Tg0ORpBHk0wjUsrQHnfFJvjUPdw5Um4qqdvqPlF8/2Y4U0VSm1F/TpthDLhps4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782740199; c=relaxed/simple; bh=+1OwKV1dyxOCFDgRqLWV7JVciKZ94ymxEIolDxA6tg0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dwjk7+X7kHl/b278bKMFeFvqybhVz49x+eIg5LlUH/ZBEBNb93qNBm27jgz/fb+T2Wf3ntbEpTu9dSefA4Lj/BO5nYwH9qew6AZxW8ou7JOwEQBjxHeRfS0Sd3yVf8++/CRrYxudV1NBtqFZ/uv86cN7gPittRkO8lEP5oGDAuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=atjCtzkR; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="atjCtzkR" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-493ad116e05so6685125e9.3 for ; Mon, 29 Jun 2026 06:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782740195; x=1783344995; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6xxjjeNOvGN8eekdMLSiFo3jimcUTLIN7SVK1r32J0k=; b=atjCtzkR8CDlTctdsh10tW5QNcbLWwfCzIw1m6pXVm+cFWEAShF7zsqW2n0263uOfF LcDkcfdWf0Jz9pE+LHFh8qB5OdyXgM8uzhmfk0319JPJSinTws14zPB9NyG9zMoWPLz8 RMKh20SoCrylioNR1gTnc/qjP4+h/Yh//F2Y0fal5uOLjYtEw5xP71wFwozOazKNfVJp C/D3mNwNNyFzKT507s9j8cGVKcbhgZhPwty2f92QcuS+f57/cx5kdufXGNG6wBMLCIAc NKgCACYnjw5lgy/0boo+QyYgFeRb3RwwmfIyIyBAP/6XaY3368zqlwSQCu5OBvPnrv3u Nl5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782740195; x=1783344995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6xxjjeNOvGN8eekdMLSiFo3jimcUTLIN7SVK1r32J0k=; b=VTTqDRL8JB2w+yrZFOc+QETifbidZbqY3M/q3RQ5FkM6rctcAoqygk4OeqcIqAIZ6j TtEQBI02pmCUIyayebCcfEKK3KZUpaKu+Skp+U9DgN7dDPOG5Lse+DWuUjst5XykLB+J 3DczSnUswLq04g8TcQCFBM3wvEtcje4UbxFho0uZ6AqT2uF1LI178PDAfD244FydbPcp WnA7k3WfBVxuFpRVommiI969G0L9lCY0oBIO6XG2Ksh2AIFFUGg3LQ+c3DwXIdE87TFL Y3BATPs6AER07OA/Ff7v6BDT+2aZp3W3FNM/lBM1bgUNVze/CRHPaSZUr4VSk5vBQtR0 /RCA== X-Forwarded-Encrypted: i=1; AFNElJ92llhyxGF0a+0Ab32QzMkjLF9Gnfi5Qm7jfiFw2dkkVLZAAodl/8+Q85KpRWrVUfpfCiKRpkfkTjwVWyM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw89nREaT+sKaMSIzSIN3aDGEp53VnBeezlNjPucaHjnC9I1nQr NHwPfvi+nqWmHOO9sqXFgnoKg5JPoo4XDMRYeeZ0peKVlODmnlni1m3Ygp5GdOQveWI= X-Gm-Gg: AfdE7cnVUDpEhx605vrkA+TUTtHMl83f5DvfRRHpreE0AOE+xqyGB3KCBUnnUDJsQ6h 3PEfxQ2BjYH4IBe3nRMZFZbOegsZ5kPXseGhEawcgtsNOrwjaOG+huKfHzVHlsTdpkBrpRug7Yw PN154MEfgPcP052dmttVv4jwh0Nm4Gbu/4OEptzxm6ank7blWVJncuGs+EIU2hVPFM2ubveLIsC JOETJKewur4a6unVZpvFaSwij98DlAhobVOu22LM7nwxZsMk7efi8LYrnQIHScrpcDtO3tzxuSA i2ptCkaNk7gJied2p/a/lJCHDexSzOVNcOZkm6I+RCe774U1PemI5KEgBilCj4MBQUgjh1ozmJg H8uQNdG1OJgVeogTQ4z8aWROU+husSt8QTEovXy0O4FavHWJllvSaNr9ptD+VcGCn5pfXhfe4FL RwcumdUZpSwIfb3Tg94+PCSkbVy9Oup7iqo08h5yc/0qvayiSb14NPwppztFlK77qRSIyk//vai 4/k X-Received: by 2002:a05:600c:3b24:b0:490:bd66:db49 with SMTP id 5b1f17b1804b1-49266850100mr271074205e9.12.1782740194716; Mon, 29 Jun 2026 06:36:34 -0700 (PDT) Received: from localhost (p200300f65f47db04294e5bd34a12a699.dip0.t-ipconnect.de. [2003:f6:5f47:db04:294e:5bd3:4a12:a699]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493b729b5c3sm11139505e9.2.2026.06.29.06.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 06:36:33 -0700 (PDT) Date: Mon, 29 Jun 2026 15:36:31 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Linus Torvalds , Greg Kroah-Hartman , Hans de Goede , platform-driver-x86@vger.kernel.org, LKML , Danilo Krummrich Subject: Re: [PATCH v3 09/16] platform/x86: x86-android-tablets: Add include defining struct dmi_system_id Message-ID: References: <3bcb32f8-00d2-905c-3dc1-e8730611fb6a@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w43dpmzsnqdovct5" Content-Disposition: inline In-Reply-To: <3bcb32f8-00d2-905c-3dc1-e8730611fb6a@linux.intel.com> --w43dpmzsnqdovct5 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 09/16] platform/x86: x86-android-tablets: Add include defining struct dmi_system_id MIME-Version: 1.0 Hello Ilpo, On Mon, Jun 29, 2026 at 02:38:35PM +0300, Ilpo J=E4rvinen wrote: > On Sun, 28 Jun 2026, Uwe Kleine-K=F6nig (The Capable Hub) wrote: >=20 > > Currently includes transitively > > which ensures that struct dmi_system_id is defined in > > drivers/platform/x86/x86-android-tablets/x86-android-tablets.h. However > > this include in will be replaced by one for i2c_device_id > > only. To ensure that dmi_system_id is available add the include for that > > explicitly. > >=20 > > Acked-by: Danilo Krummrich > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > > --- > > drivers/platform/x86/x86-android-tablets/x86-android-tablets.h | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/drivers/platform/x86/x86-android-tablets/x86-android-table= ts.h b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h > > index 2498390958ad..c756961ae5fd 100644 > > --- a/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h > > +++ b/drivers/platform/x86/x86-android-tablets/x86-android-tablets.h > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > #include > > =20 > > struct gpio_desc; >=20 > Indirect include patchs are never a good idea as it always makes header= =20 > reorganizations minefield. So for this change, >=20 > Acked-by: Ilpo J=E4rvinen >=20 >=20 > When it comes to the series, I certainly like the direction it goes very= =20 > much (never have been fan of mod_devicetable.h) but I'd have preferred=20 > stepwise approach over trying to introduce it to some mid-rc. The hurdle here is that at least the header part isn't easily automateable. (Well it is, but the script that I have now to check all =2Ec files already takes longer than an hour to run. I guess it's not as optimal as it could, but still.) And so getting this ready for inclusion in next and keeping it up to date until the merge window opens is a tough job. The further downside is that each modification to one of the highly used headers is expensive (in rebuild time) when these are merged one after another (or when bisecting). So getting these changes in in one batch is beneficial. So while I agree with your preference, I don't think it's feasible. Best regards Uwe --w43dpmzsnqdovct5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpCdN0ACgkQj4D7WH0S /k4xLQgAh4immjoeTECwhwTEDPyJPR7aRvpV7cngXiXtBF20rkHaZv/awpHbKGdS tBBCAN1sS049uGGqw9hmgUPniQl16qFey1jKcQuFqQTHo+1NNqgaVuJ3qulIychO NcrZIgXeUEZKTUo62FzNHxCbZhTJJqru6r4paDNhH97POZ+QksvTyBJ2Eg1qr0/R QbUUxPcLwtNyoGAVt2IhaV8pcb+jh1D6FqUZn7UvZ6u1bbI4FDKAZ84lVZtCn6SH qZbgCVutmKZdCDUm+C8COu7PueDxKsIp8ZzP2fqoq8ymz/yGyVhSSgZ0n/eKDxIe GIAlnNs3JI+BRFuOHKwmPPAnkF+M6A== =IYV2 -----END PGP SIGNATURE----- --w43dpmzsnqdovct5--