From: Peter Xu <peterx@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: pbonzini@redhat.com, farosas@suse.de, qemu-devel@nongnu.org
Subject: Re: [PATCH] runstate: don't move to prelaunch on reset if postmigrate
Date: Mon, 29 Jun 2026 10:24:43 -0400 [thread overview]
Message-ID: <akKAK598q8IRWd0I@x1.local> (raw)
In-Reply-To: <20260627122234.657179-1-vsementsov@yandex-team.ru>
On Sat, Jun 27, 2026 at 03:22:34PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> As comment says, runstate can change in parallel. We check
> for FINISH_MIGRATE, but actually migration may proceed up
> to POSTMIGRATE.
>
> We should check for POSTMIGRATE as well, otherwise there is
> a race, if reset is in progress, and source may finish migration
> in PRELAUNCH state, which is unexpected for user.
>
> Seems correct to handle POSTMIGRATE the same way as FINISH_MIGRATE
> in this logic, as POSTMIGRATE is continuation for FINISH_MIGRATE.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
prev parent reply other threads:[~2026-06-29 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 12:22 [PATCH] runstate: don't move to prelaunch on reset if postmigrate Vladimir Sementsov-Ogievskiy
2026-06-29 14:24 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akKAK598q8IRWd0I@x1.local \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.