From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 027FEC43327 for ; Mon, 29 Jun 2026 16:30:07 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1weErv-0004EN-CE; Mon, 29 Jun 2026 12:29:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weErt-0004DR-Jb for qemu-devel@nongnu.org; Mon, 29 Jun 2026 12:29:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weErr-0005Lg-RY for qemu-devel@nongnu.org; Mon, 29 Jun 2026 12:29:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782750595; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNdOmthaHO7bT15vKRP3wLld7i7T3yvIbmgA0auvTzY=; b=bfuarxYL6SrcoABjV3g+QJTdrduC9nhs6CXKkl26r5rXc/QEnp51mSqxm5nF1Drk/APp9Q kiqUWU71HqKkS1YeaS2oeRO5h65yKttYntgF/dJQOpgP7rbEHaE61Qj+CY4Gd7dr2NChKj 6NEowNTwydOPRNkRImhnOybBJo4n/Pw= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-Y2jNCGOZP0GwRS6AUQot6Q-1; Mon, 29 Jun 2026 12:29:51 -0400 X-MC-Unique: Y2jNCGOZP0GwRS6AUQot6Q-1 X-Mimecast-MFC-AGG-ID: Y2jNCGOZP0GwRS6AUQot6Q_1782750590 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 945FC180048E; Mon, 29 Jun 2026 16:29:50 +0000 (UTC) Received: from redhat.com (unknown [10.44.50.121]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0834418005A2; Mon, 29 Jun 2026 16:29:48 +0000 (UTC) Date: Mon, 29 Jun 2026 17:29:45 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Evgeny Kolmakov Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Subject: Re: [PATCH] util/filemonitor-inotify: Use QEMU_LOCK_GUARD() Message-ID: References: <20260622073647.3721-1-randomjack94dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260622073647.3721-1-randomjack94dev@gmail.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jun 22, 2026 at 10:36:47AM +0300, Evgeny Kolmakov wrote: > Replace manual qemu_mutex_(un)lock() calls with > QEMU_LOCK_GUARD() to remove 'goto cleanup' code > > Signed-off-by: Evgeny Kolmakov > --- > util/filemonitor-inotify.c | 28 ++++++++-------------------- > 1 file changed, 8 insertions(+), 20 deletions(-) Reviewed-by: Daniel P. Berrangé and queued.. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|