From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2A84657DA for ; Mon, 29 Jun 2026 16:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751697; cv=none; b=XYQudsYFioRh2cH+Uq186VM8Qrcg61OqC14H75DbI+O6LgMG73lGfs9ibeMjlk8FBru+XnL04an2tGJ8HX+QuKCFZVeRazMK0t13OCZnLakLEJzyIyLykx+EIM1Kz1bVHwNnYpm+p5l8yPN7xuiFyCYwZRVcRiWLyJFBoyYGVLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751697; c=relaxed/simple; bh=e+xE8lrt/AcxBkXIHBRJGt5GrK2X9XXOBT2rdRaEl2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tjbx14dVmxtTp66jNoqmyrMXM/lwcEay8/jV5Jn21VM8eP1HKL1oCyXYRZ2hxzxkvqYOq7NNeGk3Yr3t92rqGILDuX02b1ioTmQozcFEhvVf2heUUfIdWUNbCO3OrWyvhjEwP+ajo5HDL/J18+bdpAkSGGSJFp8WJx4ngdWsGBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=HMiaOetR; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="HMiaOetR" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-92e622cc874so8017785a.0 for ; Mon, 29 Jun 2026 09:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1782751695; x=1783356495; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jP1TxhAMEeb/DtTSlE/UAKxKZK8EDPhR9yCR3yyzL/w=; b=HMiaOetRGhWbsEzLz+22ugBvSSVoUHDWkcyPaa5eXLeSrY8ILBZGpDPTrl9jPdJ8HC XJpdNOCWeKF0Y1R6wlNylSYSPWvdFDntuH9KNPvn+c9QYledfHlaNjdh6PP55wXWzk0m D+NlMrTFr6MlTewsDlQbwMNFRZo8TKxEyTFE4KmAlqd1ijCCgpQAjfxlJ09hcmtM2B0r U7i28BgXAPzi3UFlQs0ZFJ7ESLz8XZ8FDPvdx+cJ/+z3TzYgu6haTiZHE67tigBgfzqn wocf9AozgVnb7rlkkNZ4H+c2miCGhNUuNnvaFHBUN6XQ459fLmeEzktXuJC/HaetdiFH sYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782751695; x=1783356495; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jP1TxhAMEeb/DtTSlE/UAKxKZK8EDPhR9yCR3yyzL/w=; b=sjiuz1n2PljPAoNK0Qf1QuiKgi0W1a+ZLrTAFnGH15sptovb/0sD836o1qerK9jt0H cP97qmXxXHSE04aGdc5AAid/VPcgvhODy/5j1exGc7efn+IBSloyiSg7CvRrA2TlSk5u zD5MLCkgDTHHzdTbsjDEUNAMqDt8ZB7LL1/AQZvR+x3IuE1SupdnmQX0LMK3ttcWHshb 3p1KxWIb1M3/BPFuDjUlFrEwy9ulnkwRDZkQlMfsoAoyHRtOYoghlFAUuiGUPhdfFz/I EgNqxoNa7y36ERPJNwe1uA6JJWn4o34F14qCQ9lBLBfuB1fbHHc/RdSYE1KCqt9+BF6O LJyw== X-Forwarded-Encrypted: i=1; AFNElJ+oi7rMN1643bVBuEC02L1/o0aibowYm9ZKAgLiYN1ejG+hxSfdHDzWNU3f1+9qy5e2+nZ6lG5TevZyHJ8=@vger.kernel.org X-Gm-Message-State: AOJu0YyOWX8uMxm5EKg/81VIzGIoauZAKKoTqmAaCW2kQAoxubOvzkPT 6SWfI77N0YlOxpRGGD8L0JtEgciKwW85q6VGx7dTKMvIwI6braKwHw35H0qlcCkKaHo= X-Gm-Gg: AfdE7cndsJz732Rhm7uKqWALgpa0tnVxzBObxdROZpHHn9hjcuDzw4N85endLkPySNn fzaaJAi+ejgXq8dzTkQrR5zhwqYTD0U1uM/Q/8TQfWlFu8lnrt7a9P9i3kI6odDHiFZndbIx3fj 7JBTFSME4rZi2For2vU4/T+LF5NZq4uPSfFyBbo4KQHlCnBV86LYLliya7YmSy/0CmWDwxUoXIV Yfg8XSCJOk5BZlhqmyU9WgUpIJvAm78GK+RmJO1H+nXwPkdZF7UjKo7OJ0Zq8KzJd/yVKIcFqOc xt+JbDCnLeTs7ZlLaJRGmlGv1mLKYK7kdY9mWztubLMsTmiWKBaYioYDhx7aYiUNVPyUSbPc58g L9XEqrY6AdxyIFEQKJOkAtLz8cTIQCAVBPEo/341rPUMSGvmxIBLPrZwfoaZT7Hrr2FuQrwPh18 TNS6b37a/o5Q0= X-Received: by 2002:a05:620a:2951:b0:90c:be8b:3676 with SMTP id af79cd13be357-92e62886f7amr48040385a.56.1782751694917; Mon, 29 Jun 2026 09:48:14 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e6237ea0bsm22642885a.43.2026.06.29.09.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 09:48:14 -0700 (PDT) Date: Mon, 29 Jun 2026 12:48:13 -0400 From: Johannes Weiner To: Usama Arif Cc: Andrew Morton , david@kernel.org, linux-mm@kvack.org, tj@kernel.org, mkoutny@suse.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, liam@infradead.org, linux-kernel@vger.kernel.org, ljs@kernel.org, mhocko@suse.com, rppt@kernel.org, surenb@google.com, vbabka@kernel.org, kernel-team@meta.com Subject: Re: [PATCH v2 2/2] mm/vmpressure: split v1 userspace eventfd code into vmpressure-v1.c Message-ID: References: <20260629130042.2649505-1-usama.arif@linux.dev> <20260629130042.2649505-3-usama.arif@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260629130042.2649505-3-usama.arif@linux.dev> On Mon, Jun 29, 2026 at 05:59:37AM -0700, Usama Arif wrote: > @@ -101,7 +101,7 @@ obj-$(CONFIG_DEVICE_MIGRATION) += migrate_device.o > obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o khugepaged.o > obj-$(CONFIG_PAGE_COUNTER) += page_counter.o > obj-$(CONFIG_LIVEUPDATE_MEMFD) += memfd_luo.o > -obj-$(CONFIG_MEMCG_V1) += memcontrol-v1.o > +obj-$(CONFIG_MEMCG_V1) += memcontrol-v1.o vmpressure-v1.o Might as well move the interface part to memcontrol-v1.c instead of creating a new file. Otherwise looks good to me.