From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: Erick Henrique <erick.henrique.rodrigues@usp.br>,
jic23@kernel.org, andy@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 2/3] iio: dac: m62332: Clean up header includes
Date: Mon, 29 Jun 2026 20:15:52 +0300 [thread overview]
Message-ID: <akKoSAM1apknBDkZ@ashevche-desk.local> (raw)
In-Reply-To: <20260629190706.647c0274@systembl0wer>
On Mon, Jun 29, 2026 at 07:07:06PM +0200, Joshua Crofts wrote:
> On Mon, 29 Jun 2026 19:39:05 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Sun, Jun 28, 2026 at 12:48:10AM -0300, Erick Henrique wrote:
...
> > > +#include <linux/array_size.h>
> > > +#include <linux/bits.h>
> >
> > > +#include <linux/device.h>
> >
> > And this is for..?
> >
> > I can assume one wants to convert the driver to use dev_get_drvdata() perhaps?
>
> I also initially thought it's a case of an opaque struct device * pointer,
> but the driver already uses dev_get_platdata().
Ah, that explains...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-29 17:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 3:48 [PATCH v5 0/3] iio: dac: m62332: header cleanup and guard(mutex) Erick Henrique
2026-06-28 3:48 ` [PATCH v5 1/3] iio: dac: m62332: Sort header includes alphabetically Erick Henrique
2026-06-28 3:48 ` [PATCH v5 2/3] iio: dac: m62332: Clean up header includes Erick Henrique
2026-06-29 16:39 ` Andy Shevchenko
2026-06-29 17:07 ` Joshua Crofts
2026-06-29 17:15 ` Andy Shevchenko [this message]
2026-06-28 3:48 ` [PATCH v5 3/3] iio: dac: m62332: Use guard(mutex) for locking Erick Henrique
2026-06-28 11:45 ` Joshua Crofts
2026-06-29 17:23 ` [PATCH v5 0/3] iio: dac: m62332: header cleanup and guard(mutex) Andy Shevchenko
2026-07-01 0:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akKoSAM1apknBDkZ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=erick.henrique.rodrigues@usp.br \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.