From: Florian Westphal <fw@strlen.de>
To: Zhixing Chen <running910@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: ip6t_ah: validate AH header length
Date: Tue, 30 Jun 2026 07:16:48 +0200 [thread overview]
Message-ID: <akNRQFx9fmi2DK0w@strlen.de> (raw)
In-Reply-To: <20260618125848.93550-1-running910@gmail.com>
Zhixing Chen <running910@gmail.com> wrote:
> ip6t_ah checks that the fixed AH header is present, then uses hdrlen to
> derive the advertised AH header length for matching.
>
> Return false if the skb does not contain the advertised AH header length.
> This avoids matching AH headers whose advertised length is not present in
> the skb.
>
> Signed-off-by: Zhixing Chen <running910@gmail.com>
> ---
>
> I noticed ip6t_hbh and ip6t_rt already do this advertised-length check
> for their IPv6 extension headers, so this keeps ip6t_ah in line with
> those matches.
Could you make a v2 that addresses
https://sashiko.dev/#/patchset/20260618125848.93550-1-running910%40gmail.com
?
We should not return false in matches for malformed packets without
also setting ->hotdrop = true.
next prev parent reply other threads:[~2026-06-30 5:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 12:58 [PATCH nf] netfilter: ip6t_ah: validate AH header length Zhixing Chen
2026-06-30 5:16 ` Florian Westphal [this message]
2026-06-30 12:46 ` Zhixing Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akNRQFx9fmi2DK0w@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=running910@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.