From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9BFE40E8E1; Tue, 30 Jun 2026 14:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782830442; cv=none; b=recVc5TNmnq7iFz9Hghoy7i+zRKtxbqKlvXF+sCIJRZnpo42g5IMHjKzziT8vOan/539OBBxFbWCENfk6h6Oh3JFE2D6lFqhGHARMamSapBjUMLRSBCiCDWLy79+nJOJ7x2rCj0q+QxLreOSGm8UzF7olHxUCFATyJySk4ZZMdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782830442; c=relaxed/simple; bh=k2Gx1TGx8N/jRMuMnS7S+0n8kwKWGU8OEzpkiR0pcTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ko7PLMmzboTCEv81XpigQZgqBD8z2vcBIrmNgBCsjP3PmxCdgvyLQco7/mn8jCmAGkV5wNYMOL9EFItdaCd8PyLDZ0K9W+ipyI12y/0LwXrHgdiA8B9qdVa1XqSwTecxCa0yJtUTYbn3feoIpkuRVR5xOajYdsYo6Hm8k9ewHzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UaRdoyQZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UaRdoyQZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 097601F000E9; Tue, 30 Jun 2026 14:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782830441; bh=dvgyW8X4QaOk9VN18ZFlTY30npYMh5LShKDCXGOsMxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UaRdoyQZ1fTRKLAcvtRM8pCPos/hNLQhMFDTOXBDrPIVVOLNJRA7cU6ka14RHMRFR qWpfgLvKeAkf3XDjCuN2u6VoExWRrn+k9PHdw1xwsfaFYRW6apiRDH/bzW3S/vPXox NDxnR8QhAiI/zPphXPkt1KolvI83eq3Oxp7pH6P8fycRjVpGLO0mOiNQvzLLw+uZ8w WRnUBYhp2jcwsX+8wxOOiEB4mT754vZ1T4aD/zr4L6UdrtAvPeJdD/EC+QwUvwBkRC yr2g0tFvuReybfsvjS3lYxCtUKPjJPqHyXPEmCx9cYMHhnzg+aQfCesR1JnXw5Gekk GQ0tpKu3Pqrmg== Date: Tue, 30 Jun 2026 17:40:34 +0300 From: Mike Rapoport To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Brian Norris , Edward Cree , Francesco Dolcini , Manish Chopra , Przemek Kitszel , Sudarsana Kalluru , Tony Nguyen , b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() Message-ID: References: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> <20260630072344.159b5d99@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630072344.159b5d99@kernel.org> On Tue, Jun 30, 2026 at 07:23:44AM -0700, Jakub Kicinski wrote: > On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +-- > > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +- > > drivers/net/ethernet/sfc/mcdi.c | 7 +-- > > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +-- > > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++--- > > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++-- > > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++-------- > > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++------------- > > drivers/net/wireless/ti/wlcore/main.c | 14 +++-- > > You gotta split this, wireless and ethernet go via separate trees. Sure. > BTW cocci also suggests folding in a memset, IDK if it's worth it. Same churn, less lines :) > drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset > -- > pw-bot: cr -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34002C43458 for ; Tue, 30 Jun 2026 14:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QxaUC8xqO6VIuoID1tas5hkyt9FCSAe46ivWt5SW/qM=; b=W8Wwh0l6WNUXWf UWohfUtj0rUUg/yJx9u4JZnFFfLv+dKMOSACyEaSxnlvVvUt6iIpnzhMgyhIMKsGVbWPv1tPSDw5y Ml4I4ZoN57AH74OS7LLj2+8LUY5C+W++O3Wb6bEHXYJlRVW3zKZF0vX2WrtcX8KlR81YTsbEHqO/y gkvgb6Hi2zyJOPZX4Gxf/Z13b/JkiUhWuhX35elnNijH9r8WShXKY+rlbfDovciUv2c3cyow+yKX9 TAwPVkVKcTeIfLvIaLnBmLyZhDiMcfkeurO+XAcj25B8HKFefCGHLPkoti63Ijg3A+dcnX67BF8K9 FwAopuSWYJPWuw+6evTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1weZdo-0000000HIBJ-3QUi; Tue, 30 Jun 2026 14:40:48 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1weZdi-0000000HIB0-3GrS; Tue, 30 Jun 2026 14:40:42 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D8F40601C1; Tue, 30 Jun 2026 14:40:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 097601F000E9; Tue, 30 Jun 2026 14:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782830441; bh=dvgyW8X4QaOk9VN18ZFlTY30npYMh5LShKDCXGOsMxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UaRdoyQZ1fTRKLAcvtRM8pCPos/hNLQhMFDTOXBDrPIVVOLNJRA7cU6ka14RHMRFR qWpfgLvKeAkf3XDjCuN2u6VoExWRrn+k9PHdw1xwsfaFYRW6apiRDH/bzW3S/vPXox NDxnR8QhAiI/zPphXPkt1KolvI83eq3Oxp7pH6P8fycRjVpGLO0mOiNQvzLLw+uZ8w WRnUBYhp2jcwsX+8wxOOiEB4mT754vZ1T4aD/zr4L6UdrtAvPeJdD/EC+QwUvwBkRC yr2g0tFvuReybfsvjS3lYxCtUKPjJPqHyXPEmCx9cYMHhnzg+aQfCesR1JnXw5Gekk GQ0tpKu3Pqrmg== Date: Tue, 30 Jun 2026 17:40:34 +0300 From: Mike Rapoport To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Brian Norris , Edward Cree , Francesco Dolcini , Manish Chopra , Przemek Kitszel , Sudarsana Kalluru , Tony Nguyen , b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() Message-ID: References: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> <20260630072344.159b5d99@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260630072344.159b5d99@kernel.org> X-BeenThere: b43-dev@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: b43/b43legacy Linux driver discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "b43-dev" Errors-To: b43-dev-bounces+b43-dev=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2026 at 07:23:44AM -0700, Jakub Kicinski wrote: > On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +-- > > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +- > > drivers/net/ethernet/sfc/mcdi.c | 7 +-- > > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +-- > > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++--- > > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++-- > > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++-------- > > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++------------- > > drivers/net/wireless/ti/wlcore/main.c | 14 +++-- > > You gotta split this, wireless and ethernet go via separate trees. Sure. > BTW cocci also suggests folding in a memset, IDK if it's worth it. Same churn, less lines :) > drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset > -- > pw-bot: cr -- Sincerely yours, Mike. _______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB554C43327 for ; Tue, 30 Jun 2026 15:19:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C103981A65; Tue, 30 Jun 2026 15:19:15 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 4zoo7gC0ZYAp; Tue, 30 Jun 2026 15:19:15 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0E1AA81E58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1782832755; bh=dvgyW8X4QaOk9VN18ZFlTY30npYMh5LShKDCXGOsMxM=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=zkWfaKnRDUmipZjMjZG5YO2P6/GqEsGqBQM5LusQgSDrNihXChpyRjzwp2uxRaJGA Sltivi0zn4VeiJGd6iGjErlY86s7FATZIeae8b+QMW0XjoH95mWKpvRNtVFYt010gR AF6XIXtV/qFS9nLVxnbV8xfPsAh4QWJ/Q3gFDe7woPv6ctykebuqc2xogen9A5AhgR VXtTpXK44nHmb8o1SMm5mADz24JN65v7GwQn/kO5Ocvh6TNo/RZZlieHTFhW7ExUL/ wosjc9iWp1I2VA8fOL2Y9+QRqs1095OPcwR5gmgNlqNWxOYz1z637FEMIhIUg1nbw8 940AfMSg3WChg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 0E1AA81E58; Tue, 30 Jun 2026 15:19:15 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id 42FAC149 for ; Tue, 30 Jun 2026 14:40:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2151482977 for ; Tue, 30 Jun 2026 14:40:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ZidQchkflgt6 for ; Tue, 30 Jun 2026 14:40:43 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254; helo=tor.source.kernel.org; envelope-from=rppt@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8623480839 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8623480839 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8623480839 for ; Tue, 30 Jun 2026 14:40:43 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D8F40601C1; Tue, 30 Jun 2026 14:40:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 097601F000E9; Tue, 30 Jun 2026 14:40:36 +0000 (UTC) Date: Tue, 30 Jun 2026 17:40:34 +0300 From: Mike Rapoport To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Brian Norris , Edward Cree , Francesco Dolcini , Manish Chopra , Przemek Kitszel , Sudarsana Kalluru , Tony Nguyen , b43-dev@lists.infradead.org, intel-wired-lan@lists.osuosl.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-net-drivers@amd.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Message-ID: References: <20260630-b4-drivers-net-v1-0-672162a91f37@kernel.org> <20260630072344.159b5d99@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260630072344.159b5d99@kernel.org> X-Mailman-Approved-At: Tue, 30 Jun 2026 15:19:08 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782830441; bh=dvgyW8X4QaOk9VN18ZFlTY30npYMh5LShKDCXGOsMxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UaRdoyQZ1fTRKLAcvtRM8pCPos/hNLQhMFDTOXBDrPIVVOLNJRA7cU6ka14RHMRFR qWpfgLvKeAkf3XDjCuN2u6VoExWRrn+k9PHdw1xwsfaFYRW6apiRDH/bzW3S/vPXox NDxnR8QhAiI/zPphXPkt1KolvI83eq3Oxp7pH6P8fycRjVpGLO0mOiNQvzLLw+uZ8w WRnUBYhp2jcwsX+8wxOOiEB4mT754vZ1T4aD/zr4L6UdrtAvPeJdD/EC+QwUvwBkRC yr2g0tFvuReybfsvjS3lYxCtUKPjJPqHyXPEmCx9cYMHhnzg+aQfCesR1JnXw5Gekk GQ0tpKu3Pqrmg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UaRdoyQZ Subject: Re: [Intel-wired-lan] [PATCH net-next 0/8] drivers/net: replace __get_free_pages() with kmalloc() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Jun 30, 2026 at 07:23:44AM -0700, Jakub Kicinski wrote: > On Tue, 30 Jun 2026 13:59:19 +0300 Mike Rapoport (Microsoft) wrote: > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 6 +-- > > drivers/net/ethernet/intel/ice/ice_gnss.c | 5 +- > > drivers/net/ethernet/sfc/mcdi.c | 7 +-- > > drivers/net/ethernet/sfc/siena/mcdi.c | 7 +-- > > drivers/net/wireless/broadcom/b43/debugfs.c | 12 ++--- > > drivers/net/wireless/broadcom/b43legacy/debugfs.c | 11 ++-- > > drivers/net/wireless/marvell/libertas/debugfs.c | 39 ++++++-------- > > drivers/net/wireless/marvell/mwifiex/debugfs.c | 62 ++++++++++------------- > > drivers/net/wireless/ti/wlcore/main.c | 14 +++-- > > You gotta split this, wireless and ethernet go via separate trees. Sure. > BTW cocci also suggests folding in a memset, IDK if it's worth it. Same churn, less lines :) > drivers/net/wireless/broadcom/b43legacy/debugfs.c:217:8-15: WARNING: kzalloc should be used for buf, instead of kmalloc/memset > -- > pw-bot: cr -- Sincerely yours, Mike.