Re: [PATCH v2 05/13] KVM: arm64: Detect (via ACPI) and initialize HACDBSIRQ

[Leonardo Bras <leo.bras@arm.com>]

On Mon, Jun 29, 2026 at 05:52:45PM +0100, Vladimir Murzin wrote:
> Hi,
> 
> On 6/29/26 16:43, Leonardo Bras wrote:
> >>> +	case HACDBSCONS_EL2_ERR_REASON_IPAHACF:
> >>> +		/* When size not a power of two >= 4k, exit with reserved TTLW */
> >>> +		int index = FIELD_GET(HACDBSCONS_EL2_INDEX, cons);
> >> [Severity: Low]
> >> Does this variable declaration cause a build failure?
> > No
> > 
> >> Under standard C rules,
> >> a label can only be attached to a statement, and a declaration is not a
> >> statement.
> > That's not a label.
> 
> I think Sashiko is right
> 
> arch/arm64/kvm/dirty_bit.c: In function 'hacdbsirq_handler':
> arch/arm64/kvm/dirty_bit.c:336:3: error: a label can only be part of a statement and a declaration is not a statement
>   336 |   int index = FIELD_GET(HACDBSCONS_EL2_INDEX, cons);
>       |   ^~~
> make[4]: *** [scripts/Makefile.build:289: arch/arm64/kvm/dirty_bit.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> 
> Based on other threads you might need GCC<=10.5.0 to hit that.
> 
> Obvious fix-up would be to wrap the case into curly braces :)
> 
> Cheers
> Vladimir

Right!
I could finally understand what it meant on a next patch, where it 
explained the issue in a different way. Will add curly braces (or declare 
the variable before, honestly), and this should go.

Thanks!
Leo