All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] spi: dt-bindings: snps,dw-apb-ssi: drop superfluous RZ/N1 entry
Date: Wed, 1 Jul 2026 13:16:58 +0200	[thread overview]
Message-ID: <akT3KiUJccT2bjRn@shikoro> (raw)
In-Reply-To: <b4a42f27-595b-4c02-a792-0e11c306d2ea@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]


> Uh... the compatible is listed twice (!) and you remove it only one
> instance. That's completely missed in the commit msg. Patch is fine, but
> please be explicit that you remove the variant which should be used as
> fallback while leaving the ABI documented.

Okay, I could have used 'duplicated' instead of 'superfluous' to
make this more obvious. Will reword.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-07-01 11:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 18:03 [PATCH v4 0/4] ARM: dts: renesas: r9a06g032-rzn1d400-eb: Enable SPI and FRAM Wolfram Sang
2026-06-26 18:03 ` [PATCH v4 1/4] spi: dt-bindings: snps,dw-apb-ssi: drop superfluous RZ/N1 entry Wolfram Sang
2026-06-29  9:32   ` Geert Uytterhoeven
2026-06-30  6:47   ` Krzysztof Kozlowski
2026-06-30  6:50     ` Krzysztof Kozlowski
2026-07-01 11:16       ` Wolfram Sang [this message]
2026-06-26 18:03 ` [PATCH v4 2/4] spi: dt-bindings: snps,dw-apb-ssi: add 'power-domains' property Wolfram Sang
2026-06-30  6:50   ` Krzysztof Kozlowski
2026-06-30 15:41   ` Geert Uytterhoeven
2026-06-26 18:03 ` [PATCH v4 3/4] ARM: dts: renesas: r9a06g032: Describe SPI controllers Wolfram Sang
2026-06-29 13:23   ` Geert Uytterhoeven
2026-06-26 18:03 ` [PATCH v4 4/4] ARM: dts: renesas: r9a06g032-rzn1d400-eb: Enable SPI-FRAM Wolfram Sang
2026-06-29 13:24   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akT3KiUJccT2bjRn@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.