From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>,
<intel-xe@lists.freedesktop.org>, <ville.syrjala@linux.intel.com>
Subject: Re: [RESEND v2 2/8] drm/i915: call intel_display_power_runtime_resume() on suspend error path
Date: Wed, 1 Jul 2026 15:59:19 -0400 [thread overview]
Message-ID: <akVxl8opQQsPiOSF@intel.com> (raw)
In-Reply-To: <b0c131ed970d16d0147c87ba583abe3a4ea36ed5.1782913901.git.jani.nikula@intel.com>
On Wed, Jul 01, 2026 at 04:53:00PM +0300, Jani Nikula wrote:
> The vlv_suspend_complete() error path fails to call
> intel_display_power_runtime_resume(). Fix it.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index c9ce2b05b787..10427f8f5699 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -1523,6 +1523,8 @@ static int i915_pm_runtime_suspend(struct device *kdev)
> drm_err(&dev_priv->drm,
> "Runtime suspend failed, disabling it (%d)\n", ret);
>
> + intel_display_power_runtime_resume(display);
> +
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> for_each_gt(gt, dev_priv, i)
> intel_uncore_runtime_resume(gt->uncore);
>
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-07-01 19:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 13:52 [RESEND v2 0/8] drm/{i915,xe}: unify runtime pm calls Jani Nikula
2026-07-01 13:52 ` [RESEND v2 1/8] drm/i915: call intel_uncore_runtime_resume() for each gt Jani Nikula
2026-07-01 13:53 ` [RESEND v2 2/8] drm/i915: call intel_display_power_runtime_resume() on suspend error path Jani Nikula
2026-07-01 19:59 ` Rodrigo Vivi [this message]
2026-07-01 13:53 ` [RESEND v2 3/8] drm/i915: move some display runtime suspend operations earlier Jani Nikula
2026-07-01 20:02 ` Rodrigo Vivi
2026-07-01 13:53 ` [RESEND v2 4/8] drm/i915: add intel_display_driver_pm_runtime*() functions Jani Nikula
2026-07-01 13:53 ` [RESEND v2 5/8] drm/{i915, xe}: add new intel_display_driver_runtime_pm_{enable, disable}() Jani Nikula
2026-07-01 13:53 ` [RESEND v2 6/8] drm/xe/display: separate d3cold handling from xe_display_pm_runtime_suspend_late() Jani Nikula
2026-07-01 13:53 ` [RESEND v2 7/8] drm/xe/display: add xe_display_pm_runtime_resume_early() Jani Nikula
2026-07-02 7:14 ` [PATCH v2] " Jani Nikula
2026-07-01 13:53 ` [RESEND v2 8/8] drm/xe/display: unify runtime suspend/resume with i915 for non-d3cold Jani Nikula
2026-07-01 15:36 ` ✗ CI.KUnit: failure for drm/{i915,xe}: unify runtime pm calls (rev3) Patchwork
2026-07-02 1:24 ` ✓ i915.CI.BAT: success " Patchwork
2026-07-02 7:22 ` ✓ CI.KUnit: success for drm/{i915,xe}: unify runtime pm calls (rev4) Patchwork
2026-07-02 8:27 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-02 8:33 ` ✓ i915.CI.BAT: " Patchwork
2026-07-03 0:10 ` ✗ i915.CI.Full: failure " Patchwork
2026-07-03 1:13 ` ✓ Xe.CI.FULL: success " Patchwork
2026-07-03 10:22 ` [RESEND v2 0/8] drm/{i915,xe}: unify runtime pm calls Ville Syrjälä
2026-07-03 12:36 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akVxl8opQQsPiOSF@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.