From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C79511DED42 for ; Thu, 2 Jul 2026 00:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782952789; cv=none; b=Xor8tAsdIhIL94hyWQYXzpj6FvMrRn9hMi+NkJT6UoGoXesdnopOA2Es+rTXkG4M3H1kDi7pM3x2jNbJsI8NxiMi/iWAC1rFoEq3k8afkO4wzelL1EdRHdpvvFUKihQGwLfB+w5WL+Udd7J3RVMibq7Lmt9A5sexLripS1Skezo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782952789; c=relaxed/simple; bh=/UDg494+A5wqlPKyqoMSGUGZRODmxUILpjXaS4fVzSQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OrVScTr0PdQZ3bbU63JhW+yMoCGJts/P1d5UVZe98LINpNH81iMXs9A/Ns5zKlKMu629bH5gjc8K78UuL6TTh3joPqLx0qoDZ/2X6IjDWNSWktyv4lET+18CL3kaUj3sCtMzycnZ0zBiB8GkUY/seo4qUiEKi0jhq6ipVLclb7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=f95QpcX5; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="f95QpcX5" Date: Wed, 1 Jul 2026 17:39:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782952785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xq5IFCzyt5R8lQ/9ROwnUgxzKEJmz2V3b6w6NYiK2h0=; b=f95QpcX5g3yONNwfqTVb1ZC3yoVoVfRuIRDqPXIvO0kgeoBfZtm6IABCYI8mxU4DIdcLbu ZXu0L1nxQCZ/i+muuv7LHBDEAGink6Im1OKOXSGzBLAOTT9/Y3GkrOnIXUDuP6WS13hRzD G9JCwNk9YfD30hMuvWjJ7HcCEWA8eW8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Johannes Weiner Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Zi Yan , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm: page_alloc: __GFP_FS lockdep annotation for direct compaction Message-ID: References: <20260626182215.1107966-1-hannes@cmpxchg.org> <20260626182215.1107966-2-hannes@cmpxchg.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260626182215.1107966-2-hannes@cmpxchg.org> X-Migadu-Flow: FLOW_OUT On Fri, Jun 26, 2026 at 02:21:17PM -0400, Johannes Weiner wrote: > A subsequent patch will have some order-0 allocations participate in > compaction under defrag_mode, to stave off extfrag events. > > Since this is a sprawling expansion of entry points, and compaction > can enter filesystem paths, add lockdep annotations that catches > __GFP_FS passing errors. > > Direct reclaim has had this annotation for a while, and since reclaim > and compaction are usually used in conjunction, this is unlikely to > unearth old bugs. It's more about future proofing and peace of mind. > > Signed-off-by: Johannes Weiner Acked-by: Shakeel Butt