From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCC135AC1C for ; Thu, 2 Jul 2026 08:53:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782982431; cv=none; b=fDsFzN5B7AKUUn873hyduPfrH0OsKgghcoEWk5F7VUljydOSqZ2oNoIvs+6qyStdxAYpsYNTVO5rFjJWoyEFxCQ2O13LwrDt7uLCFqL+YFzY0k67DqrQ/whsiBNsQlS9vCCNW8bWjL222PPnboe8UE1XpkXyPRdV+P34nsXG8HI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782982431; c=relaxed/simple; bh=rov0SKtp0WCrSeUtguI5KKAUut3DCO+J4TuhaZONMYg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F75gjJfiVs7BB3/Zdss6vFAkCoyQ48buxXj+XuMOPB1N9FMfGPsRsh6T2g/VaDgcEuGjSx2jK2oH7soBahyitKR9ObEEiSqscP1MjyKU/Hq6iDkL+YwvMsqf3fI45IK+TGNKkv1rGQqLiYnNhDMXuvIu1zCj3zUOxLjlqRpudDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gppB/Qzm; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gppB/Qzm" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b7612475so12271625e9.3 for ; Thu, 02 Jul 2026 01:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1782982429; x=1783587229; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IHxRFl9zIjTGoNOfS7dr/1CZ2RxtO6RDzq3aysrtq3Y=; b=gppB/Qzmvyh1Nk7lomYLKEOuEiYURBgPcFpcWMmKLBjiJJRQhYjp9JcANCHaL9SvST /j0zhTM6vaNIiUhWp21k6FPE5DMEUroPT76pBWXxflV8Eld364G4RYnRvbQeNUc5TZat iYUGgrPHuzLDTyQgPTMTOFt/T1yJ47baEfYcjLQ9uNXKBtJfMlqcoKSCNvmD0nRc7eon +5SZZzI9QugAYAPl+YIDCiAmIBk0tHmNpVhZeLOBNqWieWk9j2T1n6MHg+LobrEzacmF 4Te548C7p0coBytfn6V7rwq37AEbflG1HcZoX1NkJkR6LPqDpyd76y/bpHLBPWXRu/dQ n1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782982429; x=1783587229; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IHxRFl9zIjTGoNOfS7dr/1CZ2RxtO6RDzq3aysrtq3Y=; b=hmZGsxhtk6megE/CsLRRGlYRDGbMhxe8kV99y8TqWXr4WB4Pc6uQbavAOqbM0BIlKe k+xlBqCmlACogPN5OkteCCgvbzqGvlP7BGlnnUdmOtHTC3VCzN1uj0P3Eqg4UZRdV2pE 9dOumlDSLWRUIKlkXmWQh+g7UDHWp8ZDKsgK1r2HE3R+Goj5hnsNwGwonHEeXHEQmXlO W9SQmUtsb0eDqSQQQVWYIpDC6jW8RW2PFzHfB/lXheBLJYaNuf2egekKItBv3zNPGL2Q m+Qe13FB88kBmM1iARlHxAVgBIMXQw5+KL0X/Ix7dFpkvLPUcAcQgNpvU/KmlxnmX1ql eKJQ== X-Forwarded-Encrypted: i=1; AFNElJ/Gtm64epHJDmC0nTgmDEuEH8+3okm2avCEmcra6H8e9uLVj86k4A2DvnUS9A45qMRjlPOmUEYE7ngJ2CI=@vger.kernel.org X-Gm-Message-State: AOJu0YxhfdiBYRWl3citS/IvoeGezUJTB5updT8ujUv5K/2bvIFm8tIZ 1xIeo5RQ8SmC1OeqMQbT1ryjkEEMDS6SxO2fWpBGMre7AimDybwidOC/FBhNP/c0Xmg= X-Gm-Gg: AfdE7clYlxS6eKOMkwseSOoJ7t5Ou4DAAT76s7ASQRIiX+jupTGSTUibBid8ezvqbuC s/7faYDxPboQjoLMs94OTMAbiYVgEm4rr8/R4TvI0M4zNtocDMk/FMqZKbycwnBqdJXMQ84+KrM 7L2XsaGQU2Mv3yooOlPoTfwouX6B8Rw8BEWDDE0bP6WLTBhZzLvpW49LRlKCsvR5VZ18fUOja2f JU0MlG34POqynvOKQtduRVaq6C7+dRH3nrYnHClZHy4mkpYFTeA63yhKdRJIevRS5H2b83apK0k v8bAIzEUxxuNAL+WvcWQDXYQLYZIPHBgRg8ZEVJ5/bzkS05sgFRalLJBb7E/5wxQetFTK6T/Q8P 5M14Rs9bguEOvZ3HInj+qTg252mKxTWOGdQZbnGMhOhz/E30EkPQHgLsEciSHCy7ysbhneNFoWg bN6ERlgujE0oBKNk8= X-Received: by 2002:a05:600c:c3cc:20b0:493:bd03:c0d9 with SMTP id 5b1f17b1804b1-493c2b38ea9mr55340275e9.7.1782982428873; Thu, 02 Jul 2026 01:53:48 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c636ec8asm26652265e9.1.2026.07.02.01.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:53:48 -0700 (PDT) Date: Thu, 2 Jul 2026 10:53:46 +0200 From: Petr Mladek To: Shihao Ren Cc: jpoimboe@kernel.org, jikos@kernel.org, mbenes@suse.cz, joe.lawrence@redhat.com, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch/klp-build: Fix wrong index in error cleanup loop Message-ID: References: <20260701060655.2343093-1-rsh15355756202@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260701060655.2343093-1-rsh15355756202@163.com> On Wed 2026-07-01 14:06:55, Shihao Ren wrote: > In the funcs allocation failure path, the cleanup loop iterates with > 'j' but frees objs[i].funcs, which uses the outer loop index 'i' > instead of the loop variable 'j'. As a result the just-failed (NULL) > entry is freed repeatedly, while the funcs buffers already allocated > for objs[0..i-1] are leaked. > > Use objs[j].funcs so the previously allocated entries are correctly > released. > > Fixes: 59adee07b568 ("livepatch/klp-build: Add stub init code for livepatch modules") > Signed-off-by: Shihao Ren Great catch! Reviewed-by: Petr Mladek I assume that Josh would take this together with other klp-build related changes. Best Regards, Petr