From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Weiming Shi <bestswngs@gmail.com>,
linux-xfs@vger.kernel.org, Carlos Maiolino <cem@kernel.org>,
Brian Foster <bfoster@redhat.com>,
Christoph Hellwig <hch@infradead.org>, Xiang Mei <xmei5@asu.edu>
Subject: Re: [PATCH v2 3/3] xfs: fail recovery on a committed log item with no regions
Date: Thu, 2 Jul 2026 03:56:51 -0700 [thread overview]
Message-ID: <akZD87nbm6q0KXrP@infradead.org> (raw)
In-Reply-To: <20260701220838.GI6526@frogsfrogsfrogs>
On Wed, Jul 01, 2026 at 03:08:38PM -0700, Darrick J. Wong wrote:
> I agree that a totally empty log item is a sign of corruption, or at
> least something going seriously wrong. Can the runtime log code ever be
> tricked into emitting a bare transaction header?
I don't think so. This looks like an automated search for bugs in the
parser. And while I'm happy about tightening up all parsing, I still
think this should be stated in the commit log much more clearly.
next prev parent reply other threads:[~2026-07-02 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 15:38 [PATCH v2 0/3] xfs: fix NULL deref in log recovery reorder Weiming Shi
2026-07-01 15:38 ` [PATCH v2 1/3] xfs: drop ASSERT(0) on unrecognized log item type Weiming Shi
2026-07-01 21:41 ` Darrick J. Wong
2026-07-02 10:54 ` Christoph Hellwig
2026-07-01 15:38 ` [PATCH v2 2/3] xfs: splice unsorted log items back to the transaction after the loop Weiming Shi
2026-07-01 21:43 ` Darrick J. Wong
2026-07-02 10:55 ` Christoph Hellwig
2026-07-01 15:38 ` [PATCH v2 3/3] xfs: fail recovery on a committed log item with no regions Weiming Shi
2026-07-01 22:08 ` Darrick J. Wong
2026-07-02 10:56 ` Christoph Hellwig [this message]
2026-07-02 15:32 ` Darrick J. Wong
2026-07-02 16:13 ` Weiming Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akZD87nbm6q0KXrP@infradead.org \
--to=hch@infradead.org \
--cc=bestswngs@gmail.com \
--cc=bfoster@redhat.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=xmei5@asu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.