Re: [PATCH v3 2/2] tracing: Remove trace_printk.h from kernel.h

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 4294 bytes --]

Hello,

On Wed, Jun 24, 2026 at 04:18:08AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> There have been complaints about trace_printk.h causing more build time
> for being in kernel.h. Move it out of kernel.h and place it in the headers
> and C files that use it.
> 
> Link: https://lore.kernel.org/all/CAHk-=wikCBeVFjVXiY4o-oepdbjAoir5+TcAgtL12c4u1TpZLQ@mail.gmail.com/
> 
> Suggested-by: Yury Norov <yury.norov@gmail.com>
> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

This patch became commit 9cbc3d9806d3 ("tracing: Remove trace_printk.h
from kernel.h") that currently is in next via

	https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git trace/fixes

.

It creates a build regression for an ARCH=arc allmodconfig build:

	  CC      lib/test_context-analysis.o
	In file included from include/linux/local_lock_internal.h:8,
			 from include/linux/local_lock.h:5,
			 from lib/test_context-analysis.c:9:
	include/linux/local_lock_internal.h: In function ‘local_lock_acquire’:
	include/linux/lockdep.h:541:87: error: ‘_THIS_IP_’ undeclared (first use in this function)
	  541 | l)                     lock_acquire_exclusive(l, 0, 0, NULL, _THIS_IP_)
	      |                                                              ^~~~~~~~~
	include/linux/lockdep.h:509:88: note: in definition of macro ‘lock_acquire_exclusive’
	  509 | re_exclusive(l, s, t, n, i)           lock_acquire(l, s, t, 0, 1, n, i)
	      |                                                                      ^
	include/linux/local_lock_internal.h:46:9: note: in expansion of macro ‘lock_map_acquire’
	   46 |         lock_map_acquire(&l->dep_map);
	      |         ^~~~~~~~~~~~~~~~
	include/linux/lockdep.h:541:87: note: each undeclared identifier is reported only once for each function it appears in
	  541 | l)                     lock_acquire_exclusive(l, 0, 0, NULL, _THIS_IP_)
	      |                                                              ^~~~~~~~~
	include/linux/lockdep.h:509:88: note: in definition of macro ‘lock_acquire_exclusive’
	  509 | re_exclusive(l, s, t, n, i)           lock_acquire(l, s, t, 0, 1, n, i)
	      |                                                                      ^
	include/linux/local_lock_internal.h:46:9: note: in expansion of macro ‘lock_map_acquire’
	   46 |         lock_map_acquire(&l->dep_map);
	      |         ^~~~~~~~~~~~~~~~
	include/linux/local_lock_internal.h: In function ‘local_trylock_acquire’:
	include/linux/lockdep.h:542:87: error: ‘_THIS_IP_’ undeclared (first use in this function)
	  542 | try(l)                 lock_acquire_exclusive(l, 0, 1, NULL, _THIS_IP_)
	      |                                                              ^~~~~~~~~
	include/linux/lockdep.h:509:88: note: in definition of macro ‘lock_acquire_exclusive’
	  509 | re_exclusive(l, s, t, n, i)           lock_acquire(l, s, t, 0, 1, n, i)
	      |                                                                      ^
	include/linux/local_lock_internal.h:53:9: note: in expansion of macro ‘lock_map_acquire_try’
	   53 |         lock_map_acquire_try(&l->dep_map);
	      |         ^~~~~~~~~~~~~~~~~~~~
	include/linux/local_lock_internal.h: In function ‘local_lock_release’:
	include/linux/lockdep.h:545:65: error: ‘_THIS_IP_’ undeclared (first use in this function)
	  545 | fine lock_map_release(l)                     lock_release(l, _THIS_IP_)
	      |                                                              ^~~~~~~~~
	include/linux/local_lock_internal.h:62:9: note: in expansion of macro ‘lock_map_release’
	   62 |         lock_map_release(&l->dep_map);
	      |         ^~~~~~~~~~~~~~~~
	make[5]: *** [scripts/Makefile.build:289: lib/test_context-analysis.o] Error 1
	make[4]: *** [scripts/Makefile.build:549: lib] Error 2
	make[3]: *** [Makefile:2184: .] Error 2
	make[2]: *** [Makefile:372: __build_one_by_one] Error 2
	make[1]: *** [Makefile:248: __sub-make] Error 2
	make[1]: Leaving directory '/home/uwe/work/kbuild/arc'
	make: *** [Makefile:248: __sub-make] Error 2

#regzbot introduced: 9cbc3d9806d3

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]