Re: [PATCH v7 2/8] media: subdev: Add media_async_register_subdev() helper

[Frank Li <Frank.li@oss.nxp.com>]

On Thu, Jul 02, 2026 at 09:19:20PM +0300, Laurent Pinchart wrote:
> On Thu, Jul 02, 2026 at 01:11:03PM -0500, Frank Li wrote:
> > On Thu, Jul 02, 2026 at 07:15:19PM +0300, Laurent Pinchart wrote:
> > > Hi Frank,
> > >
> > > Have you missed the comment in v6 ?
> > >
> > > https://lore.kernel.org/all/20260629084654.GB3054459@killaraus.ideasonboard.com/
> >
> > Sorry, I forget emphased it in change log.
> >
> > "For the reason stated by Sakari in patch 1/9 (dependency from MC to
> > V4L2), I don't think a "media_async_register_subdev()" function is a
> > good idea."
> >
> > The reason already NOT existed in v7, I removed v4l2_fwnode_endpoint from
> > media_pad. So MC will not depdent to V4L2.
> >
> > So this comments is not suit for this version.
>
> media_async_register_subdev(), with its "media_" prefix, appears part of
> the MC API, but it operates on a subdev. At least the function name
> should be changed in my opinion.

Name is easy to fix. The key is if the overall direction and method is
good enough to go futher.

Optional naming here

v4l2_async_register_subdev_with_created_pad()
v4l2_create_pad_and_async_register_subdev()
v4l2_async_register_subdev_from_fw_ports()
...

Frank

>
> --
> Regards,
>
> Laurent Pinchart