From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 640B4C43458 for ; Thu, 2 Jul 2026 16:31:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EAC5F10F4ED; Thu, 2 Jul 2026 16:31:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FTJm75v6"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD13510F4E3; Thu, 2 Jul 2026 16:31:47 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6EC6943A8D; Thu, 2 Jul 2026 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5261F00A3A; Thu, 2 Jul 2026 16:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783009907; bh=E1qWf++P4fQTxTfdt1w7bxV4tlwl6MwcbrDidejiQ/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=FTJm75v6g78dw7nc2yIjeNrtd/XXU46WO/2u8nnziEKlJYchAWQ9hGEChgT4F31ah HiH5xTUbuFOhBbd6C1duQ+RhK7b4oHictxqHPOAi/lrzXWZ0FTN2EDGOuyFEWt0mD1 vjw0IUs1vrHYSMCjr+3zzHxShdi1SoTmUIrBx0H0nw1oUHkfV6THw+nOZBnbM1ksv+ +IgzClZgoCati852KoF+eqgYzFxCjgh+OL3JRZibavJHQwCUYoiGfhSnInQcjeQExX M1Tr3eyxRp2MXQhzrXdgxW+NoNc9BMVcJx67MLhqeaR6Vs6Z2WBP6mhtT0mJnysYek vPOd4U2WlHy2g== Date: Thu, 2 Jul 2026 17:31:24 +0100 From: Lorenzo Stoakes To: Lance Yang Cc: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, lyude@redhat.com, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, jonathanh@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Message-ID: References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> <20260702134947.25189-1-lance.yang@linux.dev> <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 03, 2026 at 12:17:29AM +0800, Lance Yang wrote: > > > On 2026/7/3 00:07, Lorenzo Stoakes wrote: > > On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote: > > > > > > On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: > > > > Replace use of the legacy vm_flags_t flags with vma_flags_t values > > > > throughout the mremap logic. > > > > > > > > Additionally update comments to reflect the changes to be consistent. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > --- > > > > > > The vm_flags_set() cases below spell out vma_start_write(), but the > > > vm_flags_clear() cases don't? > > > > Yep as I said elsewhere, implicitly taking the lock is terrible and me doing > > this is completely on purpose to get rid of that :) > > > > But I haven't been clear enough clearly, so I should put the argument as to why > > that's ok in the commit message. > > > > Will do so on respin. > > Makes sense, thanks for spelling it out! A short changelog note > should clear it up for me :D Yeah absolutely, that's necessary and was an oversight on my part, will correct! Thanks for your great review here, much appreciated! :) > > [...] Cheers, Lorenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF6B4C44500 for ; Thu, 2 Jul 2026 16:31:52 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4440D10F4F9; Thu, 2 Jul 2026 16:31:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="FTJm75v6"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 6AF7546E95; Thu, 2 Jul 2026 16:17:04 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1783009024; b=g7/ivfVT9zWnESBv/r7kQdTwkX1VDZuo955VJkNw2d7TtRAhqprtLBproVLyMA0l4hy54 7F7LIW2n8cPRbFaRNVW85A6HAttlLjAlxXvGugWPAlkXr5ENqwT/F5s8gW50cIkaegaDFFu LOp4+Xni8sJzQ/oPay5oGNoS5Qh2WVVFKk190PtlYIxD+YgQ5eNMd8Ygf8wUgjZm0pQEbCi ir7Rk0tgJ3KvCsMd25eVWbgxeyXH3Azcp9LAsvP7RA+5yfPRzFqmK/AyM+3wehtwJ0ZSne3 gTZzllSy8shLZqjd5NkuQKhtwEv2ycxFl3fIyuhlRXjGsPQ8d4aiQGormHgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1783009024; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=E1qWf++P4fQTxTfdt1w7bxV4tlwl6MwcbrDidejiQ/c=; b=mciLzWboen3frtGFHVcWqUZKlAHiHTjcXlzyb0qEPnftL/tKVwk/pdzE6Encng6FriE2l G6Cxea6ivM5T1TX7SivlPha1CZsCpUhjU/c3KF2u9j0gDcljz0V9NeF6j98KoSFhxOgNFHK toKd/xucqGWSHw36QutPjucHzGB1VJOAis/YBGlh93jGbIb/3+DSbiDYM3nCIaIu+PQuN0v cImvsGfCD89vr/cbBk+n9epDIwE5Yxh/eZAHCBb6JVejJWxGAqpBMMu0/DxBkEMR3XgGhjK p7ByOuy+n2gawGbmJ4yXN7lWxI1WjDlty+ssqUz9FBSWfxNJrRhmBN2SQ3rA== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Authentication-Results: mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 474AA46E38 for ; Thu, 2 Jul 2026 16:17:01 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD13510F4E3; Thu, 2 Jul 2026 16:31:47 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6EC6943A8D; Thu, 2 Jul 2026 16:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D5261F00A3A; Thu, 2 Jul 2026 16:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783009907; bh=E1qWf++P4fQTxTfdt1w7bxV4tlwl6MwcbrDidejiQ/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=FTJm75v6g78dw7nc2yIjeNrtd/XXU46WO/2u8nnziEKlJYchAWQ9hGEChgT4F31ah HiH5xTUbuFOhBbd6C1duQ+RhK7b4oHictxqHPOAi/lrzXWZ0FTN2EDGOuyFEWt0mD1 vjw0IUs1vrHYSMCjr+3zzHxShdi1SoTmUIrBx0H0nw1oUHkfV6THw+nOZBnbM1ksv+ +IgzClZgoCati852KoF+eqgYzFxCjgh+OL3JRZibavJHQwCUYoiGfhSnInQcjeQExX M1Tr3eyxRp2MXQhzrXdgxW+NoNc9BMVcJx67MLhqeaR6Vs6Z2WBP6mhtT0mJnysYek vPOd4U2WlHy2g== Date: Thu, 2 Jul 2026 17:31:24 +0100 From: Lorenzo Stoakes To: Lance Yang Subject: Re: [PATCH 13/13] mm/mremap: convert mremap code to use vma_flags_t Message-ID: References: <380f761d35a3faa4370f8b3f92e3d4af3d4c7110.1782760670.git.ljs@kernel.org> <20260702134947.25189-1-lance.yang@linux.dev> <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f36a2da-0686-485f-b4b9-ae699bef4fd4@linux.dev> Message-ID-Hash: NUE6JK3RNXXTEFXHGSDOJXCRBU4YI5X2 X-Message-ID-Hash: NUE6JK3RNXXTEFXHGSDOJXCRBU4YI5X2 X-MailFrom: ljs@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: akpm@linux-foundation.org, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, maarten.lankhorst@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, l.stach@pengutronix.de, inki.dae@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, krzk@kernel.org, peter.griffin@linaro.org, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, robin.clark@oss.qualcomm.com, lumag@kernel.org, dakr@kernel.org, tomi.valkeinen@ideasonboard.com, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, thierry.reding@kernel.org, mperttunen@nvidia.com, kraxel@redhat.com, dmitry.osipenko@collabora.com, zack.rusin@broadcom.com, matthew.brost@intel.com, thomas.hellstrom@linux.intel.com, oleksandr_andrushchenko@epam.com, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, brauner@kernel.org, muchun.song@linux.dev, osalvador@suse.de, david@kernel.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, hughd@google.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, jannh@google.com, pfalcato@suse.de, kees@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-fbdev@vger.kernel.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, Jul 03, 2026 at 12:17:29AM +0800, Lance Yang wrote: > > > On 2026/7/3 00:07, Lorenzo Stoakes wrote: > > On Thu, Jul 02, 2026 at 09:49:47PM +0800, Lance Yang wrote: > > > > > > On Mon, Jun 29, 2026 at 08:25:36PM +0100, Lorenzo Stoakes wrote: > > > > Replace use of the legacy vm_flags_t flags with vma_flags_t values > > > > throughout the mremap logic. > > > > > > > > Additionally update comments to reflect the changes to be consistent. > > > > > > > > No functional change intended. > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > --- > > > > > > The vm_flags_set() cases below spell out vma_start_write(), but the > > > vm_flags_clear() cases don't? > > > > Yep as I said elsewhere, implicitly taking the lock is terrible and me doing > > this is completely on purpose to get rid of that :) > > > > But I haven't been clear enough clearly, so I should put the argument as to why > > that's ok in the commit message. > > > > Will do so on respin. > > Makes sense, thanks for spelling it out! A short changelog note > should clear it up for me :D Yeah absolutely, that's necessary and was an oversight on my part, will correct! Thanks for your great review here, much appreciated! :) > > [...] Cheers, Lorenzo