From: Nicolas Bouchinet <nicolas.bouchinet@oss.cyber.gouv.fr>
To: Paul Moore <paul@paul-moore.com>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>,
Cai Xinchen <caixinchen1@huawei.com>,
jmorris@namei.org, serge@hallyn.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] lockdown: Add break in lockdown_write
Date: Fri, 3 Jul 2026 07:39:20 +0000 [thread overview]
Message-ID: <akdjuyJ7tGefNNUW@archlinux> (raw)
In-Reply-To: <CAHC9VhTQT05+1qYM-8_YTc84Rx2SdZV1iRixeqAywCXf1mMddQ@mail.gmail.com>
On Thu, Jul 02, 2026 at 12:50:18PM -0400, Paul Moore wrote:
> On Thu, Jan 22, 2026 at 12:41???PM Paul Moore <paul@paul-moore.com> wrote:
> >
> > On Thu, Jan 22, 2026 at 4:31???AM Xiu Jianfeng <xiujianfeng@huawei.com> wrote:
> > > On 1/19/2026 5:12 PM, Cai Xinchen wrote:
> > > > After the label is matched successful, any other levels judgements
> > > > are meaningless. Therefore, add break to return early
> > > >
> > > > Signed-off-by: Cai Xinchen <caixinchen1@huawei.com>
> > >
> > > Looks good to me, thanks.
> > >
> > > Acked-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> > >
> > > Paul,
> > >
> > > Would you mind if this patch went through the LSM tree? :)
> >
> > Assuming Nicolas is okay with that, I can take this through the LSM tree.
>
> Following up on this as I never saw a response on-list and the patch
> doesn't appear to be in Linus' tree.
Your right, my bad,
First of all, thanks Cai for your contribution and I appologize for the
really late reply.
This is pretty much the same kind of patch as [1], while it effectively
cleans up Lockdown code, in my opinion it doesn't directly add much. I'd
personally prefer to keep those small patches on hold for now, waiting
for a bigger review of Lockdown's code where I will pick them both up.
Sadly, I really don't have much time to work on this right now.
Nicolas
---
[1]: https://lore.kernel.org/all/20260501174448.47154-1-kalevi@kolttonen.fi/
prev parent reply other threads:[~2026-07-03 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 9:12 [PATCH -next] lockdown: Add break in lockdown_write Cai Xinchen
2026-01-22 9:31 ` Xiu Jianfeng
2026-01-22 17:41 ` Paul Moore
2026-07-02 16:50 ` Paul Moore
2026-07-03 7:39 ` Nicolas Bouchinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akdjuyJ7tGefNNUW@archlinux \
--to=nicolas.bouchinet@oss.cyber.gouv.fr \
--cc=caixinchen1@huawei.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.