From: Jiri Olsa <olsajiri@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCHv6 03/13] uprobes/x86: Do not leak trampoline vma mapping on optimization failure
Date: Fri, 3 Jul 2026 16:11:26 +0200 [thread overview]
Message-ID: <akfDDundFgxkIt9j@krava> (raw)
In-Reply-To: <20260703124503.GP751831@noisy.programming.kicks-ass.net>
On Fri, Jul 03, 2026 at 02:45:03PM +0200, Peter Zijlstra wrote:
> On Fri, Jul 03, 2026 at 01:49:07PM +0200, Jiri Olsa wrote:
> > In case the optimization fails, we leak new-ly created trampoline
> > vma mapping (in case we just created it), let's unmap it.
> >
> > Fixes: ba2bfc97b462 ("uprobes/x86: Add support to optimize uprobes")
> > Reviewed-by: Oleg Nesterov <oleg@redhat.com>
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> What is the intention here? That is, Patch 1 has a Fixes and is already
> in tip/perf/urgent (from v5), patch 2 does not have Fixes, this patch
> (3) has Fixes and appears to rely on patch 2.
>
> So should I stick both 2,3 into perf/urgent or what?
patch 3 fixes the vma mapping leak, and it is done on top
of bigger change in patch 2
I think we are ok without patch 3 in perf/urgent, but if we
want to have it there, it needs patch 2
jirka
next prev parent reply other threads:[~2026-07-03 14:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 11:49 [PATCHv6 00/13] uprobes/x86: Fix red zone issue for optimized uprobes Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 01/13] uprobes/x86: Use proper mm_struct in __in_uprobe_trampoline Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 02/13] uprobes/x86: Remove struct uprobe_trampoline object Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 03/13] uprobes/x86: Do not leak trampoline vma mapping on optimization failure Jiri Olsa
2026-07-03 12:32 ` bot+bpf-ci
2026-07-03 12:45 ` Peter Zijlstra
2026-07-03 14:11 ` Jiri Olsa [this message]
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 04/13] uprobes/x86: Allow to copy uprobe trampolines on fork Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 05/13] uprobes/x86: Move optimized uprobe from nop5 to nop10 Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 06/13] libbpf: Change has_nop_combo to work on top of nop10 Jiri Olsa
2026-07-03 12:00 ` sashiko-bot
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 8:58 ` Ingo Molnar
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 07/13] libbpf: Detect uprobe syscall with new error Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 8:57 ` Ingo Molnar
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 08/13] selftests/bpf: Emit nop,nop10 instructions combo for x86_64 arch Jiri Olsa
2026-07-03 12:03 ` sashiko-bot
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 09/13] selftests/bpf: Change uprobe syscall tests to use nop10 Jiri Olsa
2026-07-03 12:00 ` sashiko-bot
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 10/13] selftests/bpf: Change uprobe/usdt trigger bench code " Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 11/13] selftests/bpf: Add reattach tests for uprobe syscall Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
2026-07-03 11:49 ` [PATCHv6 12/13] selftests/bpf: Add tests for uprobe nop10 red zone clobbering Jiri Olsa
2026-07-03 14:35 ` [tip: perf/core] " tip-bot2 for Andrii Nakryiko
2026-07-04 9:00 ` tip-bot2 for Andrii Nakryiko
2026-07-03 11:49 ` [PATCHv6 13/13] selftests/bpf: Add tests for forked/cloned optimized uprobes Jiri Olsa
2026-07-03 14:34 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2026-07-04 9:00 ` tip-bot2 for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akfDDundFgxkIt9j@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.