From: Breno Leitao <leitao@debian.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
oleg@redhat.com, mjguzik@gmail.com, josh@joshtriplett.org,
Jan Kara <jack@suse.cz>,
jlayton@kernel.org, axboe@kernel.dk, shakeel.butt@linux.dev,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH RFC 0/4] fs/pipe: unify the page pools into a single per-pipe pool
Date: Fri, 3 Jul 2026 08:27:51 -0700 [thread overview]
Message-ID: <akfO2bPFWLBLuqwG@gmail.com> (raw)
In-Reply-To: <20260703-dutzend-endabrechnung-mensaessen-1e020014ecba@brauner>
Hello Christian,
On Fri, Jul 03, 2026 at 12:19:50PM +0200, Christian Brauner wrote:
> On 2026-06-26 03:26 -0700, Breno Leitao wrote:
> > TL;DR: This simplifies the pipe code, unify the page pools, reduce the
> > code by 11 lines, and improves the microbenchmark by up to 23% — so it's
> > probably wrong (!?).
> >
> > Summary:
> > =======
> >
> > I've spent some time converging tmp_page[] and the on-stack
> > anon_pipe_prealloc pool of pages into a single per-pipe pool, as
> > discussed previously in a few places, most recently at:
> >
> > https://lore.kernel.org/all/ajLA_zxsYyKISkwp@redhat.com/
>
> I think this makes sense. Sashiko has some comments on missing trim for
> readers you might want to consider.
Thanks for looking at it.
Agreed, we want to trim on the reader side as well, otherwise we might
end up with more than 2 (current default) pages in the pipe structure.
I will update this RFC and resend as a v2.
--breno
prev parent reply other threads:[~2026-07-03 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 10:26 [PATCH RFC 0/4] fs/pipe: unify the page pools into a single per-pipe pool Breno Leitao
2026-06-26 10:26 ` [PATCH RFC 1/4] fs/pipe: make the prealloc pool per-pipe infrastructure Breno Leitao
2026-06-26 10:26 ` [PATCH RFC 2/4] fs/pipe: add per-pipe pool push, prefill and trim helpers Breno Leitao
2026-06-26 10:26 ` [PATCH RFC 3/4] fs/pipe: switch the write path to the per-pipe pool Breno Leitao
2026-06-26 10:26 ` [PATCH RFC 4/4] fs/pipe: remove the old on-stack prealloc helpers and tmp_page[2] Breno Leitao
2026-07-03 10:19 ` [PATCH RFC 0/4] fs/pipe: unify the page pools into a single per-pipe pool Christian Brauner
2026-07-03 15:27 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akfO2bPFWLBLuqwG@gmail.com \
--to=leitao@debian.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josh@joshtriplett.org \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=oleg@redhat.com \
--cc=shakeel.butt@linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.