From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B685433E89;
	Sat,  4 Jul 2026 08:57:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1783155477; cv=none; b=qh57KQa6NQwxJkwdTuFheJ8280Hfl0M3cIJBtD44IBq8HNgr2E/UGwf1y5SRo8DyanhM8+GHfHN0j5j8eISnhYjWop77H7zZuY1zHMC+agi81GMdWtbVhh/lOis9ixExnCARWzpeegGS+8LIfETNqyq/hjt9ztycZsgxNvCAVzE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1783155477; c=relaxed/simple;
	bh=DnEVI0KCyvLEwiBnzbDtN2BCV4wQQ92H0sFsPiP9GeU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=mPQKXRiNPhdnu9j4+AoV9grxNCvyxopu1IlWKwrGO3hEQtTlUnDc6kVec9gMKlzCVmoJoxry+IDfZ1YJsLWCZI0l0tsmBmPzUbkPCPiMyo5mhKGlC9a13/zY6UVfqjmW2UuwHbC+enzEVAIw2Hg36zkgVl6ydWQmdKbvMtSGhJU=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PYRvA0RQ; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PYRvA0RQ"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CB761F000E9;
	Sat,  4 Jul 2026 08:57:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1783155475;
	bh=37+tlEUVD85NV0i9UNlUe5kUKVQIq5+czGTtZySsR08=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=PYRvA0RQg+52t+1w0FLLvul0j5UUUpRX5Y0GjruSkZRB3wcKCsToisEcw5bv3un2F
	 xmw2YIliQSQzo6PTTXv5XKo2YZEwGZx0y54yg3FDS0leub2cgygETVKdKYBxGr9Dea
	 Mrc065NmbfpMdpiYCvqDB/+DrDI17XRV1IC71Crp0SdY0yTpAyJaPNfIkMOrpWWCNZ
	 tQFu3GJKTAbEZNng/NbYdRt1LnLLc1hyUWX7kWJYr4VUWkpuVAoJWCKqQ3GUdXXzSS
	 /E3esGtkt/GOA9KVofeSUgicKAkzUxn2ZvaJ9OiCGKuw/iL5v44T580zvd60XuAGJC
	 ryase2WKnXdGw==
Date: Sat, 4 Jul 2026 10:57:51 +0200
From: Ingo Molnar <mingo@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Andrii Nakryiko <andrii@kernel.org>, x86@kernel.org
Subject: Re: [tip: perf/core] libbpf: Detect uprobe syscall with new error
Message-ID: <akjLD5ETJof6sd1j@gmail.com>
References: <20260703114917.238144-8-jolsa@kernel.org>
 <178308930713.3843924.17768600543732799292.tip-bot2@tip-bot2>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <178308930713.3843924.17768600543732799292.tip-bot2@tip-bot2>


* tip-bot2 for Jiri Olsa <tip-bot2@linutronix.de> wrote:

> The following commit has been merged into the perf/core branch of tip:
> 
> Commit-ID:     c450c804b641003e0328e4b2ebf55c05f67e3d08
> Gitweb:        https://git.kernel.org/tip/c450c804b641003e0328e4b2ebf55c05f67e3d08
> Author:        Jiri Olsa <jolsa@kernel.org>
> AuthorDate:    Fri, 03 Jul 2026 13:49:11 +02:00
> Committer:     Peter Zijlstra <peterz@infradead.org>
> CommitterDate: Fri, 03 Jul 2026 16:30:36 +02:00
> 
> libbpf: Detect uprobe syscall with new error
> 
> In the previous optimized uprobe fix we changed the syscall
> error used for its detection from ENXIO to EPROTO.
> 
> Changing related probe_uprobe_syscall detection check.
> 
> Fixes: 05738da0efa1 ("libbpf: Add uprobe syscall feature detection")
> Fixes: af734a7ddb4e ("uprobes/x86: Move optimized uprobe from nop5 to nop10")
> Fixes: 40b54d7e3dab ("uprobes/x86: Move optimized uprobe from nop5 to nop10")
> Fixes: 5c3c59c7952a ("uprobes/x86: Move optimized uprobe from nop5 to nop10")

The last 3 Fixes tags are bogus (just like the triplication itself),
those SHA1's don't exist anymore due to rebases.

I suppose it's meant to be:

  Fixes: 554ba38456da ("uprobes/x86: Move optimized uprobe from nop5 to nop10")

But why are we applying and then fixing later on a regression in
an earlier commit in the same series to begin with??

Anyway, I've fixed up the tag mishaps in a rebase in tip:perf/core,
but can we please not do something like this in the future?

Thanks,

	Ingo