From: Oleg Nesterov <oleg@redhat.com>
To: Bradley Morgan <include@grrlz.net>
Cc: anna-maria@linutronix.de, frederic@kernel.org,
jwlee2217@gmail.com, linux-kernel@vger.kernel.org,
peterz@infradead.org, qw3rtyp0@gmail.com, tglx@linutronix.de
Subject: Re: [PATCH] posix-cpu-timers: don't abuse lock_task_sighand() in handle_posix_cpu_timers()
Date: Sat, 4 Jul 2026 18:42:53 +0200 [thread overview]
Message-ID: <akk4DeHaYiqNktLJ@redhat.com> (raw)
In-Reply-To: <C816BC02-20F2-4E04-98D4-8C145FE1FA3B@grrlz.net>
On 07/04, Bradley Morgan wrote:
>
> Something else I'd like to bring up though, this file has already
> regressed once, 0bdd2ed4138e (dropping the exit_state check)
>
> And then f90fff1e152d re adding it.
>
> Would a WARN_ON_ONCE(tsk != current) be worth adding?
Well may be, up to Thomas...
But note that the problem was not that tsk != current. The problem was
that tsk->sighand could go away after unlock_task_sighand(tsk), even if
tsk == current.
> Reviewed-by: Bradley Morgan <include@grrlz.net>
Thanks,
Oleg.
next prev parent reply other threads:[~2026-07-04 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 11:09 [PATCH] posix-cpu-timers: don't abuse lock_task_sighand() in handle_posix_cpu_timers() Oleg Nesterov
2026-07-04 14:42 ` Bradley Morgan
2026-07-04 16:42 ` Oleg Nesterov [this message]
2026-07-04 17:05 ` Oleg Nesterov
2026-07-04 17:06 ` Bradley Morgan
2026-07-04 17:09 ` Oleg Nesterov
2026-07-05 12:27 ` Bradley Morgan
2026-07-05 10:18 ` [tip: timers/core] posix-cpu-timers: Don't " tip-bot2 for Oleg Nesterov
2026-07-08 20:35 ` [PATCH] posix-cpu-timers: don't " Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akk4DeHaYiqNktLJ@redhat.com \
--to=oleg@redhat.com \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=include@grrlz.net \
--cc=jwlee2217@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qw3rtyp0@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.