From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-06.smtp.spacemail.com (out-06.smtp.spacemail.com [66.29.159.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D170C4207A; Sun, 5 Jul 2026 01:02:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.29.159.77 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783213328; cv=none; b=KWeoYsODK9a0kyomA9oA7JvyYBc5V0T8gd/2OlrWIXCwAcSfqoe7ptjmCBrxSs77VzZDF7Q85mEwJ6iEZKI64pTHgxHmBmstvgZgFORnS02345l7JTKmq0zjCIMFode3kw7TSp82s5jCi+nCgWjntyGPyglMvleK8OYHQX6BjKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783213328; c=relaxed/simple; bh=P3lugvHk1nwzrdTe7G8u/RXPAFOq2rNX03Ue4yK1EdI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UyHFNZfemT/vlp3PLJxCrq+DQZuBicHD6aMh1rONrw0Ltk11SDTmU9SBFrcelcPKOwcNVGldyXBq6rypQr1V4Dx8BmRyTHYFqOtUBFXs7zPVx59vt6YqcrA9YYmruP3P4B97tmWG8SJUIC8EinZNej5M42+7Eieim2P0J8l5WAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gurudas.dev; spf=pass smtp.mailfrom=gurudas.dev; dkim=pass (2048-bit key) header.d=gurudas.dev header.i=@gurudas.dev header.b=gxzDANV1; arc=none smtp.client-ip=66.29.159.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gurudas.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gurudas.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gurudas.dev header.i=@gurudas.dev header.b="gxzDANV1" Received: from gurudas.dev (107-194-158-19.lightspeed.sntcca.sbcglobal.net [107.194.158.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.spacemail.com (Postfix) with ESMTPSA id 4gt8Mn0CXjz6tkM; Sun, 05 Jul 2026 01:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gurudas.dev; s=spacemail; t=1783213318; bh=2qJqLI5cYmY6XssOjT5mS6RQt8tME0zYaMT/RBuKHhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gxzDANV1JQoWbSrlTIw2Hbb83lUzmrjW19c3OZvI3lIFLUx0NWjORGAdcrfZ4Iy1r 8iyC/nftZCN6RsgyVPXhGqT3xB7lKhDTIYvv4mPgt23HneL2vlZdPZGvj5/AKk5Pfp wZfKzZkjQvogs3VONlJW1oADetqYF+Z1IsjAZyW86GXa/ntxYiqBXIBTcI8TBWs5qC 6LphD9AsDF1QQyi7SDc//YsSj4N4PrmToDXekNK0bsPhGwCiGJIgQfdhGPqBLM/i3q aiuUXbswiQh086BPfvu9FQvRyd8BtJCb/XDmrMZaTKsgOjTHbYsMvyE/xBsne6r0RG gHli7e1+IvGdA== Date: Sat, 4 Jul 2026 18:01:55 -0700 From: Guru Das Srinagesh To: Miguel Ojeda Cc: Zhongqiu Han , Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Alice Ryhl , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Rafael J. Wysocki" , Viresh Kumar , Jens Axboe , FUJITA Tomonori , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Airlie , Simona Vetter , driver-core@lists.linux.dev, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/7] cpufreq: rcpufreq_dt: use vertical import style Message-ID: Mail-Followup-To: Miguel Ojeda , Zhongqiu Han , Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Alice Ryhl , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Rafael J. Wysocki" , Viresh Kumar , Jens Axboe , FUJITA Tomonori , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Airlie , Simona Vetter , driver-core@lists.linux.dev, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org References: <20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev> <20260628-b4-rust-vertical-imports-v1-3-98bc71d4810b@gurudas.dev> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Envelope-From: linux@gurudas.dev On Tue, Jun 30, 2026 at 10:35:00AM +0200, Miguel Ojeda wrote: > On Mon, Jun 29, 2026 at 2:43 PM Zhongqiu Han > wrote: > > > > If the preferred style is to place each imported item on its own line, > > shouldn't imports such as > > > > cpu, cpufreq, > > > > be formatted similarly as well? > > Indeed, good eyes. > > To do what we want, `rustfmt` needs the `//` at the end of that level > too (in the future, it will be without the `//`), i.e. the patch > probably passes `rustfmtcheck`, but it still needs to split that line > and add the other `//`. Hi Zhongqiu, Miguel: Yes, I did run `make LLVM=1 rustfmtcheck` and it passed on this series. I will fix the missed ones in v2. While investigating this, I found that that adding this config `imports_layout = "Vertical"` to the rustfmt options would fix all the imports automatically, including the ones I missed. I ran it locally on the files touched in this series using rustfmt nightly and it correctly fixed the imports as desired: rustup run nightly rustfmt --unstable-features \ --config "imports_layout=Vertical" \ --config-path .rustfmt.toml But unfortunately, since `imports_layout` is an unstable option currently [1], it cannot be used straightaway. However, .rustfmt.toml already has a section of commented-out unstable options kept as a reference for when they stabilize. Would it make sense to add `#imports_layout = "Vertical"` there? If so, I can include it in v2. [1]: https://github.com/rust-lang/rustfmt/issues/3361 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20EA1C43458 for ; Sun, 5 Jul 2026 01:02:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lLBiHdTxAmoSt1ykIWIjA4/mAoH8wBSsHnYEzPE5Ayc=; b=GQ7fcbAz8RtxVi Hre0ySQ0lYlI0G9Q+q29930mGnLL+ZpLT90xr/mG/U5oCKVQSWskKU2GIp7KuT18Q1hKR3LCJruW+ ymL1icpmVHdGD3GVW/mfMBDLeeCoFbKsckbvOIMTmB2rClPHO5zLUQLldIXG8AiRp0C7JvXy0kOkl 2PLfmZsvlCZZ6H4QFP3CbGM9BEmyYrYHbrRstjBqYWjef47yi1XubbTlMXZzaYKm6RmWeJSySyLIu mHMTPTUh47ikpK3FPH8Afadhx8Zph67IZYgISP4FBPAQWwxmxoxkRiSw2uY3Xz6/wOlVYfmR2ntef mv+b+5yz5imPZ0m3RtiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgBFF-00000008szG-1xX5; Sun, 05 Jul 2026 01:02:05 +0000 Received: from out-06.smtp.spacemail.com ([66.29.159.77]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgBFC-00000008syq-1zXN for linux-riscv@lists.infradead.org; Sun, 05 Jul 2026 01:02:04 +0000 Received: from gurudas.dev (107-194-158-19.lightspeed.sntcca.sbcglobal.net [107.194.158.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.spacemail.com (Postfix) with ESMTPSA id 4gt8Mn0CXjz6tkM; Sun, 05 Jul 2026 01:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gurudas.dev; s=spacemail; t=1783213318; bh=2qJqLI5cYmY6XssOjT5mS6RQt8tME0zYaMT/RBuKHhI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gxzDANV1JQoWbSrlTIw2Hbb83lUzmrjW19c3OZvI3lIFLUx0NWjORGAdcrfZ4Iy1r 8iyC/nftZCN6RsgyVPXhGqT3xB7lKhDTIYvv4mPgt23HneL2vlZdPZGvj5/AKk5Pfp wZfKzZkjQvogs3VONlJW1oADetqYF+Z1IsjAZyW86GXa/ntxYiqBXIBTcI8TBWs5qC 6LphD9AsDF1QQyi7SDc//YsSj4N4PrmToDXekNK0bsPhGwCiGJIgQfdhGPqBLM/i3q aiuUXbswiQh086BPfvu9FQvRyd8BtJCb/XDmrMZaTKsgOjTHbYsMvyE/xBsne6r0RG gHli7e1+IvGdA== Date: Sat, 4 Jul 2026 18:01:55 -0700 From: Guru Das Srinagesh To: Miguel Ojeda Cc: Zhongqiu Han , Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Alice Ryhl , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Rafael J. Wysocki" , Viresh Kumar , Jens Axboe , FUJITA Tomonori , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Airlie , Simona Vetter , driver-core@lists.linux.dev, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/7] cpufreq: rcpufreq_dt: use vertical import style Message-ID: Mail-Followup-To: Miguel Ojeda , Zhongqiu Han , Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Alice Ryhl , Trevor Gross , Tamir Duberstein , Alexandre Courbot , Onur =?iso-8859-1?Q?=D6zkan?= , Drew Fustini , Guo Ren , Fu Wei , Michal Wilczynski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , "Rafael J. Wysocki" , Viresh Kumar , Jens Axboe , FUJITA Tomonori , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Airlie , Simona Vetter , driver-core@lists.linux.dev, linux-riscv@lists.infradead.org, linux-pwm@vger.kernel.org, linux-pm@vger.kernel.org, linux-block@vger.kernel.org, netdev@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org References: <20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@gurudas.dev> <20260628-b4-rust-vertical-imports-v1-3-98bc71d4810b@gurudas.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Envelope-From: linux@gurudas.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260704_180202_669963_CF5EAD86 X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMzAsIDIwMjYgYXQgMTA6MzU6MDBBTSArMDIwMCwgTWlndWVsIE9qZWRhIHdy b3RlOgo+IE9uIE1vbiwgSnVuIDI5LCAyMDI2IGF0IDI6NDPigK9QTSBaaG9uZ3FpdSBIYW4KPiA8 emhvbmdxaXUuaGFuQG9zcy5xdWFsY29tbS5jb20+IHdyb3RlOgo+ID4KPiA+IElmIHRoZSBwcmVm ZXJyZWQgc3R5bGUgaXMgdG8gcGxhY2UgZWFjaCBpbXBvcnRlZCBpdGVtIG9uIGl0cyBvd24gbGlu ZSwKPiA+IHNob3VsZG4ndCBpbXBvcnRzIHN1Y2ggYXMKPiA+Cj4gPiAgICAgIGNwdSwgY3B1ZnJl cSwKPiA+Cj4gPiBiZSBmb3JtYXR0ZWQgc2ltaWxhcmx5IGFzIHdlbGw/Cj4gCj4gSW5kZWVkLCBn b29kIGV5ZXMuCj4gCj4gVG8gZG8gd2hhdCB3ZSB3YW50LCBgcnVzdGZtdGAgbmVlZHMgdGhlIGAv L2AgYXQgdGhlIGVuZCBvZiB0aGF0IGxldmVsCj4gdG9vIChpbiB0aGUgZnV0dXJlLCBpdCB3aWxs IGJlIHdpdGhvdXQgdGhlIGAvL2ApLCBpLmUuIHRoZSBwYXRjaAo+IHByb2JhYmx5IHBhc3NlcyBg cnVzdGZtdGNoZWNrYCwgYnV0IGl0IHN0aWxsIG5lZWRzIHRvIHNwbGl0IHRoYXQgbGluZQo+IGFu ZCBhZGQgdGhlIG90aGVyIGAvL2AuCgpIaSBaaG9uZ3FpdSwgTWlndWVsOgoKWWVzLCBJIGRpZCBy dW4gYG1ha2UgTExWTT0xIHJ1c3RmbXRjaGVja2AgYW5kIGl0IHBhc3NlZCBvbiB0aGlzIHNlcmll cy4gSSB3aWxsIGZpeAp0aGUgbWlzc2VkIG9uZXMgaW4gdjIuCgpXaGlsZSBpbnZlc3RpZ2F0aW5n IHRoaXMsIEkgZm91bmQgdGhhdCB0aGF0IGFkZGluZyB0aGlzIGNvbmZpZyBgaW1wb3J0c19sYXlv dXQgPQoiVmVydGljYWwiYCB0byB0aGUgcnVzdGZtdCBvcHRpb25zIHdvdWxkIGZpeCBhbGwgdGhl IGltcG9ydHMgYXV0b21hdGljYWxseSwgaW5jbHVkaW5nCnRoZSBvbmVzIEkgbWlzc2VkLiBJIHJh biBpdCBsb2NhbGx5IG9uIHRoZSBmaWxlcyB0b3VjaGVkIGluIHRoaXMgc2VyaWVzIHVzaW5nIHJ1 c3RmbXQKbmlnaHRseSBhbmQgaXQgY29ycmVjdGx5IGZpeGVkIHRoZSBpbXBvcnRzIGFzIGRlc2ly ZWQ6CgogICAgcnVzdHVwIHJ1biBuaWdodGx5IHJ1c3RmbXQgLS11bnN0YWJsZS1mZWF0dXJlcyBc CiAgICAgIC0tY29uZmlnICJpbXBvcnRzX2xheW91dD1WZXJ0aWNhbCIgXAogICAgICAtLWNvbmZp Zy1wYXRoIC5ydXN0Zm10LnRvbWwgPGZpbGU+CgpCdXQgdW5mb3J0dW5hdGVseSwgc2luY2UgYGlt cG9ydHNfbGF5b3V0YCBpcyBhbiB1bnN0YWJsZSBvcHRpb24gY3VycmVudGx5IFsxXSwgaXQKY2Fu bm90IGJlIHVzZWQgc3RyYWlnaHRhd2F5LgoKSG93ZXZlciwgLnJ1c3RmbXQudG9tbCBhbHJlYWR5 IGhhcyBhIHNlY3Rpb24gb2YgY29tbWVudGVkLW91dCB1bnN0YWJsZSBvcHRpb25zIGtlcHQKYXMg YSByZWZlcmVuY2UgZm9yIHdoZW4gdGhleSBzdGFiaWxpemUuIFdvdWxkIGl0IG1ha2Ugc2Vuc2Ug dG8gYWRkIGAjaW1wb3J0c19sYXlvdXQgPQoiVmVydGljYWwiYCB0aGVyZT8gSWYgc28sIEkgY2Fu IGluY2x1ZGUgaXQgaW4gdjIuCgpbMV06IGh0dHBzOi8vZ2l0aHViLmNvbS9ydXN0LWxhbmcvcnVz dGZtdC9pc3N1ZXMvMzM2MQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1yaXNjdgo=