From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1C523FC41 for ; Sun, 5 Jul 2026 16:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783270379; cv=none; b=iuYVSH8dfAviZt7CrkujS0ejP7vX5wTFE4c42i/T7ogPpSB/QkUs8UjOiBOHlTRZSuThodm16abDeI0nGNKjrIbcES1nywUdcOTAE4SpojdG3+X0nGCiV6YQ4u9W1Rz3txD3ksbqKLpVNQPd6CPL4Cejt8rbCngNSsvdsIQey/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783270379; c=relaxed/simple; bh=/p9SqCAudaEeayYVtuurDDYaw75+2MAabegoXuCpGdI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=MLZBRrgHd7KR418cjj35CEpKmXQz1A16pEkgnso/6+LkR97Q/tNGACpvDTTDvudL82zAlgu22Bi9yp77XVKsgTQ9/J0ciud0fnpxnl+KeNFnuCAUdRErO893PfBpeJbhnQSEHMwPsGAQ2YQMP1nVaQ3pSdGaCDA/kA0NB6QQO3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fsMagOzZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fsMagOzZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783270377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=pJuvFQHHadksuecKOReW4waT7xmqFV9y9SLNYqXptjE=; b=fsMagOzZRTwuu1AD0aDRuJbxLfIVopbv41isUEDyB4KQ3heTqABPg9fjuHziZ1lKLFZcbx N0bhKlk1XD4W2jSeRI3liKU7i0XrLUk2OugMxHhe0aPIvtR3K8hd9aJZ2wgjprmnNhj5ZN t4mMUY1sPf+v/YXTlK8L3b3fkvf9/I8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-228-wq6eaybtNaayAyYa6immrw-1; Sun, 05 Jul 2026 12:52:53 -0400 X-MC-Unique: wq6eaybtNaayAyYa6immrw-1 X-Mimecast-MFC-AGG-ID: wq6eaybtNaayAyYa6immrw_1783270372 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D09121956052; Sun, 5 Jul 2026 16:52:51 +0000 (UTC) Received: from fedora (unknown [10.44.32.112]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 90E6C1686; Sun, 5 Jul 2026 16:52:47 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Jul 2026 18:52:51 +0200 (CEST) Date: Sun, 5 Jul 2026 18:52:45 +0200 From: Oleg Nesterov To: John Johansen , Georgia Garcia , Paul Moore , James Morris , "Serge E. Hallyn" Cc: apparmor@lists.ubuntu.com, linux-kernel@vger.kernel.org Subject: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing NULL works, but: - this works "by accident" and looks as if the caller doesn't understand the signal sending API. - more importantly, this hides the usage of SEND_SIG_NOINFO from grep, and this is really bad. Signed-off-by: Oleg Nesterov --- security/apparmor/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c index 4a60b6fda75f..15e42e96b163 100644 --- a/security/apparmor/audit.c +++ b/security/apparmor/audit.c @@ -192,7 +192,7 @@ int aa_audit(int type, struct aa_profile *profile, aa_audit_msg(type, ad, cb); if (ad->type == AUDIT_APPARMOR_KILL) - (void)send_sig_info(profile->signal, NULL, + send_sig_info(profile->signal, SEND_SIG_NOINFO, ad->common.type == LSM_AUDIT_DATA_TASK && ad->common.u.tsk ? ad->common.u.tsk : current); -- 2.52.0