From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09F506FBF for ; Sun, 5 Jul 2026 18:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783277297; cv=none; b=TUd1uo8ENwBHp3+OcB9tmGmLsdWt1qyvXAxu/R/d9kcvNsBHEyYwgKWDl8m17cV5GYM/BPdyt/E/dFf2bTabZ7KUULCEp91RENUlUakOWebi35vmjvpKyrE/HykhcaDtigAtuA3HbF51akCjSIBlzns5ImifHFcGx/2uPX8Olgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783277297; c=relaxed/simple; bh=mWkzwW8kp+Pt/ovb1syO0GCSYgoRYkg4mtBXyefJpk4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FiKBIp3SO3IELbIknqXE94rT4DliLSGwCspU4tAwPwrFj+nMTTA4Hx+19jekzQQm/1o65tV2AOJytBQbVE8ncrQFdrNDWhn56IdIDDfC9V9v1OdRmMEgVrr7L+y0HfN9BxFbAvXhqBdQ5yY7t1lgegjxgE770bAauOIICNEbhcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BU/hr7FB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BU/hr7FB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783277295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mj4Lar90xZNm+BL18UC32WmoPgboLxVy8By9N33EPos=; b=BU/hr7FB5aM++nZRXk59bHwfsa4MqKUv0f7LTvWnvrX07W21Rp80+cRafH1UjK8jOd7OYW NbWp+rA3+MCrFQqJljUIqiT+gVZ2+I4MfU9vBvhm/RZEgPC/sc1Tx4HuHsx2Ltsd3hAYN7 70OTODWqHINkJC5tLJ7rUbXeGkN9EnM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-676-3UqcXPImOcyk_WgjeI8yOg-1; Sun, 05 Jul 2026 14:48:11 -0400 X-MC-Unique: 3UqcXPImOcyk_WgjeI8yOg-1 X-Mimecast-MFC-AGG-ID: 3UqcXPImOcyk_WgjeI8yOg_1783277290 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 97C4B19560B9; Sun, 5 Jul 2026 18:48:09 +0000 (UTC) Received: from fedora (unknown [10.44.32.112]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 08025180058F; Sun, 5 Jul 2026 18:48:05 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Jul 2026 20:48:09 +0200 (CEST) Date: Sun, 5 Jul 2026 20:48:04 +0200 From: Oleg Nesterov To: Bradley Morgan Cc: apparmor@lists.ubuntu.com, georgia.garcia@canonical.com, jmorris@namei.org, john.johansen@canonical.com, linux-kernel@vger.kernel.org, paul@paul-moore.com, serge@hallyn.com Subject: Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit() Message-ID: References: <65E9B858-C580-41A3-9B39-B383ED5F0ACF@grrlz.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65E9B858-C580-41A3-9B39-B383ED5F0ACF@grrlz.net> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 07/05, Bradley Morgan wrote: > > > SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing > > NULL works, but: > > > > - this works "by accident" and looks as if the caller doesn't understand > > the signal sending API. > > > > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep, > > and this is really bad. > - also drop the now redundant (void) Yes, but the "void" cast was never necessary, I guess. and just in case... To me the usage of SEND_SIG_NOINFO here doesn't look right with or without this change. Perhaps I am wrong, but please lets not discuss this right now, this connects to other cleanups I have in mind. The purpose of this change is to make aa_audit() grep-friendly wrt SEND_SIG_NOINFO. And because send_sig_info(NULL) looks "just wrong" to me, no matter what. > Reviewed-by: Bradley Morgan Thanks, > Also, feel free to CC me in signal patches, so I can review, from you > or from others. OK, will do. Oleg.