From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48207C43458 for ; Mon, 6 Jul 2026 07:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vkuUxGQ0uFrxtOPinhR8L41LkvCWotjCfYcmskbbwnI=; b=dY0MZ7ZW+pFy2u+iKJ7W8sqGpK 47nlhcRRLMC/eNhMVujCJo5z0/Mzfap+qjR6O8jY7d0iR+/N6v+ctlRwJpw2d8ZUZ8mfCzhCJ99SR QPBlSwdVyJAst972DqG2DjCfwnfLJJppctDaYsOnSV+yH45EXKUCEHJ41CXPgHX/0SV5Fe0tGGyt2 k0M2/T2FA1w+Kwl6hC6/w6lW5aNtxBumNuN0Xo12iu0mCuYR3ctjsWBwFGEaN0npdY6mUwtR61nYk tUkmNZ4udPhjtw0uECmhavbjiSZF9xn+VkDPXva213zeEsXrqgNUss16FTiocHj7kmHH+Y2qo9jsc 4wBc1OuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcR-0000000BiN3-1HUv; Mon, 06 Jul 2026 07:19:55 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcO-0000000BiL0-1pRm for linux-rockchip@lists.infradead.org; Mon, 06 Jul 2026 07:19:54 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-4720d22c94aso2637502f8f.1 for ; Mon, 06 Jul 2026 00:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783322390; x=1783927190; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=m9ANpRyHkZO0DNPZ5tpdKb0G3H+1KfZJD+iijO0+3zVOCMeat9lBhEHGTgN3E7M8XZ WXh7qCsaJBM+yO/5fkUF0Lu0pCcNCLbOWhCgrOszKtcULKYXcyc00lP3rZufIl7SwMrU ykyCW0/4gevAjru7WnD5k76uK5Wq2JAgykYL7h0CviZ7+wSV+8R6vL3bD8D10u5dTFJv 173DwNZa8s64Wr116PGM3q+fo3wm8zefAgLyq0KnGcc2oRlTxgNbwFocN7ECat6AH0hH lxeyz0kz3lsUWkeEISCGaAA/xVzvhTEhHXC44s0E0d27RjGEp7dGrPwUdFruXU2pV86A SGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322390; x=1783927190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=doR15iQWLNR2FB6dSMmO1VLT17UjywukzciLDNF91jWAVpNjtyi6UwAiPFq0buWWlf cCdlWoZk3licFEjsQDuG1UVThWd4GEDiNfnp6n0DtqlaW9PBsPoRTBh9p0yPordxGvR6 m7nraY2Q8szUijqj+m/GSoQmZWQcU/dPZOimw1VQsvEQGscEietuziI0EETHGfGYoLwO fCfFmy17b2ZrIhP2tPXvftIxUixv5QExx40/ErHdChqMPjDwbij6vDvZIl4ConmX+mp5 uS6MHKcci/dq4a0tGp5dpnJDC4s9gh05XyHEuu6IQbGlQ5OdF5+R7viSITZW+p16Qr6J cZ5g== X-Forwarded-Encrypted: i=1; AHgh+RqZPT1Y71/WyGXo0tsH+QIEZ3fOsLhvsga0BlcoEKCE88mVzsYfzO9UIVy3Gjq1ldJGM1U/7r89dJXDMPEqCg==@lists.infradead.org X-Gm-Message-State: AOJu0YyW8L2RxoQiNaxK5grknRP3PIcBIEZQ8gFw89jZHY7MVrOUEd5y NxWW48sbF4r1rVkGxvdSg8qlldne940ay7Gbw/Pr0NCBYjyQomkQsZObc+nM/lBmacY= X-Gm-Gg: AfdE7cnNaZFYX5BAKpH/6X3Mmo0pyB0kysFnzNLKNmX9QeDYVAWbxqgCMUEwhk7LKBB 7HUtKRRvto038SKKOlVVa5wdpiWedYvf4sDOsJU2+RBCkq7urZrQd1OO7QtMLn6CYeYC4ROqIce tz+Z52jNn9j7uz3qNb6xuNEdOFpHYCKozIYdUFR2TaodKYDLkq8C9UZR1hPCJSd31drUF1ycBr6 qfawFqfkQlF+LGGhRdSGzigtGdmyZ27/nCX1skNHMU8d6ZTcsT6NSDnuusrIxjyKFtVL5op04OL hPpi8JhJuVoe5645f56VJ0TS0fAqs443kkUDo4J656q9PlkK12vZfNKZ247fSGWWUr8ONG8GqmS +rSqkVoPUb/f64w+eTOa1gUcI0WhcuySN4Y87Eslmdk/rlZ+xl9aXC8EzJ3Zvjd/rp0I9yDmoDY 5ntqrlw9PlDqEFYsOiMatzyvm1Uy17qgGNbHbfzAfXsDHdMzN8GPXdXPr987urmp99/vPhajOlc psk X-Received: by 2002:a05:6000:d4f:b0:478:4de8:9b91 with SMTP id ffacd0b85a97d-47aac7d018dmr7577860f8f.41.1783322390409; Mon, 06 Jul 2026 00:19:50 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa039bcdasm23183058f8f.21.2026.07.06.00.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:19:49 -0700 (PDT) Date: Mon, 6 Jul 2026 09:19:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_001952_525321_6AFB36A6 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2866505570122658855==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============2866505570122658855== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64vjgbl764osolti" Content-Disposition: inline --64vjgbl764osolti Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello Chen, On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > On 7/5/2026 11:14 PM, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > - Use a single space in a of_device_id array terminator; A single spa= ce > > after the opening { and before the closing } in non-empty > > initializers; > > - No comma after an array terminator; > > - Also no trailing comma after a named initializer iff the > iff -> if This is actually intended. iff =3D "if and only if", see e.g. https://en.wikipedia.org/wiki/If_and_only_if . > > closing } is on the same line; > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) >=20 > [......] >=20 > > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-s= g2042.c > > index 7d07b0ca7d29..0b6461172e6a 100644 > > --- a/drivers/pwm/pwm-sophgo-sg2042.c > > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_= data =3D { > > static const struct of_device_id sg2042_pwm_ids[] =3D { > > { > > .compatible =3D "sophgo,sg2042-pwm", > > - .data =3D &sg2042_chip_data > > - }, > > - { > > + .data =3D &sg2042_chip_data, > > + }, { > > .compatible =3D "sophgo,sg2044-pwm", > > - .data =3D &sg2044_chip_data > > + .data =3D &sg2044_chip_data, > > }, > > { } > > }; >=20 > Changes to sophgo related files=EF=BC=9A >=20 > Reviewed-by: Chen Wang Thanks Uwe --64vjgbl764osolti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE----- --64vjgbl764osolti-- --===============2866505570122658855== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============2866505570122658855==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D6BA395ADE for ; Mon, 6 Jul 2026 07:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783322405; cv=none; b=J/5PEZX5Hw1anBEAvdXGgEJ9zPsEl7sUCHdmx0B0wQHCbZGPn0AsbDaMvIyIH4QyhRBLhu0zGCM4mS1hSyIEmWEIw5OLSS7flwkXJeoa/WsxljeLIuOoFzvoeTu09wfDBqXMFDBIu2N1FnXejR8skV35Q2DJH9+L2dwXm2d3ewU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783322405; c=relaxed/simple; bh=9ZXUr18b6ICtMwcnfCfQqcoadYON5lGnHDJBPbVufHU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sIV5I1lwEd4u5J+AkL/Sovp3dzWrQ61EXb5jcbLPQsGMLWDJcguj1Dm6IFVpGA3uauHcQCUzxRYgINEYdWSXoWioZJoldnVt25m6UOcGZBxEyFVcuyywk0QL8sBIatoOAwryC6fnp6BWlxevnzXgTiA3gTRe3GDuRvD5o/Tb+Lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Zl5T4/KD; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Zl5T4/KD" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-474560436c3so2591967f8f.0 for ; Mon, 06 Jul 2026 00:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783322390; x=1783927190; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=Zl5T4/KDsgVn9y77bkrN3Vo4LXpucrt0YSk3UxI3dPE6uHG4wr1a0ePCiIQG9BXnN7 tTUJmovfC4OuOdu+X6gBWIDvoM75oOFoBjAR/McjnE29YMltrcxeH9fDy2UYJNIAPC7V YXuO+KmzvpCufmoDgSjvOAuHcISCmJScZo98QgINYZ0lOMJQtUsMGys4sQJa3scFPQ7c 5odf/cb7fWdFzDN/alxmTlCRiCvIzJG0EfbWoHiXSLTvztjW1p3Mh8Z/pojwSCbX77cC XQI6DWIGWKVqchcgGhEpmf9zjRvh3i32HmunrPpuRqPiI+jpkJ4UNf66DgLyCDbtQpQL JoIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322390; x=1783927190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=Htd3Mr6Pc4lwivvL34FkJpWzgMQh3BmmkOkdTg26Jy6GktiiffgpIo7IqMWd4pd6le kaZNujIBuFvhpZh8uQoY+IThy9Hmom0sXGlcFMoFyYH3pI8lVn/F5jZAUvVblYGR3GCI S4ZunHLRDbhSs2rH+uKOD3XRjzyZm5YIJjSALvnExvd8USjvyVskxpSaAJS/euqeL32t mm4eo9F6W+AWZOmM6wSYccBtNY4bDfuCXcUwvOeCa4/lebPPIcmpK/nVPLkAFueIpF2+ 8cxAQiWGB44Oeb2sQ3tqIb/+f9Ft7b245vBwqm0kl7M1V+JO97kCpwuhaq7atouFPAmL 2LNQ== X-Forwarded-Encrypted: i=1; AHgh+RofYMT7590iKXCwr2QN8+XqDZeNnTveRwxlkXLgh9w/HvBTZda8SevBMiTtGTFMs6qXKy/0GnWMK2/hUNegrvc=@lists.linux.dev X-Gm-Message-State: AOJu0YwdWSjyjRN9moKZQXwJlgQ+ZxZp76ZHon/KYYKR+qr746Iujeml aoxmACe6YdirlD+7OYtUJlxOg4ergRrzmSLRwTzcwdE4PM4gMw7Cb78aAuGb5sAiwks= X-Gm-Gg: AfdE7ckfaNOSMayT79dnhJBYEZEDQ2jWQE44RgalMTOxEMHWqPJoaNrnE1jUAMieJ3t 91xmqqsOhzXB5ccDlXsVNOiT8+0Gzb+WiH/6XplW1/KeaOcYszmBcPyqWvuewGBBCIjvqH/NCWC xIOAcel4EccS2xq84hFUqMaKLahE+hZGytMlOmx6iqqx1ef7PxDRTreFmlb6I4/VzYBiA6QE94P hzKC73FBzROf0fWyPMKQBCyLxcqF0c83fzT/xWHRKhcryrNnRGNQm56y64Svc81XkV4kCPiC7QK idxE0s8nJRy8RyJg0VU1MG4VcDT7t090jD8oiMK48XNqyyu4SsM+xpVGkHCyrRDVAxLk2O/A0yF IHV9uD6svZAonW6G6CEjVRRW5li7i5hIg8KUZkJ4qqPjrNh2p+Go4bKot8WRueDb6W8aLi5qqLy HrMaQDdEt2iv5TavY9+0+hUzNRCWtcga0LFBdN8npXLn22WLlvqLub75qBJ1Xc8c7bNzzpJ05c6 Zie X-Received: by 2002:a05:6000:d4f:b0:478:4de8:9b91 with SMTP id ffacd0b85a97d-47aac7d018dmr7577860f8f.41.1783322390409; Mon, 06 Jul 2026 00:19:50 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa039bcdasm23183058f8f.21.2026.07.06.00.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:19:49 -0700 (PDT) Date: Mon, 6 Jul 2026 09:19:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64vjgbl764osolti" Content-Disposition: inline In-Reply-To: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> --64vjgbl764osolti Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello Chen, On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > On 7/5/2026 11:14 PM, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > - Use a single space in a of_device_id array terminator; A single spa= ce > > after the opening { and before the closing } in non-empty > > initializers; > > - No comma after an array terminator; > > - Also no trailing comma after a named initializer iff the > iff -> if This is actually intended. iff =3D "if and only if", see e.g. https://en.wikipedia.org/wiki/If_and_only_if . > > closing } is on the same line; > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) >=20 > [......] >=20 > > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-s= g2042.c > > index 7d07b0ca7d29..0b6461172e6a 100644 > > --- a/drivers/pwm/pwm-sophgo-sg2042.c > > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_= data =3D { > > static const struct of_device_id sg2042_pwm_ids[] =3D { > > { > > .compatible =3D "sophgo,sg2042-pwm", > > - .data =3D &sg2042_chip_data > > - }, > > - { > > + .data =3D &sg2042_chip_data, > > + }, { > > .compatible =3D "sophgo,sg2044-pwm", > > - .data =3D &sg2044_chip_data > > + .data =3D &sg2044_chip_data, > > }, > > { } > > }; >=20 > Changes to sophgo related files=EF=BC=9A >=20 > Reviewed-by: Chen Wang Thanks Uwe --64vjgbl764osolti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE----- --64vjgbl764osolti-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FA35C44500 for ; Mon, 6 Jul 2026 07:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kAFmnXtSLDDlRssRWu9EyIaHJMwAeLiRAnUVI6lhtIo=; b=0i8NRxXYivUKG62GuGnSocQAhn IolxWHdwIsnWiZMDtrfWkipuSmATpaYjsI/vpoDFOelZmuZGquu5XrHzo6+t21WhJqoQywWney1hL kow+TBq945SEgAoIYueepdkiekpglul/ZgyNU5fZMPkXIVXKLAJehbx1aUsDh2uilj86dR6eDzKxb rEePr9eH5eju10cztrqHuNk2Xr+XzMxhRXKDKbOjS1IcOCkJMm4ShQdAbseU65eywUV6peoChpXNn B299l9Fd1PHt/lo4dfUmjYTv+qEZBi8SauBfaqI3n+CA7NhHLJA20XDtPJOS2yKDhlncLoDSc0hx6 PAiLMKSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcS-0000000BiNu-2GuL; Mon, 06 Jul 2026 07:19:56 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcO-0000000BiKz-1q1x for linux-amlogic@lists.infradead.org; Mon, 06 Jul 2026 07:19:55 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-4720d22c94aso2637504f8f.1 for ; Mon, 06 Jul 2026 00:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783322390; x=1783927190; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=m9ANpRyHkZO0DNPZ5tpdKb0G3H+1KfZJD+iijO0+3zVOCMeat9lBhEHGTgN3E7M8XZ WXh7qCsaJBM+yO/5fkUF0Lu0pCcNCLbOWhCgrOszKtcULKYXcyc00lP3rZufIl7SwMrU ykyCW0/4gevAjru7WnD5k76uK5Wq2JAgykYL7h0CviZ7+wSV+8R6vL3bD8D10u5dTFJv 173DwNZa8s64Wr116PGM3q+fo3wm8zefAgLyq0KnGcc2oRlTxgNbwFocN7ECat6AH0hH lxeyz0kz3lsUWkeEISCGaAA/xVzvhTEhHXC44s0E0d27RjGEp7dGrPwUdFruXU2pV86A SGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322390; x=1783927190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=degjqdVmwkqzrhSpmkKc33VllRDqGOlzFk6Sw8PNb9zrHg+lNa7aaAWIM+F7zp0rlV PpDTTjaVMmukUkkGC2QZ+i1zch+bnND4a6zrMs37vgLgUsnnsozna4Ph2FzFPVRhOYas O0skC2KCTSTJEWYv/X0B8s8Eu7PgfDVhJp8JPg0woTxB088y8ckLjGfCI004538vXM/Z i7RDWWhDGpM+tTDuWUlHi6Q2nQ0QoH6uOcFBSMDGlU7hshb5XyzzNf+Q0WoQgNfirtMd WL5YwX4QngRjpWsQ5N2u0CEnWkjw7ajbrDEqEDCorR+vK6IOqHLGDr8KGTcR6FONAizp pTMw== X-Forwarded-Encrypted: i=1; AHgh+RrVHvvhMphk3DRzjmo1UpyDxf3M8I9Cu3DVXoTUgUzxW8lb+DvkeuNDihYBpAUAKO53FL2Nric9PVmvLFl+@lists.infradead.org X-Gm-Message-State: AOJu0YxUWDM3ff4KqIYkFJpPZmB0C7qMj3ekLqueoatECIZaLAY3GDHK xT8+h8NibIFcqsi9sF8gOPPKcX00Xkf1NeRezMVBguWGOifMLILhCLW4LVwDpqm7m+w= X-Gm-Gg: AfdE7cnGXyQ4T1XZApwGRCXmV2Ryqh7VyfEeePOzvWRQpwcmUnEqUfxM66ICZ+4Y72m nSqrRaxK8KFZM7WU9sWeP62VjfD1+gCODw5k+yiLxnVypUrHxaOeUw3hANhwgGPt/9uNpRrJUj9 NmzbIPxof7UaDXLEaIEDkh8joefQxZ7uPCfuTjMQNZW8Q0OrgMrLZlN6N731CHo6J4/06zXEqHQ lpl2dczVwfymUTHykQfQJ5RbCe796SwJxae3BjBdUlIgpqTQMsaiPp2eAG6+Pj9zGSXOxnr7zLL 6Zzi0hIQujbTMp6y8kecqSXc3V6rh6tkPdlepBMmh4PwtfhSOb4PW25sBhbqXfHnkesf9yFksnx 6nUm9rOeh3E+Fw4q2NxFUnDj7AB/tamyz7VV0wOGEHzLLXRW6VIotBMC62H+cC7NA5Ndn0IIqNb 2/012+R0qSMKS6zxw9rnZDKDY4TM6U2SVsHXcV2xXvmG6obNRAV0MMojNdOqEWxNzwfJMhml8t8 RAy X-Received: by 2002:a05:6000:d4f:b0:478:4de8:9b91 with SMTP id ffacd0b85a97d-47aac7d018dmr7577860f8f.41.1783322390409; Mon, 06 Jul 2026 00:19:50 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa039bcdasm23183058f8f.21.2026.07.06.00.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:19:49 -0700 (PDT) Date: Mon, 6 Jul 2026 09:19:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_001952_541784_C7F11B4B X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3766825496652221150==" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org --===============3766825496652221150== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64vjgbl764osolti" Content-Disposition: inline --64vjgbl764osolti Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello Chen, On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > On 7/5/2026 11:14 PM, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > - Use a single space in a of_device_id array terminator; A single spa= ce > > after the opening { and before the closing } in non-empty > > initializers; > > - No comma after an array terminator; > > - Also no trailing comma after a named initializer iff the > iff -> if This is actually intended. iff =3D "if and only if", see e.g. https://en.wikipedia.org/wiki/If_and_only_if . > > closing } is on the same line; > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) >=20 > [......] >=20 > > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-s= g2042.c > > index 7d07b0ca7d29..0b6461172e6a 100644 > > --- a/drivers/pwm/pwm-sophgo-sg2042.c > > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_= data =3D { > > static const struct of_device_id sg2042_pwm_ids[] =3D { > > { > > .compatible =3D "sophgo,sg2042-pwm", > > - .data =3D &sg2042_chip_data > > - }, > > - { > > + .data =3D &sg2042_chip_data, > > + }, { > > .compatible =3D "sophgo,sg2044-pwm", > > - .data =3D &sg2044_chip_data > > + .data =3D &sg2044_chip_data, > > }, > > { } > > }; >=20 > Changes to sophgo related files=EF=BC=9A >=20 > Reviewed-by: Chen Wang Thanks Uwe --64vjgbl764osolti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE----- --64vjgbl764osolti-- --===============3766825496652221150== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic --===============3766825496652221150==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E21B7C43458 for ; Mon, 6 Jul 2026 07:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BhrsHi++QYAPv+98ikOe3JqkyDQudGZ+GTWaeXjZAXc=; b=UdNAYOS+bSzb59v/URkOV8sH7H q4D8bXruNl4As0rfZzjVctul5wde9Xy76/8G2E6RjZU1nY5KusCEjB4OmyTu1OZ6EZO/8EMfZ8T/I G67HNstQZueqU9CwIOwAmVoKlQCX1pTZZd94uYkmmXIdzUZDfeheM8NOuC424LpsAxyqOiIut55hI y/akZzc7+V9sclpy2olzUahnFaLA9Um6OcpQz7bDXTD7vKOMXbbr0UTtm56yhj8GCLHlLS+Hxy7mC viyOWCocjxgibQQsISQN4RoTWcQ8MGIkvcrLZSo5Ku+HJVc5C3hwQMaMO+32hbnh89FS82VUQ1bEz rnwb284Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcU-0000000BiOw-05hj; Mon, 06 Jul 2026 07:19:58 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcO-0000000BiKx-1pL7 for linux-riscv@lists.infradead.org; Mon, 06 Jul 2026 07:19:55 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-474560436c3so2591962f8f.0 for ; Mon, 06 Jul 2026 00:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783322390; x=1783927190; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=m9ANpRyHkZO0DNPZ5tpdKb0G3H+1KfZJD+iijO0+3zVOCMeat9lBhEHGTgN3E7M8XZ WXh7qCsaJBM+yO/5fkUF0Lu0pCcNCLbOWhCgrOszKtcULKYXcyc00lP3rZufIl7SwMrU ykyCW0/4gevAjru7WnD5k76uK5Wq2JAgykYL7h0CviZ7+wSV+8R6vL3bD8D10u5dTFJv 173DwNZa8s64Wr116PGM3q+fo3wm8zefAgLyq0KnGcc2oRlTxgNbwFocN7ECat6AH0hH lxeyz0kz3lsUWkeEISCGaAA/xVzvhTEhHXC44s0E0d27RjGEp7dGrPwUdFruXU2pV86A SGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322390; x=1783927190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=UhwJ4LaONLZGjYA5w56ZaMx4Zy9Nu+F9r29XvJYtz6KNJKr1FvFcqNTf9bBxlQIdM4 HDbw0jq37R2iJ4namL+KsibBwaqyMgG0jgYRHqivgMbPsucyU2JU2BM/u7+bWi5jaNVp 9F4dsv90ybzyIAFPQ/mMf7Lf0UZbYh3i/dHay5AdWzSeWTqcffyvkLCaEOwjy5e5p4q6 ePi/H24SOWpE32FUrYnFux3LwpWOPi1+77hvLxcjUMUhhWr1bZeom2riXyXBycDbxy8P C0f4HHYbJjMdyZ7wvcGyfG/cefwIf65PnxQ2I+29XD9r14B9/7Lpm/Bhw+R9HajYrnnZ YUgw== X-Forwarded-Encrypted: i=1; AHgh+RqKp+QKucUkAN8AH2TPYo7dgOrdZ+BnpTTYXyvKQAREK/aWD8RAhIPPBoQgW4lnjzJIFzMKDTV46Fy2Ag==@lists.infradead.org X-Gm-Message-State: AOJu0YzJuK1LaY1OO7L330O5bM5BanX8lCiM0YYLMFYe9p5FH8PNXGBx mYOPMXtcHUqGtJ6yF8K5IhLKwe/yolnPdkLPbDu0phoEIQ/qTLzhYSI6JrRmdx/dYEk= X-Gm-Gg: AfdE7cmbWh4uC3kf8K9pJTBK8plFxx2okunnuOYRs4rVFoHdzpagxDnPV400Rg3jpfT 6lwFNq6FfqXJ+OsdsoUfvU0zlASYha78akxcPevAD3hT+nL1jDga5udwEzUHbKlA/ngAGSirOGu QfVuYv7RkSFqQ2ylNtCnADqcksDDIlbZA0yKbK6F0OiL0iTv6+1mF3fyrixm5W0RZR2oeFy9uN2 D6/RU1Jf+ju3BoPExtKG+9Qs27UQsFURM9hzxZq/C7jwlhDVT8B8W+yHQVpOX097+E/Ox8GY0cw pILbVVa0/sYejAO0CIihNK6L+i5rMKcaw2I9SNNe/xjblHCXzMikOJOfH9Sal3ifs/ppexeyo1v XkNHIGO7pekOLjy86riU49tWv8WLQwhhny2bAveNwYemaOVNS4T2zBujS32JrDsrVPB5/QNoQ28 nR9OXjrj+BGWa/qTxW1HJNP67hszpObAejmc8P72E2IhoAgHJZfH9KR3+0sgM5EU/Uoti1a5fFJ gHR X-Received: by 2002:a05:6000:d4f:b0:478:4de8:9b91 with SMTP id ffacd0b85a97d-47aac7d018dmr7577860f8f.41.1783322390409; Mon, 06 Jul 2026 00:19:50 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa039bcdasm23183058f8f.21.2026.07.06.00.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:19:49 -0700 (PDT) Date: Mon, 6 Jul 2026 09:19:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_001952_555403_54DDA9F7 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3330912436483706350==" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org --===============3330912436483706350== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64vjgbl764osolti" Content-Disposition: inline --64vjgbl764osolti Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello Chen, On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > On 7/5/2026 11:14 PM, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > - Use a single space in a of_device_id array terminator; A single spa= ce > > after the opening { and before the closing } in non-empty > > initializers; > > - No comma after an array terminator; > > - Also no trailing comma after a named initializer iff the > iff -> if This is actually intended. iff =3D "if and only if", see e.g. https://en.wikipedia.org/wiki/If_and_only_if . > > closing } is on the same line; > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) >=20 > [......] >=20 > > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-s= g2042.c > > index 7d07b0ca7d29..0b6461172e6a 100644 > > --- a/drivers/pwm/pwm-sophgo-sg2042.c > > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_= data =3D { > > static const struct of_device_id sg2042_pwm_ids[] =3D { > > { > > .compatible =3D "sophgo,sg2042-pwm", > > - .data =3D &sg2042_chip_data > > - }, > > - { > > + .data =3D &sg2042_chip_data, > > + }, { > > .compatible =3D "sophgo,sg2044-pwm", > > - .data =3D &sg2044_chip_data > > + .data =3D &sg2044_chip_data, > > }, > > { } > > }; >=20 > Changes to sophgo related files=EF=BC=9A >=20 > Reviewed-by: Chen Wang Thanks Uwe --64vjgbl764osolti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE----- --64vjgbl764osolti-- --===============3330912436483706350== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --===============3330912436483706350==--